You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2011/08/17 14:55:28 UTC
[jira] [Created] (LUCENE-3378) Some contribs depend on core tests
to be compiled and fail when ant clean was done before
Some contribs depend on core tests to be compiled and fail when ant clean was done before
-----------------------------------------------------------------------------------------
Key: LUCENE-3378
URL: https://issues.apache.org/jira/browse/LUCENE-3378
Project: Lucene - Java
Issue Type: Bug
Components: general/test
Affects Versions: 3.4, 4.0
Reporter: Uwe Schindler
If you do "ant clean" on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call "ant test", the build of tests fails:
- contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course)
- contrib/misc/TestIndexSplitter uses a core class to build its index
To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without "ant clean" before. Then we can fix this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3378) Some contribs depend on core tests
to be compiled and fail when ant clean was done before
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086489#comment-13086489 ]
Uwe Schindler commented on LUCENE-3378:
---------------------------------------
I think thats fine as a start. This would not work in test-framework in trunk, but there we dont have that problem, as all QParsers live in one module. So the abstract base class can live there.
> Some contribs depend on core tests to be compiled and fail when ant clean was done before
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-3378
> URL: https://issues.apache.org/jira/browse/LUCENE-3378
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Affects Versions: 3.4, 4.0
> Reporter: Uwe Schindler
> Attachments: LUCENE-3378.patch, LUCENE-3378_qp.patch
>
>
> If you do "ant clean" on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call "ant test", the build of tests fails:
> - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course)
> - contrib/misc/TestIndexSplitter uses a core class to build its index
> To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without "ant clean" before. Then we can fix this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3378) Some contribs depend on core tests
to be compiled and fail when ant clean was done before
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086336#comment-13086336 ]
Robert Muir commented on LUCENE-3378:
-------------------------------------
analyzers was broken too, i moved VocabularyAssert to tests-framework (trunk too)
> Some contribs depend on core tests to be compiled and fail when ant clean was done before
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-3378
> URL: https://issues.apache.org/jira/browse/LUCENE-3378
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Affects Versions: 3.4, 4.0
> Reporter: Uwe Schindler
> Attachments: LUCENE-3378.patch
>
>
> If you do "ant clean" on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call "ant test", the build of tests fails:
> - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course)
> - contrib/misc/TestIndexSplitter uses a core class to build its index
> To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without "ant clean" before. Then we can fix this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3378) Some contribs depend on core tests
to be compiled and fail when ant clean was done before
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086289#comment-13086289 ]
Robert Muir commented on LUCENE-3378:
-------------------------------------
I agree, in some of these cases, we might be able to refactor helper methods and such into tests-framework, which would be cleaner.
we shouldn't necessarily do this in all cases, but at least clean up the obvious ones
> Some contribs depend on core tests to be compiled and fail when ant clean was done before
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-3378
> URL: https://issues.apache.org/jira/browse/LUCENE-3378
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Affects Versions: 3.4, 4.0
> Reporter: Uwe Schindler
>
> If you do "ant clean" on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call "ant test", the build of tests fails:
> - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course)
> - contrib/misc/TestIndexSplitter uses a core class to build its index
> To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without "ant clean" before. Then we can fix this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3378) Some contribs depend on core tests
to be compiled and fail when ant clean was done before
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-3378:
--------------------------------
Attachment: LUCENE-3378_qp.patch
ok this fixes branch_3x.
I refactored TestQueryParser into a QueryParserTestBase, and extended it by the core TestQP and this ExtendableQP.
Really we should clean this up more for a bunch of the other QPs, but this is a start and fixes the build.
> Some contribs depend on core tests to be compiled and fail when ant clean was done before
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-3378
> URL: https://issues.apache.org/jira/browse/LUCENE-3378
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Affects Versions: 3.4, 4.0
> Reporter: Uwe Schindler
> Attachments: LUCENE-3378.patch, LUCENE-3378_qp.patch
>
>
> If you do "ant clean" on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call "ant test", the build of tests fails:
> - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course)
> - contrib/misc/TestIndexSplitter uses a core class to build its index
> To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without "ant clean" before. Then we can fix this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3378) Some contribs depend on core tests
to be compiled and fail when ant clean was done before
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086310#comment-13086310 ]
Uwe Schindler commented on LUCENE-3378:
---------------------------------------
Patch for trunk looks fine! Thanks!
The stupid 3.x-extends-TestQueryParser problem is more challenging :(
> Some contribs depend on core tests to be compiled and fail when ant clean was done before
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-3378
> URL: https://issues.apache.org/jira/browse/LUCENE-3378
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Affects Versions: 3.4, 4.0
> Reporter: Uwe Schindler
> Attachments: LUCENE-3378.patch
>
>
> If you do "ant clean" on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call "ant test", the build of tests fails:
> - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course)
> - contrib/misc/TestIndexSplitter uses a core class to build its index
> To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without "ant clean" before. Then we can fix this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3378) Some contribs depend on core tests
to be compiled and fail when ant clean was done before
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-3378.
---------------------------------
Resolution: Fixed
Fix Version/s: 4.0
3.4
All done... its good you brought this up Uwe,
in fact the ExtendableQPTest was not overriding the correct method, so really it wasnt being tested (we were just running the core QP tests again!!!!)
> Some contribs depend on core tests to be compiled and fail when ant clean was done before
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-3378
> URL: https://issues.apache.org/jira/browse/LUCENE-3378
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Affects Versions: 3.4, 4.0
> Reporter: Uwe Schindler
> Fix For: 3.4, 4.0
>
> Attachments: LUCENE-3378.patch, LUCENE-3378_qp.patch
>
>
> If you do "ant clean" on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call "ant test", the build of tests fails:
> - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course)
> - contrib/misc/TestIndexSplitter uses a core class to build its index
> To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without "ant clean" before. Then we can fix this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3378) Some contribs depend on core tests
to be compiled and fail when ant clean was done before
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086320#comment-13086320 ]
Robert Muir commented on LUCENE-3378:
-------------------------------------
I agree, so the issue is still open for 3.x
What i did was merge back the applicable improvements from the trunk patch, but the contrib classpath still contains src/test for now.
I'll try to look at the queryparser tests, in general maybe we can cleanup here, i've noticed a lot of duplication in the tests before.
hopefully we can clean up the tests a bit and fix the build at the same time...
> Some contribs depend on core tests to be compiled and fail when ant clean was done before
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-3378
> URL: https://issues.apache.org/jira/browse/LUCENE-3378
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Affects Versions: 3.4, 4.0
> Reporter: Uwe Schindler
> Attachments: LUCENE-3378.patch
>
>
> If you do "ant clean" on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call "ant test", the build of tests fails:
> - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course)
> - contrib/misc/TestIndexSplitter uses a core class to build its index
> To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without "ant clean" before. Then we can fix this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3378) Some contribs depend on core tests
to be compiled and fail when ant clean was done before
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-3378:
--------------------------------
Attachment: LUCENE-3378.patch
patch for trunk
> Some contribs depend on core tests to be compiled and fail when ant clean was done before
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-3378
> URL: https://issues.apache.org/jira/browse/LUCENE-3378
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Affects Versions: 3.4, 4.0
> Reporter: Uwe Schindler
> Attachments: LUCENE-3378.patch
>
>
> If you do "ant clean" on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call "ant test", the build of tests fails:
> - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course)
> - contrib/misc/TestIndexSplitter uses a core class to build its index
> To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without "ant clean" before. Then we can fix this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3378) Some contribs depend on core tests
to be compiled and fail when ant clean was done before
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086302#comment-13086302 ]
Robert Muir commented on LUCENE-3378:
-------------------------------------
Here's the explanation (since patch will not apply as it contains svn moves):
# disabled the lucene src/test from contrib classpath
# moved the fieldcacherewritemethod and tests to core src/test, as discussed in LUCENE-3271
# moved the europarl data file to tests-framework, because some contribs use it
# moved that createDocument() method from TestIndexWriterReader to DocHelper
if there are no objections I would like to commit soon.
> Some contribs depend on core tests to be compiled and fail when ant clean was done before
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-3378
> URL: https://issues.apache.org/jira/browse/LUCENE-3378
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Affects Versions: 3.4, 4.0
> Reporter: Uwe Schindler
> Attachments: LUCENE-3378.patch
>
>
> If you do "ant clean" on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call "ant test", the build of tests fails:
> - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course)
> - contrib/misc/TestIndexSplitter uses a core class to build its index
> To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without "ant clean" before. Then we can fix this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org