You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2016/10/02 00:07:21 UTC
Review Request 52468: Add FlakyTest category to tests with open bugs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52468/
-----------------------------------------------------------
Review request for geode.
Repository: geode
Description
-------
Annotate test methods with FlakyTest category if there is an open
bug for that test. This will improve the signal/noise ratio for
unit/integration/distributed tests. Flaky tests are still run
as part of precheckin and flakyTest targets.
Diffs
-----
extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java PRE-CREATION
geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java PRE-CREATION
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsOnGroupsFunctionExecutionDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsOffHeapDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/query/dunit/CompiledInDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/ConcurrentIndexOperationsOnOverflowRegionDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryRegionCloseDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/distributed/DistributedSystemDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/distributed/SystemAdminDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/distributed/internal/ConsoleDistributionManagerDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionSingleHopDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/execute/FunctionServiceBase.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionFailoverDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionSelectorNoSingleHopDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRColocationDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36805DUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableRegistrationDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/CompositeTypeTestDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/MemberMBeanAttributesDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/QueryDataDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/RegionCreateDestroyDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/UniversalMembershipListenerAdapterDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandsDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueueCommandsDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMetricsDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthorizationJUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/security/MultiUserDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/redis/HashesJUnitTest.java f219d810dede3a225eacbfda3fc7af80179fd289
geode-core/src/test/java/org/apache/geode/redis/RedisDistDUnitTest.java eb877974e8f221142222e432d95c7dc4cfa944f2
geode-core/src/test/java/org/apache/geode/security/ClientAuthenticationDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/security/DeltaClientPostAuthorizationDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/security/IntegratedClientAuthDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/security/IntegratedClientRegionClearAuthDistributedTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleDistributedTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleIntegrationTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/security/PDXPostProcessorDUnitTest.java PRE-CREATION
geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqResultSetUsingPoolDUnitTest.java PRE-CREATION
geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java PRE-CREATION
geode-cq/src/test/java/org/apache/geode/internal/cache/PutAllCSDUnitTest.java PRE-CREATION
geode-cq/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java PRE-CREATION
geode-cq/src/test/java/org/apache/geode/management/internal/cli/commands/DurableClientCommandsDUnitTest.java PRE-CREATION
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_1_DUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/PDXNewWanDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagationDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagationLoopBackDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagation_PartitionedRegionDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateGatewayReceiverDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandGatewayReceiverStartDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandGatewayReceiverStopDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandStatusDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/management/WANManagementDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationDUnitTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/management/internal/pulse/TestRemoteClusterDUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/52468/diff/
Testing
-------
Thanks,
Anthony Baker
Re: Review Request 52468: Add FlakyTest category to tests with open
bugs
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52468/#review151125
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On Oct. 2, 2016, 12:07 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52468/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2016, 12:07 a.m.)
>
>
> Review request for geode.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Annotate test methods with FlakyTest category if there is an open
> bug for that test. This will improve the signal/noise ratio for
> unit/integration/distributed tests. Flaky tests are still run
> as part of precheckin and flakyTest targets.
>
>
> Diffs
> -----
>
> extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java PRE-CREATION
> geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java PRE-CREATION
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsOnGroupsFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsOffHeapDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/CompiledInDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/ConcurrentIndexOperationsOnOverflowRegionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryRegionCloseDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/DistributedSystemDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/SystemAdminDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/internal/ConsoleDistributionManagerDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionSingleHopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/FunctionServiceBase.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionFailoverDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionSelectorNoSingleHopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRColocationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36805DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableRegistrationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/CompositeTypeTestDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/MemberMBeanAttributesDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/QueryDataDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/RegionCreateDestroyDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/UniversalMembershipListenerAdapterDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueueCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMetricsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthorizationJUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/security/MultiUserDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/redis/HashesJUnitTest.java f219d810dede3a225eacbfda3fc7af80179fd289
> geode-core/src/test/java/org/apache/geode/redis/RedisDistDUnitTest.java eb877974e8f221142222e432d95c7dc4cfa944f2
> geode-core/src/test/java/org/apache/geode/security/ClientAuthenticationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/DeltaClientPostAuthorizationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedClientAuthDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedClientRegionClearAuthDistributedTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleDistributedTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/PDXPostProcessorDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqResultSetUsingPoolDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/internal/cache/PutAllCSDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/management/internal/cli/commands/DurableClientCommandsDUnitTest.java PRE-CREATION
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_1_DUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/PDXNewWanDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagationLoopBackDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagation_PartitionedRegionDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateGatewayReceiverDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandGatewayReceiverStartDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandGatewayReceiverStopDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandStatusDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/WANManagementDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/internal/pulse/TestRemoteClusterDUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 52468: Add FlakyTest category to tests with open
bugs
Posted by Kevin Duling <kd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52468/#review151174
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Duling
On Oct. 1, 2016, 5:07 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52468/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2016, 5:07 p.m.)
>
>
> Review request for geode.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Annotate test methods with FlakyTest category if there is an open
> bug for that test. This will improve the signal/noise ratio for
> unit/integration/distributed tests. Flaky tests are still run
> as part of precheckin and flakyTest targets.
>
>
> Diffs
> -----
>
> extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java PRE-CREATION
> geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java PRE-CREATION
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsOnGroupsFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsOffHeapDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/CompiledInDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/ConcurrentIndexOperationsOnOverflowRegionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryRegionCloseDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/DistributedSystemDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/SystemAdminDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/internal/ConsoleDistributionManagerDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionSingleHopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/FunctionServiceBase.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionFailoverDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionSelectorNoSingleHopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRColocationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36805DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableRegistrationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/CompositeTypeTestDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/MemberMBeanAttributesDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/QueryDataDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/RegionCreateDestroyDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/UniversalMembershipListenerAdapterDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueueCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMetricsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthorizationJUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/security/MultiUserDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/redis/HashesJUnitTest.java f219d810dede3a225eacbfda3fc7af80179fd289
> geode-core/src/test/java/org/apache/geode/redis/RedisDistDUnitTest.java eb877974e8f221142222e432d95c7dc4cfa944f2
> geode-core/src/test/java/org/apache/geode/security/ClientAuthenticationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/DeltaClientPostAuthorizationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedClientAuthDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedClientRegionClearAuthDistributedTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleDistributedTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/PDXPostProcessorDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqResultSetUsingPoolDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/internal/cache/PutAllCSDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/management/internal/cli/commands/DurableClientCommandsDUnitTest.java PRE-CREATION
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_1_DUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/PDXNewWanDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagationLoopBackDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagation_PartitionedRegionDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateGatewayReceiverDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandGatewayReceiverStartDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandGatewayReceiverStopDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandStatusDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/WANManagementDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/internal/pulse/TestRemoteClusterDUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 52468: Add FlakyTest category to tests with open
bugs
Posted by Scott Jewell <sj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52468/#review151186
-----------------------------------------------------------
Ship it!
Ship It!
- Scott Jewell
On Oct. 2, 2016, 12:07 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52468/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2016, 12:07 a.m.)
>
>
> Review request for geode.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Annotate test methods with FlakyTest category if there is an open
> bug for that test. This will improve the signal/noise ratio for
> unit/integration/distributed tests. Flaky tests are still run
> as part of precheckin and flakyTest targets.
>
>
> Diffs
> -----
>
> extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java PRE-CREATION
> geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java PRE-CREATION
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsOnGroupsFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsOffHeapDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/CompiledInDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/ConcurrentIndexOperationsOnOverflowRegionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryRegionCloseDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/DistributedSystemDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/SystemAdminDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/internal/ConsoleDistributionManagerDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionSingleHopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/FunctionServiceBase.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionFailoverDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionSelectorNoSingleHopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRColocationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36805DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableRegistrationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/CompositeTypeTestDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/MemberMBeanAttributesDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/QueryDataDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/RegionCreateDestroyDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/UniversalMembershipListenerAdapterDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueueCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMetricsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthorizationJUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/security/MultiUserDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/redis/HashesJUnitTest.java f219d810dede3a225eacbfda3fc7af80179fd289
> geode-core/src/test/java/org/apache/geode/redis/RedisDistDUnitTest.java eb877974e8f221142222e432d95c7dc4cfa944f2
> geode-core/src/test/java/org/apache/geode/security/ClientAuthenticationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/DeltaClientPostAuthorizationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedClientAuthDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedClientRegionClearAuthDistributedTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleDistributedTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/PDXPostProcessorDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqResultSetUsingPoolDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/internal/cache/PutAllCSDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/management/internal/cli/commands/DurableClientCommandsDUnitTest.java PRE-CREATION
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_1_DUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/PDXNewWanDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagationLoopBackDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagation_PartitionedRegionDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateGatewayReceiverDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandGatewayReceiverStartDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandGatewayReceiverStopDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandStatusDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/WANManagementDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/internal/pulse/TestRemoteClusterDUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 52468: Add FlakyTest category to tests with open
bugs
Posted by Anthony Baker <ab...@apache.org>.
> On Oct. 3, 2016, 5:30 p.m., Dan Smith wrote:
> > I noticed you added additional ticket numbers to the same tests in a couple of places. Do we really need multiple tickets for the same test, or would it make sense to just close one of the tickets as a duplicate?
Usually what's happening is the test was defined in a superclass, but the failure occurred when the subclass was run.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52468/#review151189
-----------------------------------------------------------
On Oct. 2, 2016, 12:07 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52468/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2016, 12:07 a.m.)
>
>
> Review request for geode.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Annotate test methods with FlakyTest category if there is an open
> bug for that test. This will improve the signal/noise ratio for
> unit/integration/distributed tests. Flaky tests are still run
> as part of precheckin and flakyTest targets.
>
>
> Diffs
> -----
>
> extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java PRE-CREATION
> geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java PRE-CREATION
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsOnGroupsFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsOffHeapDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/CompiledInDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/ConcurrentIndexOperationsOnOverflowRegionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryRegionCloseDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/DistributedSystemDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/SystemAdminDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/internal/ConsoleDistributionManagerDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionSingleHopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/FunctionServiceBase.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionFailoverDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionSelectorNoSingleHopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRColocationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36805DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableRegistrationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/CompositeTypeTestDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/MemberMBeanAttributesDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/QueryDataDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/RegionCreateDestroyDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/UniversalMembershipListenerAdapterDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueueCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMetricsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthorizationJUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/security/MultiUserDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/redis/HashesJUnitTest.java f219d810dede3a225eacbfda3fc7af80179fd289
> geode-core/src/test/java/org/apache/geode/redis/RedisDistDUnitTest.java eb877974e8f221142222e432d95c7dc4cfa944f2
> geode-core/src/test/java/org/apache/geode/security/ClientAuthenticationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/DeltaClientPostAuthorizationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedClientAuthDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedClientRegionClearAuthDistributedTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleDistributedTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/PDXPostProcessorDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqResultSetUsingPoolDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/internal/cache/PutAllCSDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/management/internal/cli/commands/DurableClientCommandsDUnitTest.java PRE-CREATION
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_1_DUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/PDXNewWanDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagationLoopBackDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagation_PartitionedRegionDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateGatewayReceiverDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandGatewayReceiverStartDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandGatewayReceiverStopDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandStatusDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/WANManagementDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/internal/pulse/TestRemoteClusterDUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 52468: Add FlakyTest category to tests with open
bugs
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52468/#review151189
-----------------------------------------------------------
Ship it!
I noticed you added additional ticket numbers to the same tests in a couple of places. Do we really need multiple tickets for the same test, or would it make sense to just close one of the tickets as a duplicate?
- Dan Smith
On Oct. 2, 2016, 12:07 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52468/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2016, 12:07 a.m.)
>
>
> Review request for geode.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Annotate test methods with FlakyTest category if there is an open
> bug for that test. This will improve the signal/noise ratio for
> unit/integration/distributed tests. Flaky tests are still run
> as part of precheckin and flakyTest targets.
>
>
> Diffs
> -----
>
> extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java PRE-CREATION
> geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java PRE-CREATION
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsOnGroupsFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsOffHeapDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/CompiledInDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/ConcurrentIndexOperationsOnOverflowRegionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryRegionCloseDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/DistributedSystemDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/SystemAdminDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/internal/ConsoleDistributionManagerDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionSingleHopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/FunctionServiceBase.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionFailoverDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionSelectorNoSingleHopDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRColocationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36805DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableRegistrationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/CompositeTypeTestDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/MemberMBeanAttributesDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/QueryDataDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/RegionCreateDestroyDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/UniversalMembershipListenerAdapterDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueueCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMetricsDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthorizationJUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/security/MultiUserDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/redis/HashesJUnitTest.java f219d810dede3a225eacbfda3fc7af80179fd289
> geode-core/src/test/java/org/apache/geode/redis/RedisDistDUnitTest.java eb877974e8f221142222e432d95c7dc4cfa944f2
> geode-core/src/test/java/org/apache/geode/security/ClientAuthenticationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/DeltaClientPostAuthorizationDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedClientAuthDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedClientRegionClearAuthDistributedTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleDistributedTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/security/PDXPostProcessorDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqResultSetUsingPoolDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/internal/cache/PutAllCSDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/management/internal/cli/commands/DurableClientCommandsDUnitTest.java PRE-CREATION
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_1_DUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/PDXNewWanDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagationLoopBackDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagation_PartitionedRegionDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateGatewayReceiverDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandGatewayReceiverStartDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandGatewayReceiverStopDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandStatusDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/WANManagementDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationDUnitTest.java PRE-CREATION
> geode-wan/src/test/java/org/apache/geode/management/internal/pulse/TestRemoteClusterDUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>