You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2010/05/26 09:30:57 UTC

svn commit: r948354 - /subversion/trunk/subversion/include/svn_wc.h

Author: stylesen
Date: Wed May 26 07:30:57 2010
New Revision: 948354

URL: http://svn.apache.org/viewvc?rev=948354&view=rev
Log:
* subversion/include/svn_wc.h
  (svn_wc_relocation_validator3_t, svn_wc_relocation_validator2_t,
   svn_wc_relocate4): Remove questioning comments and document the
   correct behavior. 

Modified:
    subversion/trunk/subversion/include/svn_wc.h

Modified: subversion/trunk/subversion/include/svn_wc.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_wc.h?rev=948354&r1=948353&r2=948354&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_wc.h (original)
+++ subversion/trunk/subversion/include/svn_wc.h Wed May 26 07:30:57 2010
@@ -6792,9 +6792,8 @@ svn_wc_upgrade(svn_wc_context_t *wc_ctx,
  * @a baton is a closure object; it should be provided by the
  * implementation, and passed by the caller.
  *
- * ### This func has a ROOT_URL arg, not a ROOT boolean.
- * If @a root is TRUE, then the implementation should make sure that @a url
- * is the repository root.  Else, it can be an URL inside the repository.
+ * If @a root_url is passed, then the implementation should make sure that
+ * @a url is the repository root.
  * @a pool may be used for temporary allocations.
  *
  * @since New in 1.5.
@@ -6805,10 +6804,11 @@ typedef svn_error_t *(*svn_wc_relocation
                                                        const char *root_url,
                                                        apr_pool_t *pool);
 
-/** Similar to #svn_wc_relocation_validator3_t, but without
- * the @a root_url arguments.
+/** Similar to #svn_wc_relocation_validator3_t, but with
+ * the @a root argument.
  *
- * ### What about the ROOT argument?
+ * If @a root is TRUE, then the implementation should make sure that @a url
+ * is the repository root.  Else, it can be an URL inside the repository.
  *
  * @deprecated Provided for backwards compatibility with the 1.4 API.
  */
@@ -6832,8 +6832,6 @@ typedef svn_error_t *(*svn_wc_relocation
  * The pre-change URL should be @a from, and the post-change URL will be
  * @a to.  @a validator (and its baton, @a validator_baton), will be called
  * for the newly generated base URL and calculated repo root.
- * ### Doc string of svn_wc_relocation_validator3_t says it's called for
- *     each file/directory. Is that so?
  *
  * If @a recurse is @c FALSE, none of the children of @a local_abspath will
  * be changed.  @a wc_ctx is an working copy context.



Re: svn commit: r948354 - /subversion/trunk/subversion/include/svn_wc.h

Posted by Greg Stein <gs...@gmail.com>.
On Wed, May 26, 2010 at 03:30,  <st...@apache.org> wrote:
>...
> +++ subversion/trunk/subversion/include/svn_wc.h Wed May 26 07:30:57 2010
>...
> @@ -6832,8 +6832,6 @@ typedef svn_error_t *(*svn_wc_relocation
>  * The pre-change URL should be @a from, and the post-change URL will be
>  * @a to.  @a validator (and its baton, @a validator_baton), will be called
>  * for the newly generated base URL and calculated repo root.
> - * ### Doc string of svn_wc_relocation_validator3_t says it's called for
> - *     each file/directory. Is that so?
>  *
>  * If @a recurse is @c FALSE, none of the children of @a local_abspath will
>  * be changed.  @a wc_ctx is an working copy context.

This last question was not addressed.

Cheers,
-g