You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org> on 2019/06/08 21:32:32 UTC
[kudu-CR] KUDU-2834: Build Kudu Kubernetes clustering using helm chart
Sandish Kumar HN has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13568
Change subject: KUDU-2834: Build Kudu Kubernetes clustering using helm chart
......................................................................
KUDU-2834: Build Kudu Kubernetes clustering using helm chart
Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
---
M docker/kudu-entrypoint.sh
A kubernetes/README.adoc
A kubernetes/helm/README.adoc
A kubernetes/helm/kudu-expose-all.yaml
A kubernetes/helm/kudu-rolebinding.yaml
A kubernetes/helm/kudu/Chart.yaml
A kubernetes/helm/kudu/templates/_helmutils.tpl
A kubernetes/helm/kudu/templates/kudu-service.yaml
A kubernetes/helm/kudu/values.yaml
A kubernetes/kudu-services.yaml
M kubernetes/kudu-statefulset.yaml
A kubernetes/namespace.yaml
12 files changed, 819 insertions(+), 58 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/13568/1
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 1
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13568
to look at the new patch set (#4).
Change subject: KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
......................................................................
KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Helm is a package manager for Kubernetes. Helps to define, install,
and upgrade Kubernetes applications.
Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
---
M docker/kudu-entrypoint.sh
A kubernetes/README.adoc
A kubernetes/helm/README.adoc
A kubernetes/helm/kudu-expose-all.yaml
A kubernetes/helm/kudu-rolebinding.yaml
A kubernetes/helm/kudu/Chart.yaml
A kubernetes/helm/kudu/templates/_helmutils.tpl
A kubernetes/helm/kudu/templates/kudu-service.yaml
A kubernetes/helm/kudu/values.yaml
A kubernetes/kudu-services.yaml
M kubernetes/kudu-statefulset.yaml
A kubernetes/namespace.yaml
12 files changed, 826 insertions(+), 58 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/13568/4
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 4
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/13568 )
Change subject: KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13568/7/kubernetes/helm/kudu/Chart.yaml
File kubernetes/helm/kudu/Chart.yaml:
http://gerrit.cloudera.org:8080/#/c/13568/7/kubernetes/helm/kudu/Chart.yaml@20
PS7, Line 20: description: Apache Kudu, A new addition to the open source Apache Hadoop ecosystem, Apache Kudu completes Hadoop's
> Lets drop this based on the fact that it can't be sourced from version.txt
Done
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 8
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 20:08:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13568
to look at the new patch set (#7).
Change subject: KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
......................................................................
KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Helm is a package manager for Kubernetes. Helps to define, install,
and upgrade Kubernetes applications.
Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
---
M docker/kudu-entrypoint.sh
A kubernetes/README.adoc
A kubernetes/helm/README.adoc
A kubernetes/helm/kudu-expose-all.yaml
A kubernetes/helm/kudu-rolebinding.yaml
A kubernetes/helm/kudu/Chart.yaml
A kubernetes/helm/kudu/templates/_helmutils.tpl
A kubernetes/helm/kudu/templates/kudu-service.yaml
A kubernetes/helm/kudu/templates/tests/health-test.yaml
A kubernetes/helm/kudu/values.yaml
A kubernetes/kudu-services.yaml
M kubernetes/kudu-statefulset.yaml
A kubernetes/namespace.yaml
13 files changed, 870 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/13568/7
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 7
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] KUDU-2834: Build Kudu Kubernetes clustering using helm chart
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13568
to look at the new patch set (#2).
Change subject: KUDU-2834: Build Kudu Kubernetes clustering using helm chart
......................................................................
KUDU-2834: Build Kudu Kubernetes clustering using helm chart
Helm is a package manager for Kubernetes. Helps to define, install,
and upgrade Kubernetes applications.
Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
---
M docker/kudu-entrypoint.sh
A kubernetes/README.adoc
A kubernetes/helm/README.adoc
A kubernetes/helm/kudu-expose-all.yaml
A kubernetes/helm/kudu-rolebinding.yaml
A kubernetes/helm/kudu/Chart.yaml
A kubernetes/helm/kudu/templates/_helmutils.tpl
A kubernetes/helm/kudu/templates/kudu-service.yaml
A kubernetes/helm/kudu/values.yaml
A kubernetes/kudu-services.yaml
M kubernetes/kudu-statefulset.yaml
A kubernetes/namespace.yaml
12 files changed, 819 insertions(+), 58 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/13568/2
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 2
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13568 )
Change subject: KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13568/7/kubernetes/helm/kudu/Chart.yaml
File kubernetes/helm/kudu/Chart.yaml:
http://gerrit.cloudera.org:8080/#/c/13568/7/kubernetes/helm/kudu/Chart.yaml@20
PS7, Line 20: appVersion: "1.10.0-SNAPSHOT"
Lets drop this based on the fact that it can't be sourced from version.txt and it's optional. This aligns with some best practices guidelines: https://codefresh.io/docs/docs/new-helm/helm-best-practices/
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 7
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 20:00:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13568 )
Change subject: KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
......................................................................
Patch Set 4:
(10 comments)
Thanks for the contribution! I have a few comments based on initial review and will do more review later.
Is there some way we can ensure this works as it changes and evolves? Some sort of unit/integration testing that can be run?
http://gerrit.cloudera.org:8080/#/c/13568/4/docker/kudu-entrypoint.sh
File docker/kudu-entrypoint.sh:
http://gerrit.cloudera.org:8080/#/c/13568/4/docker/kudu-entrypoint.sh@80
PS4, Line 80: sleep 2;
Curious about this change. Was 1 second not enough in some cases? Are we sure 2 is enough? Maybe there is a better way to do this.
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/README.adoc
File kubernetes/README.adoc:
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/README.adoc@67
PS4, Line 67:
nit: white space
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/helm/README.adoc
File kubernetes/helm/README.adoc:
PS4:
Does this readme need to be separate? Could it be merged with the readme one level up and describe when to use helm vs kubectl?
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/helm/kudu/Chart.yaml
File kubernetes/helm/kudu/Chart.yaml:
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/helm/kudu/Chart.yaml@20
PS4, Line 20: appVersion: "1.0"
Should this match the Kudu version? Can it be sourced from version.txt?
I am referencing this: https://helm.sh/docs/developing_charts/#the-chart-yaml-file
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/helm/kudu/Chart.yaml@21
PS4, Line 21: description: Official Kudu Helm Chart
Should this be a description of Kudu, not the "chart"?
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/helm/kudu/Chart.yaml@23
PS4, Line 23: version: latest
How should this version be set going forward?
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/helm/kudu/Chart.yaml@25
PS4, Line 25: home: https://kudu.apache.org/
Can you also add the `sources` field?
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/kudu-services.yaml
File kubernetes/kudu-services.yaml:
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/kudu-services.yaml@18
PS4, Line 18: # More about kubernetes statefulset https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/
Should these docs live in the readme?
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/kudu-services.yaml@29
PS4, Line 29: kind: Service
Can you add a comment about this service similar to the others below?
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/kudu-statefulset.yaml
File kubernetes/kudu-statefulset.yaml:
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/kudu-statefulset.yaml@20
PS4, Line 20: # create services for kudu kubernetes statefulset cluster : kubectl create -f kudu-services.yaml
Should these docs live in the readme now?
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 4
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Jun 2019 13:43:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13568
to look at the new patch set (#5).
Change subject: KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
......................................................................
KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Helm is a package manager for Kubernetes. Helps to define, install,
and upgrade Kubernetes applications.
Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
---
M docker/kudu-entrypoint.sh
A kubernetes/README.adoc
A kubernetes/helm/README.adoc
A kubernetes/helm/kudu-expose-all.yaml
A kubernetes/helm/kudu-rolebinding.yaml
A kubernetes/helm/kudu/Chart.yaml
A kubernetes/helm/kudu/templates/_helmutils.tpl
A kubernetes/helm/kudu/templates/kudu-service.yaml
A kubernetes/helm/kudu/values.yaml
A kubernetes/kudu-services.yaml
M kubernetes/kudu-statefulset.yaml
A kubernetes/namespace.yaml
12 files changed, 817 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/13568/5
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 5
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/13568 )
Change subject: KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
......................................................................
Patch Set 7:
Created health-test.yaml, which will initialize a pod and runs
'kudu cluster ksck' command, if it sees any error throws a test failure error.
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 7
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Jun 2019 20:15:29 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13568 )
Change subject: KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
......................................................................
KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Helm is a package manager for Kubernetes. Helps to define, install,
and upgrade Kubernetes applications.
Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Reviewed-on: http://gerrit.cloudera.org:8080/13568
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M docker/kudu-entrypoint.sh
A kubernetes/README.adoc
A kubernetes/helm/README.adoc
A kubernetes/helm/kudu-expose-all.yaml
A kubernetes/helm/kudu-rolebinding.yaml
A kubernetes/helm/kudu/Chart.yaml
A kubernetes/helm/kudu/templates/_helmutils.tpl
A kubernetes/helm/kudu/templates/kudu-service.yaml
A kubernetes/helm/kudu/templates/tests/health-test.yaml
A kubernetes/helm/kudu/values.yaml
A kubernetes/kudu-services.yaml
M kubernetes/kudu-statefulset.yaml
A kubernetes/namespace.yaml
13 files changed, 869 insertions(+), 63 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 9
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13568 )
Change subject: KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
......................................................................
Patch Set 8: Verified+1 Code-Review+2
LGTM. This is a great start and we can iterate on it given it's marked as experimental. Thank you for the contribution!
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 8
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 20:29:45 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13568
to look at the new patch set (#6).
Change subject: KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
......................................................................
KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Helm is a package manager for Kubernetes. Helps to define, install,
and upgrade Kubernetes applications.
Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
---
M docker/kudu-entrypoint.sh
A kubernetes/README.adoc
A kubernetes/helm/README.adoc
A kubernetes/helm/kudu-expose-all.yaml
A kubernetes/helm/kudu-rolebinding.yaml
A kubernetes/helm/kudu/Chart.yaml
A kubernetes/helm/kudu/templates/_helmutils.tpl
A kubernetes/helm/kudu/templates/kudu-service.yaml
A kubernetes/helm/kudu/values.yaml
A kubernetes/kudu-services.yaml
M kubernetes/kudu-statefulset.yaml
A kubernetes/namespace.yaml
12 files changed, 817 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/13568/6
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 6
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13568
to look at the new patch set (#3).
Change subject: KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
......................................................................
KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Helm is a package manager for Kubernetes. Helps to define, install,
and upgrade Kubernetes applications.
Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
---
M docker/kudu-entrypoint.sh
A kubernetes/README.adoc
A kubernetes/helm/README.adoc
A kubernetes/helm/kudu-expose-all.yaml
A kubernetes/helm/kudu-rolebinding.yaml
A kubernetes/helm/kudu/Chart.yaml
A kubernetes/helm/kudu/templates/_helmutils.tpl
A kubernetes/helm/kudu/templates/kudu-service.yaml
A kubernetes/helm/kudu/values.yaml
A kubernetes/kudu-services.yaml
M kubernetes/kudu-statefulset.yaml
A kubernetes/namespace.yaml
12 files changed, 819 insertions(+), 58 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/13568/3
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 3
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13568
to look at the new patch set (#8).
Change subject: KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
......................................................................
KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Helm is a package manager for Kubernetes. Helps to define, install,
and upgrade Kubernetes applications.
Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
---
M docker/kudu-entrypoint.sh
A kubernetes/README.adoc
A kubernetes/helm/README.adoc
A kubernetes/helm/kudu-expose-all.yaml
A kubernetes/helm/kudu-rolebinding.yaml
A kubernetes/helm/kudu/Chart.yaml
A kubernetes/helm/kudu/templates/_helmutils.tpl
A kubernetes/helm/kudu/templates/kudu-service.yaml
A kubernetes/helm/kudu/templates/tests/health-test.yaml
A kubernetes/helm/kudu/values.yaml
A kubernetes/kudu-services.yaml
M kubernetes/kudu-statefulset.yaml
A kubernetes/namespace.yaml
13 files changed, 869 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/13568/8
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 8
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/13568 )
Change subject: KUDU-2834: Build Kudu Kubernetes cluster using Helm chart
......................................................................
Patch Set 4:
(3 comments)
I'm thinking of adding more unit and integration testing for helm chart in new commit, but all resource's regarding testing point to Go-Lang. do we have any best practice for Go Lang?
http://gerrit.cloudera.org:8080/#/c/13568/4/docker/kudu-entrypoint.sh
File docker/kudu-entrypoint.sh:
http://gerrit.cloudera.org:8080/#/c/13568/4/docker/kudu-entrypoint.sh@80
PS4, Line 80: sleep 2;
> Curious about this change. Was 1 second not enough in some cases? Are we su
we using podManagementPolicy: "Parallel" which should take care of launching all pods at the same time, but for more than 5 kudu masters, I saw a second delay by then kudu throws an error with "host not reachable" 2 seconds worked for 20 kudu masters pods
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/helm/README.adoc
File kubernetes/helm/README.adoc:
PS4:
> Does this readme need to be separate? Could it be merged with the readme o
I felt it's good to have a sperate readme file's, one readme with all the steps would confuse viewers. as we can keep adding more related to the helm in its readme file, like testing, upgrade scenarios, etc..
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/helm/kudu/Chart.yaml
File kubernetes/helm/kudu/Chart.yaml:
http://gerrit.cloudera.org:8080/#/c/13568/4/kubernetes/helm/kudu/Chart.yaml@23
PS4, Line 23: version: latest
> How should this version be set going forward?
I think we should use "latest" always
--
To view, visit http://gerrit.cloudera.org:8080/13568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f839b690322fc349a566ee643d39f039f72ffa6
Gerrit-Change-Number: 13568
Gerrit-PatchSet: 4
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Jun 2019 17:37:40 +0000
Gerrit-HasComments: Yes