You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/24 20:07:37 UTC
[GitHub] [airflow] pankajastro opened a new pull request, #27236: Typecast biquery job response col value
pankajastro opened a new pull request, #27236:
URL: https://github.com/apache/airflow/pull/27236
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pankajastro commented on pull request #27236: Typecast biquery job response col value
Posted by GitBox <gi...@apache.org>.
pankajastro commented on PR #27236:
URL: https://github.com/apache/airflow/pull/27236#issuecomment-1292162781
> Can you add unit test to avoid regression?
>
> BTW you can open PRs directly. No need to submit issue first
Added tests, please let me know how it's looking now.
While creating the issue by mistake I selected the area `core` can you please update the correct label remove `core` and add `provider` and `google`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #27236: Typecast biquery job response col value
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27236:
URL: https://github.com/apache/airflow/pull/27236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #27236: Typecast biquery job response col value
Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #27236:
URL: https://github.com/apache/airflow/pull/27236#issuecomment-1289597019
Can we add unit test for this to avoid regression?
BTW you can open PRs directly. No need to submit issue first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org