You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/03/18 05:17:11 UTC

[kudu-CR] [security] enhance tls handshake test

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17198


Change subject: [security] enhance tls_handshake test
......................................................................

[security] enhance tls_handshake test

This patch adds extra verification step into the TestHandshakeSequence
scenario of TestTlsHandshake.  That's to assert that both parties can
send and receive application data using OpenSSL API (i.e. SSL_Read() and
SSL_Write() function) once TlsHandshake::Continue() returns Status::OK.
In addition, the newly introduced utility methods in TestTlsHandshake
are useful for a follow-up changelist as well.

In addition, I cleaned up code in {client,server}_negotiation.cc
and in tls_context.cc.

Change-Id: Ie77d1f35e12fe74be9f4022e8cd7087500052743
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/tls_context.cc
M src/kudu/security/tls_handshake-test.cc
M src/kudu/security/tls_handshake.h
5 files changed, 98 insertions(+), 20 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/17198/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie77d1f35e12fe74be9f4022e8cd7087500052743
Gerrit-Change-Number: 17198
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [security] enhance tls handshake test

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17198 )

Change subject: [security] enhance tls_handshake test
......................................................................

[security] enhance tls_handshake test

This patch adds extra verification step into the TestHandshakeSequence
scenario of TestTlsHandshake.  That's to assert that both parties can
send and receive application data using OpenSSL API (i.e. SSL_Read() and
SSL_Write() function) once TlsHandshake::Continue() returns Status::OK.
In addition, the newly introduced utility methods in TestTlsHandshake
are useful for a follow-up changelist as well.

In addition, I cleaned up code in {client,server}_negotiation.cc
and in tls_context.cc.

Change-Id: Ie77d1f35e12fe74be9f4022e8cd7087500052743
Reviewed-on: http://gerrit.cloudera.org:8080/17198
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/tls_context.cc
M src/kudu/security/tls_handshake-test.cc
M src/kudu/security/tls_handshake.h
5 files changed, 98 insertions(+), 20 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, but someone else must approve
  Attila Bukor: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie77d1f35e12fe74be9f4022e8cd7087500052743
Gerrit-Change-Number: 17198
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [security] enhance tls handshake test

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17198 )

Change subject: [security] enhance tls_handshake test
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie77d1f35e12fe74be9f4022e8cd7087500052743
Gerrit-Change-Number: 17198
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 18 Mar 2021 16:01:28 +0000
Gerrit-HasComments: No

[kudu-CR] [security] enhance tls handshake test

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17198 )

Change subject: [security] enhance tls_handshake test
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie77d1f35e12fe74be9f4022e8cd7087500052743
Gerrit-Change-Number: 17198
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 18 Mar 2021 13:58:35 +0000
Gerrit-HasComments: No