You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by "EricJoy2048 (via GitHub)" <gi...@apache.org> on 2023/12/11 06:59:12 UTC

Re: [PR] [Feature] [File Connector] Make File Source Connector support row delimiter. [seatunnel]

EricJoy2048 commented on PR #5873:
URL: https://github.com/apache/seatunnel/pull/5873#issuecomment-1849434037

   > > > It seems you misunderstand issue #5841, the issue is aim to avoid use default `\n`, rather than use `\n` with `rowDelimiter`.
   > > 
   > > 
   > > My understanding of the issue is that you can customize the line separator and split it into new lines based on the separator. This PR fulfills this requirement. @EricJoy2048 Is this the need?
   > 
   > The line separator should used to split the whole file into lines, rather than split one line into lines.
   
   Yes, So, I thinks `reader.lines()` is can not use here if we can specify the line delimiter for the file. Because `reader.lines()` only can use when the row delimiter is `\n\r`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org