You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/05/20 05:18:25 UTC
[GitHub] [openwhisk-package-alarms] ningyougang opened a new pull request #215: Fix strict default value to false
ningyougang opened a new pull request #215:
URL: https://github.com/apache/openwhisk-package-alarms/pull/215
- [x] Fix strict's default value to `false`
After created trigger with sepcify `strick: true or false`, then, used `wsk trigger get ${triggerName}`, can get the strick correctly, and i also created relative rules, actions, after checked, the strick feature worked well, included
- strick: true, the trigger's executed time is not floating ()
- strick: false, the trigger's executed time has floating. (e.g. + [0, delayLimit] second)
But when created trigger without sepcify `strick: true or false`, then used `wsk trigger get ${trigger}`, from result, the strick value is `true`, but i created relative rule, action as well, found that, the trigger's execute time has floating, so the default value should be changed to `false`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-package-alarms] style95 commented on a change in pull request #215: Fix strict default value to false
Posted by GitBox <gi...@apache.org>.
style95 commented on a change in pull request #215:
URL: https://github.com/apache/openwhisk-package-alarms/pull/215#discussion_r427756477
##########
File path: action/alarmWebAction.js
##########
@@ -191,7 +191,7 @@ function main(params) {
reason: doc.status.reason
}
};
- var strict = true; // strict is default to true
+ var strict = false; // strict is default to false
Review comment:
I suppose this should be the default value from the deployment configuration rather than just one of true or false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-package-alarms] ningyougang commented on a change in pull request #215: Fix strict default value to false
Posted by GitBox <gi...@apache.org>.
ningyougang commented on a change in pull request #215:
URL: https://github.com/apache/openwhisk-package-alarms/pull/215#discussion_r427876496
##########
File path: action/alarmWebAction.js
##########
@@ -191,7 +191,7 @@ function main(params) {
reason: doc.status.reason
}
};
- var strict = true; // strict is default to true
+ var strict = false; // strict is default to false
Review comment:
Yes, you are right.
So i opened another pr: https://github.com/apache/openwhisk-package-alarms/pull/216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-package-alarms] ningyougang closed pull request #215: Fix strict default value to false
Posted by GitBox <gi...@apache.org>.
ningyougang closed pull request #215:
URL: https://github.com/apache/openwhisk-package-alarms/pull/215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org