[GitHub] kuriancheeramelil opened a new issue #4915: Exploring BQ table throws query error as date is incorrectly formatted

[GitBox <gi...@apache.org>]

kuriancheeramelil opened a new issue #4915: Exploring BQ table throws query error as date is incorrectly formatted
URL: https://github.com/apache/incubator-superset/issues/4915
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [X] I have checked the superset logs for python stacktraces and included it here as text if any
   - [X] I have reproduced the issue with at least the latest released version of superset
   - [X] I have checked the issue tracker for the same issue and I haven't found one similar
   
   
   ### Superset version
   0.25
   
   ### Expected results
   Executing BQ table query via table explore page executes query with date field correctly.
   
   ### Actual results
   the query generated throws syntax error
   
   ### Steps to reproduce
   Add BQ table with date in superset and explore table. Any metric throws syntax error.
   
   The issue seems to be with this line 
   https://github.com/apache/incubator-superset/blob/e1d2150391ba827a64cebd0c0573aab0a82a3634/superset/db_engine_specs.py#L1263
   Instead of
               return "'{}'".format(dttm.strftime('%Y-%m-%d'))
   it is missing the starting single quote
               return "{}'".format(dttm.strftime('%Y-%m-%d'))
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services