You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/06/13 19:33:20 UTC

[GitHub] [tvm] Lunderberg commented on pull request #14778: [TIR] Require buffer declaration (DeclBuffer) before use

Lunderberg commented on PR #14778:
URL: https://github.com/apache/tvm/pull/14778#issuecomment-1589904330

   The strategy in breaking up this PR has been to separate the changes into two types: (1) changes that allow a pass to handle `DeclBuffer` in its input, and (2) changes that cause a pass to produce a `DeclBuffer`.  So far, the independent PRs have all been of type (1), as those do not change the behavior when `DeclBuffer` is absent.  Once the latest batch of PRs have merged in (#15037, #15044, #15045, #15093, #15094, #15096, and #15098), all passes that need to be aware of `DeclBuffer` should be updated.
   
   Once those PRs have been merged into main, the next stage will be to break out the changes of type (2), starting at the end of the lowering flow and working upstream.  That way, the `DeclBuffer` node is only introduced to a few additional passes with each PR, hopefully making any failures easier to debug.
   
   Finally, this PR will be left with just the `VerifyWellFormed` changes, and will serve to validate the additional restrictions on the TIR, while not changing any other behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org