You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/05/24 06:56:04 UTC

[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #605: unittests: fix leaks reported by ASan

PragmaTwice opened a new pull request, #605:
URL: https://github.com/apache/incubator-kvrocks/pull/605

   use `std::unique_ptr` to avoid missing delete and dtor call


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tisonkun merged pull request #605: unittests: fix leaks reported by ASan

Posted by GitBox <gi...@apache.org>.

tisonkun merged PR #605:
URL: https://github.com/apache/incubator-kvrocks/pull/605


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #605: unittests: fix leaks reported by ASan

Posted by GitBox <gi...@apache.org>.

PragmaTwice commented on PR #605:
URL: https://github.com/apache/incubator-kvrocks/pull/605#issuecomment-1135505943

   [kvrocks-unittest-asan.log](https://github.com/apache/incubator-kvrocks/files/8760302/kvrocks-unittest-asan.log)
   [kvrocks-unittest-asan-after.log](https://github.com/apache/incubator-kvrocks/files/8760306/kvrocks-unittest-asan-after.log)
   
   Seems just some error due to my poor network. Done @tisonkun.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on pull request #605: unittests: fix leaks reported by ASan

Posted by GitBox <gi...@apache.org>.

git-hulk commented on PR #605:
URL: https://github.com/apache/incubator-kvrocks/pull/605#issuecomment-1135528308

   Yes, I can reproduce the memory leak on my side, but didn't investigate root causes now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #605: unittests: fix leaks reported by ASan

Posted by GitBox <gi...@apache.org>.

PragmaTwice commented on PR #605:
URL: https://github.com/apache/incubator-kvrocks/pull/605#issuecomment-1135522876

   > @PragmaTwice looks great! It seems that this PR fixes all leaks currently reported. We should fail if there are new leaks in #599.
   
   Seems there are also some leaks in TCL tests, I do not know the current status, maybe @git-hulk know that.
   In #599, ASan is enabled in `daily-ci.yaml`, dont know whether it should be added to `kvrocks.yaml`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #605: unittests: fix leaks reported by ASan

Posted by GitBox <gi...@apache.org>.

PragmaTwice commented on PR #605:
URL: https://github.com/apache/incubator-kvrocks/pull/605#issuecomment-1135501435

   > @PragmaTwice could you share the ASan report before and after this change?
   
   The ASan report before this is about 6MiB, I will soon find a way to upload.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tisonkun commented on pull request #605: unittests: fix leaks reported by ASan

Posted by GitBox <gi...@apache.org>.

tisonkun commented on PR #605:
URL: https://github.com/apache/incubator-kvrocks/pull/605#issuecomment-1135517194

   @PragmaTwice looks great! It seems that this PR fixes all leaks currently reported. We should fail if there are new leaks in #599.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tisonkun commented on pull request #605: unittests: fix leaks reported by ASan

Posted by GitBox <gi...@apache.org>.

tisonkun commented on PR #605:
URL: https://github.com/apache/incubator-kvrocks/pull/605#issuecomment-1135534824

   I'm going to merge this PR.
   
   Further discussion about #599 can go to that thread. If you'd like to investigate leak issues, it'd be better to create another issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org