[jira] [Resolved] (OAK-5296) MutableRoot.refresh does not correctly refresh tree permissions

["Michael Dürig (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig resolved OAK-5296.
--------------------------------
    Resolution: Not A Problem

Resolving as not a problem. See the analysis in my previous comment. 

See also OAK-5355 for a follow up issue to improve this. 

> MutableRoot.refresh does not correctly refresh tree permissions
> ---------------------------------------------------------------
>
>                 Key: OAK-5296
>                 URL: https://issues.apache.org/jira/browse/OAK-5296
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>            Priority: Blocker
>             Fix For: 1.6
>
>
> Consider the following excerpt of a stack trace:
> {noformat}
> at org.apache.jackrabbit.oak.security.authorization.permission.PermissionProviderImpl.getCompiledPermissions(PermissionProviderImpl.java:162)
> at org.apache.jackrabbit.oak.security.authorization.permission.PermissionProviderImpl.getTreePermission(PermissionProviderImpl.java:104)
> at org.apache.jackrabbit.oak.core.SecureNodeBuilder.getTreePermission(SecureNodeBuilder.java:356)
> at org.apache.jackrabbit.oak.core.SecureNodeBuilder.baseChanged(SecureNodeBuilder.java:166)
> at org.apache.jackrabbit.oak.core.MutableRoot.refresh(MutableRoot.java:236)
> {noformat}
> {{MutableRoot.refresh()}} [ends up calling | https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/MutableRoot.java#L236] {{PermissionProviderImpl.getCompiledPermissions}}, which in turn uses the current (not yet fully refreshed) root for compiling the permissions. The permissions provider (and its root) are [refreshed|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/MutableRoot.java#L239] only afterwards. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)