You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/04/07 03:47:53 UTC
[GitHub] [incubator-inlong] shink opened a new pull request, #3562: [INLONG-3560][TubeMQ] Fix invalid port names in tubemq pods
shink opened a new pull request, #3562:
URL: https://github.com/apache/incubator-inlong/pull/3562
Fixes: #3560
### Motivation
Fix invalid port names in tubemq pods.
**The port name should be no more than 15 characters.**
### Modifications
Shorten pod names.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on a diff in pull request #3562: [INLONG-3560][TubeMQ] Fix invalid port names in tubemq pods
Posted by GitBox <gi...@apache.org>.
shink commented on code in PR #3562:
URL: https://github.com/apache/incubator-inlong/pull/3562#discussion_r844667803
##########
docker/kubernetes/templates/tubemq-master-service.yaml:
##########
@@ -28,15 +28,15 @@ metadata:
spec:
type: {{ .Values.tubemqMaster.service.type }}
ports:
- - name: {{ .Values.tubemqMaster.component }}-web-port
+ - name: mstr-web-port
protocol: TCP
port: {{ .Values.tubemqMaster.ports.webPort }}
targetPort: 8080
- - name: {{ .Values.tubemqMaster.component }}-help-port
+ - name: mstr-help-port
protocol: TCP
port: {{ .Values.tubemqMaster.ports.helpPort }}
targetPort: 9001
- - name: {{ .Values.tubemqMaster.component }}-rpc-port
+ - name: mstr-rpc-port
Review Comment:
The `master` is abbreviated as `mstr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on a diff in pull request #3562: [INLONG-3560][TubeMQ] Fix invalid port names in tubemq pods
Posted by GitBox <gi...@apache.org>.
shink commented on code in PR #3562:
URL: https://github.com/apache/incubator-inlong/pull/3562#discussion_r844667119
##########
docker/kubernetes/templates/tubemq-manager-service.yaml:
##########
@@ -26,7 +26,7 @@ metadata:
spec:
type: ClusterIP
ports:
- - name: {{ .Values.tubemqManager.component }}-port
+ - name: tubemq-mgr-port
protocol: TCP
port: {{ .Values.tubemqManager.port }}
targetPort: 8089
Review Comment:
The `manager` is abbreviated as `mgr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #3562: [INLONG-3560][TubeMQ] Fix invalid port names in tubemq pods
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #3562:
URL: https://github.com/apache/incubator-inlong/pull/3562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org