You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bigtop.apache.org by "Jun He (JIRA)" <ji...@apache.org> on 2018/03/30 04:40:00 UTC
[jira] [Commented] (BIGTOP-3018) detect-javahome script has a typo
in variable name
[ https://issues.apache.org/jira/browse/BIGTOP-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420145#comment-16420145 ]
Jun He commented on BIGTOP-3018:
--------------------------------
Hi, Heting,
That's a good catch. Sure, you may create PR or just put patch here, either way is OK.
> detect-javahome script has a typo in variable name
> --------------------------------------------------
>
> Key: BIGTOP-3018
> URL: https://issues.apache.org/jira/browse/BIGTOP-3018
> Project: Bigtop
> Issue Type: Bug
> Components: Init scripts
> Affects Versions: 1.3.0
> Reporter: Heting Zhang
> Priority: Minor
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> detect-javahome script : bigtop-packages/src/common/bigtop-utils/bigtop-detect-javahome
>
> In line 56 and line 60, $OPENJAVA8_HOME_CANDIDATES can only be empty because there was a typo in defining variable $OPENJAVA8_HOME__CANDIDATES in line 34. There are two _ between "HOME" and "CANDIDATES" in line 34. But There is only one _ between "HOME" and "CANDIDATES" when using the variable in line 56 and line 60. For other variable using one _ as the separator instead of two _ , I suggest changing variable $OPENJAVA8_HOME__CANDIDATES(with two _ between "HOME" and "CANDIDATES") in line 34 to $OPENJAVA8_HOME_CANDIDATES(with only one _ between "HOME" and "CANDIDATES")
>
> Can I create a pull request?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)