[GitHub] [iceberg] marton-bod commented on pull request #2367: Core: Don't delete data files on DROP if GC is disabled

[GitBox <gi...@apache.org>]

marton-bod commented on pull request #2367:
URL: https://github.com/apache/iceberg/pull/2367#issuecomment-805770620


   From a Hive user perspective, I would expect my data files to be dropped purely on the basis of whether `external.table.purge=TRUE` is set, and not be silently overridden by the Iceberg-specific `gc.enabled` property. So there might be surprises for Hive users if `purge=TRUE` but `gc.enabled=false` and therefore the data files end up not actually removed.
   
   I'm wondering if we should keep the two props in sync somehow via the `HiveTableOperations`, or at least provide better documentation on the possible Hive DROP TABLE behaviours?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org