You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/02/16 08:58:48 UTC
[GitHub] [incubator-echarts] alex2wong opened a new pull request #12156: fix
11799 add new option 'nameProperty' in map series option
alex2wong opened a new pull request #12156: fix 11799 add new option 'nameProperty' in map series option
URL: https://github.com/apache/incubator-echarts/pull/12156
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
add new option 'nameProperty' in map series option to denote key in geoJSON data
### Fixed issues
<!--
- #xxxx: ...
-->
bug https://github.com/apache/incubator-echarts/issues/11799
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
In original version, geojson properties must have a property: "name". Now you can customize it.
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
add a new option in map series
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Usage
### Are there any API changes?
- [x] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
```
{
name: 'USA PopEstimates',
type: 'map',
map: 'USA',
nameProperty: 'NAME', // new option to denote key in geoJSON, default is 'name',
data: []
}
```
### Related test cases or examples to use the new APIs
test/map-nameProperty.html
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on issue #12156: fix 11799
add new option 'nameProperty' in map series option
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #12156: fix 11799 add new option 'nameProperty' in map series option
URL: https://github.com/apache/incubator-echarts/pull/12156#issuecomment-586683491
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12156: fix
11799 add new option 'nameProperty' in map series option
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12156: fix 11799 add new option 'nameProperty' in map series option
URL: https://github.com/apache/incubator-echarts/pull/12156#issuecomment-586683223
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #12156: fix 11799
add new option 'nameProperty' in map series option
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #12156: fix 11799 add new option 'nameProperty' in map series option
URL: https://github.com/apache/incubator-echarts/pull/12156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] alex2wong commented on issue #12156: fix 11799
add new option 'nameProperty' in map series option
Posted by GitBox <gi...@apache.org>.
alex2wong commented on issue #12156: fix 11799 add new option 'nameProperty' in map series option
URL: https://github.com/apache/incubator-echarts/pull/12156#issuecomment-597973177
revise doc https://github.com/apache/incubator-echarts-doc/pull/91, please take a look @pissang @Ovilia , thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12156: fix
11799 add new option 'nameProperty' in map series option
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12156: fix 11799 add new option 'nameProperty' in map series option
URL: https://github.com/apache/incubator-echarts/pull/12156#issuecomment-586683510
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org