You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/04/18 13:07:45 UTC

Review Request 58502: Removed containerizer flag logging to prevent leak of sensitive data.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58502/
-----------------------------------------------------------

Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.


Bugs: MESOS-7265
    https://issues.apache.org/jira/browse/MESOS-7265


Repository: mesos


Description
-------

See summary.

* backported for 1.0.x *


Diffs
-----

  src/launcher/posix/executor.cpp 1c423f07b2c1b22b4d8aded274cae1295fe02a9d 


Diff: https://reviews.apache.org/r/58502/diff/1/


Testing
-------

make check


Thanks,

Till Toenshoff


Re: Review Request 58502: Removed containerizer flag logging to prevent leak of sensitive data.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58502/#review172203
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On April 18, 2017, 3:50 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58502/
> -----------------------------------------------------------
> 
> (Updated April 18, 2017, 3:50 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.
> 
> 
> Bugs: MESOS-7265
>     https://issues.apache.org/jira/browse/MESOS-7265
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> * backported for 1.0.x *
> 
> 
> Diffs
> -----
> 
>   src/launcher/posix/executor.cpp 1c423f07b2c1b22b4d8aded274cae1295fe02a9d 
> 
> 
> Diff: https://reviews.apache.org/r/58502/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 58502: Removed containerizer flag logging to prevent leak of sensitive data.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58502/
-----------------------------------------------------------

(Updated April 18, 2017, 1:50 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.


Changes
-------

Moved log output to be inline with original commit.


Bugs: MESOS-7265
    https://issues.apache.org/jira/browse/MESOS-7265


Repository: mesos


Description (updated)
-------

See summary.

* backported for 1.0.x *


Diffs (updated)
-----

  src/launcher/posix/executor.cpp 1c423f07b2c1b22b4d8aded274cae1295fe02a9d 


Diff: https://reviews.apache.org/r/58502/diff/2/

Changes: https://reviews.apache.org/r/58502/diff/1-2/


Testing
-------

make check


Thanks,

Till Toenshoff


Re: Review Request 58502: Removed containerizer flag logging to prevent leak of sensitive data.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58502/
-----------------------------------------------------------

(Updated April 18, 2017, 1:10 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.


Bugs: MESOS-7265
    https://issues.apache.org/jira/browse/MESOS-7265


Repository: mesos


Description
-------

See summary.

* backported for 1.0.x *


Diffs
-----

  src/launcher/posix/executor.cpp 1c423f07b2c1b22b4d8aded274cae1295fe02a9d 


Diff: https://reviews.apache.org/r/58502/diff/1/


Testing
-------

make check


Thanks,

Till Toenshoff