You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Ian Cook (Jira)" <ji...@apache.org> on 2021/09/03 00:21:00 UTC
[jira] [Resolved] (ARROW-13768) [R] Allow JSON to be an optional
component
[ https://issues.apache.org/jira/browse/ARROW-13768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Cook resolved ARROW-13768.
------------------------------
Fix Version/s: 6.0.0
Resolution: Fixed
Issue resolved by pull request 11046
[https://github.com/apache/arrow/pull/11046]
> [R] Allow JSON to be an optional component
> ------------------------------------------
>
> Key: ARROW-13768
> URL: https://issues.apache.org/jira/browse/ARROW-13768
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: R
> Affects Versions: 5.0.0
> Reporter: Karl Dunkle Werner
> Assignee: Karl Dunkle Werner
> Priority: Major
> Labels: pull-request-available
> Fix For: 6.0.0
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> JSON support requires RapidJSON, a third-party dependency that might not always be available. Particularly for offline static builds (ARROW-12981), it would be nice to allow {{ARROW_JSON=OFF}}.
> Here's the [relevant section|https://github.com/apache/arrow/blob/64bef2ad8d9cd2fea122cfa079f8ca3fea8cdf5d/cpp/cmake_modules/ThirdpartyToolchain.cmake#L290-L292] of {{ThirdpartyToolchain.cmake}}:
> {code:none}
> if(ARROW_JSON)
> set(ARROW_WITH_RAPIDJSON ON)
> endif()
> {code}
> And the [relevant section|https://github.com/apache/arrow/blob/64bef2ad8d9cd2fea122cfa079f8ca3fea8cdf5d/r/inst/build_arrow_static.sh#L62] of the {{build_arrow_static.sh}} script.
> As Neal [mentioned|https://github.com/apache/arrow/pull/11001#discussion_r696723923], there's more to do than just replacing {{-DARROW_JSON=ON}} with {{-DARROW_JSON=$\{ARROW_JSON:-ON}}}. "We'll have to conditionally build some of the bindings like we do with dataset and parquet, and we'll have to conditionally skip tests."
--
This message was sent by Atlassian Jira
(v8.3.4#803005)