You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Stanton Sievers <si...@gmail.com> on 2012/06/26 00:07:34 UTC
Review Request: X-Shindig-St behaves differently when the security token is
null between Firefox and WebKit browsers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5568/
-----------------------------------------------------------
Review request for shindig, Brian Lillie and Doug Davies.
Description
-------
If we set the X-Shindig-ST header to null in WebKit browsers, it will get interpreted as the String "null" on the server side and cause SecurityTokenExceptions.
This addresses bug SHINDIG-1812.
https://issues.apache.org/jira/browse/SHINDIG-1812
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1352560
Diff: https://reviews.apache.org/r/5568/diff/
Testing
-------
Existing JUnits pass.
Thanks,
Stanton Sievers
Re: Review Request: X-Shindig-St behaves differently when the security token
is null between Firefox and WebKit browsers
Posted by Brian Lillie <br...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5568/#review8572
-----------------------------------------------------------
LGTM
- Brian Lillie
On June 25, 2012, 10:07 p.m., Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5568/
> -----------------------------------------------------------
>
> (Updated June 25, 2012, 10:07 p.m.)
>
>
> Review request for shindig, Brian Lillie and Doug Davies.
>
>
> Description
> -------
>
> If we set the X-Shindig-ST header to null in WebKit browsers, it will get interpreted as the String "null" on the server side and cause SecurityTokenExceptions.
>
>
> This addresses bug SHINDIG-1812.
> https://issues.apache.org/jira/browse/SHINDIG-1812
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1352560
>
> Diff: https://reviews.apache.org/r/5568/diff/
>
>
> Testing
> -------
>
> Existing JUnits pass.
>
>
> Thanks,
>
> Stanton Sievers
>
>
Re: Review Request: X-Shindig-St behaves differently when the security token
is null between Firefox and WebKit browsers
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5568/#review8586
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On June 25, 2012, 10:07 p.m., Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5568/
> -----------------------------------------------------------
>
> (Updated June 25, 2012, 10:07 p.m.)
>
>
> Review request for shindig, Brian Lillie and Doug Davies.
>
>
> Description
> -------
>
> If we set the X-Shindig-ST header to null in WebKit browsers, it will get interpreted as the String "null" on the server side and cause SecurityTokenExceptions.
>
>
> This addresses bug SHINDIG-1812.
> https://issues.apache.org/jira/browse/SHINDIG-1812
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1352560
>
> Diff: https://reviews.apache.org/r/5568/diff/
>
>
> Testing
> -------
>
> Existing JUnits pass.
>
>
> Thanks,
>
> Stanton Sievers
>
>
Re: Review Request: X-Shindig-St behaves differently when the security token
is null between Firefox and WebKit browsers
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5568/#review8608
-----------------------------------------------------------
Ship it!
Committed revision 1354132.
- Stanton Sievers
On June 25, 2012, 10:07 p.m., Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5568/
> -----------------------------------------------------------
>
> (Updated June 25, 2012, 10:07 p.m.)
>
>
> Review request for shindig, Brian Lillie and Doug Davies.
>
>
> Description
> -------
>
> If we set the X-Shindig-ST header to null in WebKit browsers, it will get interpreted as the String "null" on the server side and cause SecurityTokenExceptions.
>
>
> This addresses bug SHINDIG-1812.
> https://issues.apache.org/jira/browse/SHINDIG-1812
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1352560
>
> Diff: https://reviews.apache.org/r/5568/diff/
>
>
> Testing
> -------
>
> Existing JUnits pass.
>
>
> Thanks,
>
> Stanton Sievers
>
>
Re: Review Request: X-Shindig-St behaves differently when the security token
is null between Firefox and WebKit browsers
Posted by Doug Davies <da...@oclc.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5568/#review8603
-----------------------------------------------------------
Ship it!
Ship It!
- Doug Davies
On June 25, 2012, 10:07 p.m., Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5568/
> -----------------------------------------------------------
>
> (Updated June 25, 2012, 10:07 p.m.)
>
>
> Review request for shindig, Brian Lillie and Doug Davies.
>
>
> Description
> -------
>
> If we set the X-Shindig-ST header to null in WebKit browsers, it will get interpreted as the String "null" on the server side and cause SecurityTokenExceptions.
>
>
> This addresses bug SHINDIG-1812.
> https://issues.apache.org/jira/browse/SHINDIG-1812
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1352560
>
> Diff: https://reviews.apache.org/r/5568/diff/
>
>
> Testing
> -------
>
> Existing JUnits pass.
>
>
> Thanks,
>
> Stanton Sievers
>
>
Re: Review Request: X-Shindig-St behaves differently when the security token
is null between Firefox and WebKit browsers
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5568/#review8591
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Dumont
On June 25, 2012, 10:07 p.m., Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5568/
> -----------------------------------------------------------
>
> (Updated June 25, 2012, 10:07 p.m.)
>
>
> Review request for shindig, Brian Lillie and Doug Davies.
>
>
> Description
> -------
>
> If we set the X-Shindig-ST header to null in WebKit browsers, it will get interpreted as the String "null" on the server side and cause SecurityTokenExceptions.
>
>
> This addresses bug SHINDIG-1812.
> https://issues.apache.org/jira/browse/SHINDIG-1812
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1352560
>
> Diff: https://reviews.apache.org/r/5568/diff/
>
>
> Testing
> -------
>
> Existing JUnits pass.
>
>
> Thanks,
>
> Stanton Sievers
>
>