svn commit: r503976 - in /perl/modperl/trunk: Changes ModPerl-Registry/lib/ModPerl/RegistryCooker.pm

[st...@apache.org]

Author: stas
Date: Mon Feb  5 20:31:48 2007
New Revision: 503976

URL: http://svn.apache.org/viewvc?view=rev&rev=503976
Log:
fix ModPerl::RegistryCooker::read_script to handle all possible
errors, previously there was a case where Apache2::Const::OK was
returned on an error. 
Contributed by: Eivind Eklund <ee...@gmail.com>

Modified:
    perl/modperl/trunk/Changes
    perl/modperl/trunk/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm

Modified: perl/modperl/trunk/Changes
URL: http://svn.apache.org/viewvc/perl/modperl/trunk/Changes?view=diff&rev=503976&r1=503975&r2=503976
==============================================================================
--- perl/modperl/trunk/Changes (original)
+++ perl/modperl/trunk/Changes Mon Feb  5 20:31:48 2007
@@ -12,6 +12,13 @@
 
 =item 2.0.4-dev
 
+fix ModPerl::RegistryCooker::read_script to handle all possible
+errors, previously there was a case where Apache2::Const::OK was
+returned on an error.  [Eivind Eklund <ee...@gmail.com>]
+
+a minor compilation warning resolved in modperl_handler_new_from_sv
+[Stas]
+
 a minor compilation warning resolved in modperl_gtop_size_string
 [Stas]
 

Modified: perl/modperl/trunk/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm
URL: http://svn.apache.org/viewvc/perl/modperl/trunk/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm?view=diff&rev=503976&r1=503975&r2=503976
==============================================================================
--- perl/modperl/trunk/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm (original)
+++ perl/modperl/trunk/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm Mon Feb  5 20:31:48 2007
@@ -546,9 +546,8 @@
             return Apache2::Const::FORBIDDEN if APR::Status::is_EACCES($@);
             return Apache2::Const::NOT_FOUND if APR::Status::is_ENOENT($@);
         }
-        else {
-            return Apache2::Const::SERVER_ERROR;
-        }
+
+        return Apache2::Const::SERVER_ERROR;
     }
 
     return Apache2::Const::OK;