You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Henryk Konsek (JIRA)" <ji...@apache.org> on 2010/09/24 15:44:42 UTC
[jira] Created: (CAMEL-3154) [XStream] Custom Xstream driver
[XStream] Custom Xstream driver
-------------------------------
Key: CAMEL-3154
URL: https://issues.apache.org/activemq/browse/CAMEL-3154
Project: Apache Camel
Issue Type: Improvement
Reporter: Henryk Konsek
Priority: Trivial
Attachments: xstream_custom_driver.patch
AbstractXStreamWrapper#createXStream uses hardcoded default XStream constructor. Such design makes impossible to set custom HierarchicalStreamDriver to the XStream instance.
It would be nice to provide an ability to configure AbstractXStreamWrapper with optional HierarchicalStreamDriver instance.
I created patch which adds AbstractXStreamWrapper#xstreamDriver property (+test).
Patch also adds XML attribute 'driverRef' to Spring configuration (org.apache.camel.model.dataformat.XStreamDataFormat). However this new attribute of Spring DSL doesn't work because I got no idea how to wire existing Spring bean into the created dataFormat instance (since org.apache.camel.model.dataformat.XStreamDataFormat is Spring-unaware).
Could somebody take a look at it, fix Spring DSL support and probably commit it to the codebase?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-3154) [XStream] Custom Xstream driver
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-3154:
-----------------------------------
Assignee: Willem Jiang
> [XStream] Custom Xstream driver
> -------------------------------
>
> Key: CAMEL-3154
> URL: https://issues.apache.org/activemq/browse/CAMEL-3154
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: Henryk Konsek
> Assignee: Willem Jiang
> Priority: Trivial
> Attachments: xstream_custom_driver.patch
>
>
> AbstractXStreamWrapper#createXStream uses hardcoded default XStream constructor. Such design makes impossible to set custom HierarchicalStreamDriver to the XStream instance.
> It would be nice to provide an ability to configure AbstractXStreamWrapper with optional HierarchicalStreamDriver instance.
> I created patch which adds AbstractXStreamWrapper#xstreamDriver property (+test).
> Patch also adds XML attribute 'driverRef' to Spring configuration (org.apache.camel.model.dataformat.XStreamDataFormat). However this new attribute of Spring DSL doesn't work because I got no idea how to wire existing Spring bean into the created dataFormat instance (since org.apache.camel.model.dataformat.XStreamDataFormat is Spring-unaware).
> Could somebody take a look at it, fix Spring DSL support and probably commit it to the codebase?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3154) [XStream] Custom Xstream driver
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=62096#action_62096 ]
Willem Jiang commented on CAMEL-3154:
-------------------------------------
@Claus,
After adding the Spring configure test, I found the patch was not working for at all, I will did a quick fix for it.
> [XStream] Custom Xstream driver
> -------------------------------
>
> Key: CAMEL-3154
> URL: https://issues.apache.org/activemq/browse/CAMEL-3154
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: Henryk Konsek
> Assignee: Willem Jiang
> Priority: Trivial
> Fix For: 2.5.0
>
> Attachments: xstream_custom_driver.patch
>
>
> AbstractXStreamWrapper#createXStream uses hardcoded default XStream constructor. Such design makes impossible to set custom HierarchicalStreamDriver to the XStream instance.
> It would be nice to provide an ability to configure AbstractXStreamWrapper with optional HierarchicalStreamDriver instance.
> I created patch which adds AbstractXStreamWrapper#xstreamDriver property (+test).
> Patch also adds XML attribute 'driverRef' to Spring configuration (org.apache.camel.model.dataformat.XStreamDataFormat). However this new attribute of Spring DSL doesn't work because I got no idea how to wire existing Spring bean into the created dataFormat instance (since org.apache.camel.model.dataformat.XStreamDataFormat is Spring-unaware).
> Could somebody take a look at it, fix Spring DSL support and probably commit it to the codebase?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3154) [XStream] Custom Xstream driver
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=62097#action_62097 ]
Willem Jiang commented on CAMEL-3154:
-------------------------------------
Done, commit a patch into Revision: 1001177
> [XStream] Custom Xstream driver
> -------------------------------
>
> Key: CAMEL-3154
> URL: https://issues.apache.org/activemq/browse/CAMEL-3154
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: Henryk Konsek
> Assignee: Willem Jiang
> Priority: Trivial
> Fix For: 2.5.0
>
> Attachments: xstream_custom_driver.patch
>
>
> AbstractXStreamWrapper#createXStream uses hardcoded default XStream constructor. Such design makes impossible to set custom HierarchicalStreamDriver to the XStream instance.
> It would be nice to provide an ability to configure AbstractXStreamWrapper with optional HierarchicalStreamDriver instance.
> I created patch which adds AbstractXStreamWrapper#xstreamDriver property (+test).
> Patch also adds XML attribute 'driverRef' to Spring configuration (org.apache.camel.model.dataformat.XStreamDataFormat). However this new attribute of Spring DSL doesn't work because I got no idea how to wire existing Spring bean into the created dataFormat instance (since org.apache.camel.model.dataformat.XStreamDataFormat is Spring-unaware).
> Could somebody take a look at it, fix Spring DSL support and probably commit it to the codebase?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-3154) [XStream] Custom Xstream driver
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang resolved CAMEL-3154.
---------------------------------
Fix Version/s: 2.5.0
Resolution: Fixed
Applied patch with thanks to Henryk.
> [XStream] Custom Xstream driver
> -------------------------------
>
> Key: CAMEL-3154
> URL: https://issues.apache.org/activemq/browse/CAMEL-3154
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: Henryk Konsek
> Assignee: Willem Jiang
> Priority: Trivial
> Fix For: 2.5.0
>
> Attachments: xstream_custom_driver.patch
>
>
> AbstractXStreamWrapper#createXStream uses hardcoded default XStream constructor. Such design makes impossible to set custom HierarchicalStreamDriver to the XStream instance.
> It would be nice to provide an ability to configure AbstractXStreamWrapper with optional HierarchicalStreamDriver instance.
> I created patch which adds AbstractXStreamWrapper#xstreamDriver property (+test).
> Patch also adds XML attribute 'driverRef' to Spring configuration (org.apache.camel.model.dataformat.XStreamDataFormat). However this new attribute of Spring DSL doesn't work because I got no idea how to wire existing Spring bean into the created dataFormat instance (since org.apache.camel.model.dataformat.XStreamDataFormat is Spring-unaware).
> Could somebody take a look at it, fix Spring DSL support and probably commit it to the codebase?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3154) [XStream] Custom Xstream driver
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=62087#action_62087 ]
Claus Ibsen commented on CAMEL-3154:
------------------------------------
Willem please add a spring XML based unit test as well to ensure the XML is correct and that it works.
> [XStream] Custom Xstream driver
> -------------------------------
>
> Key: CAMEL-3154
> URL: https://issues.apache.org/activemq/browse/CAMEL-3154
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: Henryk Konsek
> Assignee: Willem Jiang
> Priority: Trivial
> Fix For: 2.5.0
>
> Attachments: xstream_custom_driver.patch
>
>
> AbstractXStreamWrapper#createXStream uses hardcoded default XStream constructor. Such design makes impossible to set custom HierarchicalStreamDriver to the XStream instance.
> It would be nice to provide an ability to configure AbstractXStreamWrapper with optional HierarchicalStreamDriver instance.
> I created patch which adds AbstractXStreamWrapper#xstreamDriver property (+test).
> Patch also adds XML attribute 'driverRef' to Spring configuration (org.apache.camel.model.dataformat.XStreamDataFormat). However this new attribute of Spring DSL doesn't work because I got no idea how to wire existing Spring bean into the created dataFormat instance (since org.apache.camel.model.dataformat.XStreamDataFormat is Spring-unaware).
> Could somebody take a look at it, fix Spring DSL support and probably commit it to the codebase?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-3154) [XStream] Custom Xstream driver
Posted by "Henryk Konsek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henryk Konsek updated CAMEL-3154:
---------------------------------
Attachment: xstream_custom_driver.patch
> [XStream] Custom Xstream driver
> -------------------------------
>
> Key: CAMEL-3154
> URL: https://issues.apache.org/activemq/browse/CAMEL-3154
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: Henryk Konsek
> Priority: Trivial
> Attachments: xstream_custom_driver.patch
>
>
> AbstractXStreamWrapper#createXStream uses hardcoded default XStream constructor. Such design makes impossible to set custom HierarchicalStreamDriver to the XStream instance.
> It would be nice to provide an ability to configure AbstractXStreamWrapper with optional HierarchicalStreamDriver instance.
> I created patch which adds AbstractXStreamWrapper#xstreamDriver property (+test).
> Patch also adds XML attribute 'driverRef' to Spring configuration (org.apache.camel.model.dataformat.XStreamDataFormat). However this new attribute of Spring DSL doesn't work because I got no idea how to wire existing Spring bean into the created dataFormat instance (since org.apache.camel.model.dataformat.XStreamDataFormat is Spring-unaware).
> Could somebody take a look at it, fix Spring DSL support and probably commit it to the codebase?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.