You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/11/22 09:16:08 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #2240: [Enhancement] Method needlessly boxes a boolean constant [PinpointSpanExporter]

Alonexc opened a new issue, #2240:
URL: https://github.com/apache/incubator-eventmesh/issues/2240

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/203272871-3c294c1e-afa6-4a05-a499-c26809505b91.png)
   located at:
   org/apache/eventmesh/trace/pinpoint/exporter/PinpointSpanExporter.java line 169
   analysis and explanation:
   This method assigns a Boxed boolean constant to a primitive boolean variable, or assigns a primitive boolean constant to a Boxed boolean variable. Use the correct constant for the variable desired.
   
   
   ### Describe the solution you'd like
   
   It is sufficient to use the constant value true directly, no need to use boxed Boolean constants.
   reference:
   ![image](https://user-images.githubusercontent.com/91315508/203272685-bc5294cb-50bb-488a-94fa-9e7e353e1dcf.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] LIU-WEI-git closed issue #2240: [Enhancement] Method needlessly boxes a boolean constant [PinpointSpanExporter]

Posted by GitBox <gi...@apache.org>.
LIU-WEI-git closed issue #2240: [Enhancement]  Method needlessly boxes a boolean constant [PinpointSpanExporter]
URL: https://github.com/apache/incubator-eventmesh/issues/2240


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] LiuPiPiPi commented on issue #2240: [Enhancement] Method needlessly boxes a boolean constant [PinpointSpanExporter]

Posted by GitBox <gi...@apache.org>.
LiuPiPiPi commented on issue #2240:
URL: https://github.com/apache/incubator-eventmesh/issues/2240#issuecomment-1328224258

   Hi, I want to fix this bug. @Alonexc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org