You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by victorsosa <gi...@git.apache.org> on 2016/01/02 17:10:22 UTC
[GitHub] struts pull request: Patch ww-4564
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/62
Patch ww-4564
set content type see ww-4564
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/victorsosa/struts patch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/62.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #62
----
commit 70b1b2c497e929a3403c2bde0f8bec46dec8ccf9
Author: Victor Sosa <vi...@gmail.com>
Date: 2015-12-31T22:04:43Z
fix for WW-4564
Postback result is rendered as plain-text rather than html form in
Chrome
the response's content type must be set to text/html in order for Chrome
to properly handle the operation.
commit d5a6c355891b06f803d3dfb8a8ddea6249093f0c
Author: Victor Sosa <vi...@gmail.com>
Date: 2016-01-01T00:10:19Z
fix for WW-4564
Postback result is rendered as plain-text rather than html form in
Chrome
the response's content type must be set to text/html in order for Chrome
to properly handle the operation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: Patch ww-4564
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/62#discussion_r48685914
--- Diff: core/src/main/java/org/apache/struts2/result/PostbackResult.java ---
@@ -76,6 +76,10 @@
*/
public class PostbackResult extends StrutsResultSupport {
+ /**
+ *
+ */
+ private static final long serialVersionUID = -2283504349296877429L;
--- End diff --
Could you drop that empty comment section? And please add an empty line to separate static field from the other fields. Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: Patch ww-4564
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/62#discussion_r48685951
--- Diff: core/src/main/java/org/apache/struts2/result/PostbackResult.java ---
@@ -76,6 +76,10 @@
*/
public class PostbackResult extends StrutsResultSupport {
+ /**
+ *
+ */
+ private static final long serialVersionUID = -2283504349296877429L;
--- End diff --
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: Patch ww-4564
Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on a diff in the pull request:
https://github.com/apache/struts/pull/62#discussion_r48685943
--- Diff: core/src/main/java/org/apache/struts2/result/PostbackResult.java ---
@@ -76,6 +76,10 @@
*/
public class PostbackResult extends StrutsResultSupport {
+ /**
+ *
+ */
+ private static final long serialVersionUID = -2283504349296877429L;
--- End diff --
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: Patch ww-4564
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/struts/pull/62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org