You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "rnewson (via GitHub)" <gi...@apache.org> on 2023/12/11 23:38:08 UTC
[PR] Build nouveau package [couchdb-pkg]
rnewson opened a new pull request, #125:
URL: https://github.com/apache/couchdb-pkg/pull/125
TODO;
1) ability to set java options like xmx
2) enable dropwizard admin port
3) debconf questions for server port and index location?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#issuecomment-2205449549
> Not sure why the file is not there, will have to debug further, later. So far it's as far as I got tonight.
Iirc I had something similar on Windows but I hadn’t time to dive in. My guess is some configure stuff with SM/Quickjs …
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson merged PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#discussion_r1426880903
##########
debian/conf/nouveau.yaml:
##########
Review Comment:
The idea is to follow the pattern of default.ini if possible. There are other config entries besides where data goes like `maxIndexesOpen`, `commitIntervalSeconds`, `idleSeconds`, `port`, `adminConnectors`, `gzip` etc. The idea is to keep in a config file like `default.ini` in the main repo as opposed to have separate config files for rpm, deb, docker and the main the release artifact (the result of `make release`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#issuecomment-2161525173
I noticed the failure on ppc64el architecture. I'll try exclude it.
```
==> weatherreport (escriptize)
WARN: 'escriptize' command does not apply to directory /home/jenkins/couchdb/apache-couchdb-3.3.3-64bf1de/rel
WARN: 'escriptize' command does not apply to directory /home/jenkins/couchdb/apache-couchdb-3.3.3-64bf1de
Unknown privilege violation (03)
NIP 000000401a3da3b0 LR 0000004002add238 CTR 000000401a3da380 XER 0000000000000000 CPU#1
MSR 9000000102806901 HID0 0000000000000000 HF 02806105 iidx 0 didx 0
TB 00006518 27996706167885
GPR00 ffffffbffd038490 0000004002fc7970 0000004002c42d00 0000004002fc8b70
GPR04 0000000000000000 0000000000002000 0000000000000000 0000000000000000
GPR08 0000004002ca2d00 0000004002c6617c 0000000000000001 0000000000000000
GPR12 000000401a3da380 0000004002fd28f0 00000040018be468 0000000000000000
GPR16 0000004001872000 000000401a3da3a4 000000401a3da3ac 000000401a3da3d0
GPR20 000000401a3da3d8 0000004002c73f08 00000000000003d8 0000004004025ea0
GPR24 0000004004026278 0000004002fc79d0 0000004004025e90 0000004004025e50
GPR28 0000004002c66188 000000401a3da380 0000004002ca4c20 0000004002fc7970
CR 28004400 [ E L - - G G - - ] RES 0000004002fc8b70
Downloading https://services.gradle.org/distributions/gradle-8.6-bin.zip
............10%.............20%............30%.............40%.............50%............60%.............70%.............80%............90%.............100%
Welcome to Gradle 8.6!
Here are the highlights of this release:
- Configurable encryption key for configuration cache
- Build init improvements
- Build authoring improvements
For more details see https://docs.gradle.org/8.6/release-notes.html
Starting a Gradle Daemon (subsequent builds will be faster)
> Task :spotlessInternalRegisterDependencies
> Task :spotlessJava
Step 'removeUnusedImports' found problem in 'src/main/java/org/apache/couchdb/nouveau/lucene9/Lucene9Index.java':
2:7: error: class, interface, or enum expected
com.google.googlejavaformat.java.FormatterException: 2:7: error: class, interface, or enum expected
at com.google.googlejavaformat.java.FormatterException.fromJavacDiagnostics(FormatterException.java:51)
at com.google.googlejavaformat.java.RemoveUnusedImports.parse(RemoveUnusedImports.java:264)
at com.google.googlejavaformat.java.RemoveUnusedImports.removeUnusedImports(RemoveUnusedImports.java:218)
at com.diffplug.spotless.glue.java.GoogleJavaFormatRemoveUnusedImporterFormatterFunc.apply(GoogleJavaFormatRemoveUnusedImporterFormatterFunc.java:38)
at com.diffplug.spotless.FormatterFunc.apply(FormatterFunc.java:32)
at com.diffplug.spotless.FormatterStepImpl$Standard.format(FormatterStepImpl.java:82)
at com.diffplug.spotless.FormatterStep$Strict.format(FormatterStep.java:103)
at com.diffplug.spotless.Formatter.compute(Formatter.java:246)
at com.diffplug.spotless.PaddedCell.calculateDirtyState(PaddedCell.java:214)
at com.diffplug.spotless.PaddedCell.calculateDirtyState(PaddedCell.java:190)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#issuecomment-2160055059
@nickva cannot reproduce that. I ran couchdb-pkg locally with a tarball of 4c52700, but it passes. the spotless error is a claim that Lucene9Index.java doesn't declare a class, which it clearly does, and it references line 2, which is a comment. So I suspect something else is going on, perhaps the file has some other content than expected (perhaps conflict markers?). Let's see if this is repeatable. if so, we'll need to tweak makefile to print this file to the build output
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#discussion_r1424272380
##########
debian/conf/nouveau.yaml:
##########
Review Comment:
This is a nice config file. Would it make sense to keep it the main repo and make it part of the release artifacts. In that way people who use the plain release tarball would have a config file start with, and it would be closer to what we do for default.ini.
One difficulty is what to do put in for the data dirs. For the main one we fill in template vas in the `make release` releas [step](https://github.com/apache/couchdb/blob/e551cac5a89678abedca5cef075b9426bf9f8cf3/rel/reltool.config#L150-L153). Wonder if that would work for nouveau, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on code in PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#discussion_r1426864790
##########
debian/conf/nouveau.yaml:
##########
Review Comment:
not following this suggestion. the couchdb package dictates where couchdb data goes, not configurable. I just followed that pattern for the indexes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#issuecomment-2159871567
I tried rebasing on the latest main using Erlang 25 as the default and noticed a spotlessJava error when building packages:
```
Digest: sha256:c1f482c8ce061b766244d41dbbbb7084a1ffdf12c1028954f1f035d659587635
Status: Downloaded newer image for apache/couchdbci-debian:bullseye-erlang-25.3.2.12
mkdir -p ../couchdb
cp apache-couchdb-3.3.3-4c52700.tar.gz ../couchdb
cd ../couchdb && tar xfz *.tar.gz
sed 's/%SPIDERMONKEY%/libmozjs-78-0/g;s/%SPIDERMONKEY_DEV%/libmozjs-78-dev/g' \
debian/control.in > debian/control
echo 'SM_VER = 78' > debian/sm_ver.mk
rm -rf /home/jenkins/couchdb/apache-couchdb-3.3.3-4c52700/debian
cp -R debian /home/jenkins/couchdb/apache-couchdb-3.3.3-4c52700
cd /home/jenkins/couchdb/apache-couchdb-3.3.3-4c52700 && dch -v 3.3.3-4c52700~bullseye "Automatically generated package from upstream."
cd /home/jenkins/couchdb/apache-couchdb-3.3.3-4c52700 && dpkg-buildpackage -b -us -uc
dpkg-buildpackage: info: source package couchdb
dpkg-buildpackage: info: source version 3.3.3-4c52700~bullseye
dpkg-buildpackage: info: source distribution UNRELEASED
dpkg-buildpackage: info: source changed by "CouchDB Developers" <"dev@couchdb.apache.org">
dpkg-source --before-build .
dpkg-buildpackage: info: host architecture ppc64el
dpkg-source: info: using options from apache-couchdb-3.3.3-4c52700/debian/source/options: --compression=bzip2 --compression-level=9
debian/rules clean
make[1]: Entering directory '/home/jenkins/couchdb/apache-couchdb-3.3.3-4c52700'
dh clean --with=systemd
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
debian/rules override_dh_auto_clean
make[2]: Entering directory '/home/jenkins/couchdb/apache-couchdb-3.3.3-4c52700'
dh_auto_clean
dh_auto_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use)
make -j1 distclean
make[3]: Entering directory '/home/jenkins/couchdb/apache-couchdb-3.3.3-4c52700'
...
Downloading https://services.gradle.org/distributions/gradle-8.6-bin.zip
............10%.............20%............30%.............40%.............50%............60%.............70%.............80%............90%.............100%
Welcome to Gradle 8.6!
Here are the highlights of this release:
- Configurable encryption key for configuration cache
- Build init improvements
- Build authoring improvements
For more details see https://docs.gradle.org/8.6/release-notes.html
Starting a Gradle Daemon (subsequent builds will be faster)
> Task :spotlessInternalRegisterDependencies
> Task :spotlessJava
Step 'removeUnusedImports' found problem in 'src/main/java/org/apache/couchdb/nouveau/lucene9/Lucene9Index.java':
2:7: error: class, interface, or enum expected
com.google.googlejavaformat.java.FormatterException: 2:7: error: class, interface, or enum expected
at com.google.googlejavaformat.java.FormatterException.fromJavacDiagnostics(FormatterException.java:51)
at com.google.googlejavaformat.java.RemoveUnusedImports.parse(RemoveUnusedImports.java:264)
at com.google.googlejavaformat.java.RemoveUnusedImports.removeUnusedImports(RemoveUnusedImports.java:218)
at com.diffplug.spotless.glue.java.GoogleJavaFormatRemoveUnusedImporterFormatterFunc.apply(GoogleJavaFormatRemoveUnusedImporterFormatterFunc.java:38)
at com.diffplug.spotless.FormatterFunc.apply(FormatterFunc.java:32)
at com.diffplug.spotless.FormatterStepImpl$Standard.format(FormatterStepImpl.java:82)
at com.diffplug.spotless.FormatterStep$Strict.format(FormatterStep.java:103)
at com.diffplug.spotless.Formatter.compute(Formatter.java:246)
at com.diffplug.spotless.PaddedCell.calculateDirtyState(PaddedCell.java:214)
at com.diffplug.spotless.PaddedCell.calculateDirtyState(PaddedCell.java:190)
at com.diffplug.gradle.spotless.SpotlessTaskImpl.processInputFile(SpotlessTaskImpl.java:105)
at com.diffplug.gradle.spotless.SpotlessTaskImpl.performAction(SpotlessTaskImpl.java:89)
at java.base@11.0.23/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base@11.0.23/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base@11.0.23/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base@11.0.23/java.lang.reflect.Method.invoke(Method.java:566)
at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:125)
at org.gradle.api.internal.project.taskfactory.IncrementalTaskAction.doExecute(IncrementalTaskAction.java:45)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:51)
at org.gradle.api.internal.project.taskfactory.IncrementalTaskAction.execute(IncrementalTaskAction.java:26)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:29)
at org.gradle.api.internal.tasks.execution.TaskExecution$3.run(TaskExecution.java:247)
at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
at org.gradle.internal.operations.DefaultBuildOperationRunner.run(DefaultBuildOperationRunner.java:47)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:68)
at org.gradle.api.internal.tasks.execution.TaskExecution.executeAction(TaskExecution.java:232)
at org.gradle.api.internal.tasks.execution.TaskExecution.executeActions(TaskExecution.java:215)
at org.gradle.api.internal.tasks.execution.TaskExecution.executeWithPreviousOutputFiles(TaskExecution.java:198)
at org.gradle.api.internal.tasks.execution.TaskExecution.execute(TaskExecution.java:165)
at org.gradle.internal.execution.steps.ExecuteStep.executeInternal(ExecuteStep.java:105)
at org.gradle.internal.execution.steps.ExecuteStep.access$000(ExecuteStep.java:44)
at org.gradle.internal.execution.steps.ExecuteStep$1.call(ExecuteStep.java:59)
at org.gradle.internal.execution.steps.ExecuteStep$1.call(ExecuteStep.java:56)
at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:56)
at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:44)
at org.gradle.internal.execution.steps.CancelExecutionStep.execute(CancelExecutionStep.java:41)
at org.gradle.internal.execution.steps.TimeoutStep.executeWithoutTimeout(TimeoutStep.java:74)
at org.gradle.internal.execution.steps.TimeoutStep.execute(TimeoutStep.java:55)
at org.gradle.internal.execution.steps.PreCreateOutputParentsStep.execute(PreCreateOutputParentsStep.java:50)
at org.gradle.internal.execution.steps.PreCreateOutputParentsStep.execute(PreCreateOutputParentsStep.java:28)
at org.gradle.internal.execution.steps.RemovePreviousOutputsStep.execute(RemovePreviousOutputsStep.java:67)
at org.gradle.internal.execution.steps.RemovePreviousOutputsStep.execute(RemovePreviousOutputsStep.java:37)
at org.gradle.internal.execution.steps.BroadcastChangingOutputsStep.execute(BroadcastChangingOutputsStep.java:61)
at org.gradle.internal.execution.steps.BroadcastChangingOutputsStep.execute(BroadcastChangingOutputsStep.java:26)
at org.gradle.internal.execution.steps.CaptureOutputsAfterExecutionStep.execute(CaptureOutputsAfterExecutionStep.java:64)
at org.gradle.internal.execution.steps.CaptureOutputsAfterExecutionStep.execute(CaptureOutputsAfterExecutionStep.java:42)
at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:40)
at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:29)
at org.gradle.internal.execution.steps.BuildCacheStep.executeWithoutCache(BuildCacheStep.java:189)
at org.gradle.internal.execution.steps.BuildCacheStep.lambda$execute$1(BuildCacheStep.java:75)
at org.gradle.internal.Either$Right.fold(Either.java:175)
at org.gradle.internal.execution.caching.CachingState.fold(CachingState.java:59)
at org.gradle.internal.execution.steps.BuildCacheStep.execute(BuildCacheStep.java:73)
at org.gradle.internal.execution.steps.BuildCacheStep.execute(BuildCacheStep.java:48)
at org.gradle.internal.execution.steps.StoreExecutionStateStep.execute(StoreExecutionStateStep.java:44)
at org.gradle.internal.execution.steps.StoreExecutionStateStep.execute(StoreExecutionStateStep.java:33)
at org.gradle.internal.execution.steps.SkipUpToDateStep.executeBecause(SkipUpToDateStep.java:76)
at org.gradle.internal.execution.steps.SkipUpToDateStep.lambda$execute$2(SkipUpToDateStep.java:54)
at java.base@11.0.23/java.util.Optional.orElseGet(Optional.java:369)
at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:54)
at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:36)
at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:65)
at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:36)
at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:37)
at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:27)
at org.gradle.internal.execution.steps.ResolveCachingStateStep.execute(ResolveCachingStateStep.java:76)
at org.gradle.internal.execution.steps.ResolveCachingStateStep.execute(ResolveCachingStateStep.java:37)
at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:106)
at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:55)
at org.gradle.internal.execution.steps.AbstractCaptureStateBeforeExecutionStep.execute(AbstractCaptureStateBeforeExecutionStep.java:64)
at org.gradle.internal.execution.steps.AbstractCaptureStateBeforeExecutionStep.execute(AbstractCaptureStateBeforeExecutionStep.java:43)
at org.gradle.internal.execution.steps.AbstractSkipEmptyWorkStep.executeWithNonEmptySources(AbstractSkipEmptyWorkStep.java:125)
at org.gradle.internal.execution.steps.AbstractSkipEmptyWorkStep.execute(AbstractSkipEmptyWorkStep.java:56)
at org.gradle.internal.execution.steps.AbstractSkipEmptyWorkStep.execute(AbstractSkipEmptyWorkStep.java:36)
at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsStartedStep.execute(MarkSnapshottingInputsStartedStep.java:38)
at org.gradle.internal.execution.steps.LoadPreviousExecutionStateStep.execute(LoadPreviousExecutionStateStep.java:36)
at org.gradle.internal.execution.steps.LoadPreviousExecutionStateStep.execute(LoadPreviousExecutionStateStep.java:23)
at org.gradle.internal.execution.steps.HandleStaleOutputsStep.execute(HandleStaleOutputsStep.java:75)
at org.gradle.internal.execution.steps.HandleStaleOutputsStep.execute(HandleStaleOutputsStep.java:41)
at org.gradle.internal.execution.steps.AssignMutableWorkspaceStep.lambda$execute$0(AssignMutableWorkspaceStep.java:35)
at org.gradle.api.internal.tasks.execution.TaskExecution$4.withWorkspace(TaskExecution.java:292)
at org.gradle.internal.execution.steps.AssignMutableWorkspaceStep.execute(AssignMutableWorkspaceStep.java:31)
at org.gradle.internal.execution.steps.AssignMutableWorkspaceStep.execute(AssignMutableWorkspaceStep.java:22)
at org.gradle.internal.execution.steps.ChoosePipelineStep.execute(ChoosePipelineStep.java:40)
at org.gradle.internal.execution.steps.ChoosePipelineStep.execute(ChoosePipelineStep.java:23)
at org.gradle.internal.execution.steps.ExecuteWorkBuildOperationFiringStep.lambda$execute$2(ExecuteWorkBuildOperationFiringStep.java:66)
at java.base@11.0.23/java.util.Optional.orElseGet(Optional.java:369)
at org.gradle.internal.execution.steps.ExecuteWorkBuildOperationFiringStep.execute(ExecuteWorkBuildOperationFiringStep.java:66)
at org.gradle.internal.execution.steps.ExecuteWorkBuildOperationFiringStep.execute(ExecuteWorkBuildOperationFiringStep.java:38)
at org.gradle.internal.execution.steps.IdentityCacheStep.execute(IdentityCacheStep.java:36)
at org.gradle.internal.execution.steps.IdentityCacheStep.execute(IdentityCacheStep.java:26)
at org.gradle.internal.execution.steps.IdentifyStep.execute(IdentifyStep.java:47)
at org.gradle.internal.execution.steps.IdentifyStep.execute(IdentifyStep.java:34)
at org.gradle.internal.execution.impl.DefaultExecutionEngine$1.execute(DefaultExecutionEngine.java:61)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:145)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134)
at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)
at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:74)
at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:52)
at org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNodeExecutor.java:42)
at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:331)
at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:318)
at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.lambda$execute$0(DefaultTaskExecutionGraph.java:314)
at org.gradle.internal.operations.CurrentBuildOperationRef.with(CurrentBuildOperationRef.java:80)
at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:314)
at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:303)
at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.execute(DefaultPlanExecutor.java:463)
at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.run(DefaultPlanExecutor.java:380)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
at org.gradle.internal.concurrent.AbstractManagedExecutor$1.run(AbstractManagedExecutor.java:47)
at java.base@11.0.23/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base@11.0.23/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base@11.0.23/java.lang.Thread.run(Thread.java:829)
> Task :spotlessJava FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':spotlessJava'.
> Issue processing file: /home/jenkins/couchdb/apache-couchdb-3.3.3-4c52700/nouveau/src/main/java/org/apache/couchdb/nouveau/lucene9/Lucene9Index.java
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.
BUILD FAILED in 3m 22s
2 actionable tasks: 2 executed
make[3]: *** [Makefile:556: nouveau] Error 1
make[3]: Leaving directory '/home/jenkins/couchdb/apache-couchdb-3.3.3-4c52700'
dh_auto_build: error: make -j1 release returned exit code 2
make[2]: *** [debian/rules:32: override_dh_auto_build] Error 25
make[2]: Leaving directory '/home/jenkins/couchdb/apache-couchdb-3.3.3-4c52700'
make[1]: *** [debian/rules:17: build] Error 2
make[1]: Leaving directory '/home/jenkins/couchdb/apache-couchdb-3.3.3-4c52700'
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
make: *** [Makefile:238: dpkg] Error 2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#discussion_r1426880903
##########
debian/conf/nouveau.yaml:
##########
Review Comment:
The idea is to follow the pattern of default.ini if possible. There are other config entries besides where data goes like `maxIndexesOpen`, `commitIntervalSeconds`, `idleSeconds`, `port`, `adminConnectors`, `gzip` etc. Wonder if it's easier to keep it in the main as opposed to having separate config files for rpm, deb, docker and the main the release artifact (the result of `make release`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#issuecomment-2205164648
I created the base CouchDB and Nouveau packages for Bullseye with the latest changes.
Main package installed fine. Nouveau feature was disabled as expected.
With the running CouchDB server, installed the Nouveau package. Installed went well, it asked for an option to enable it. I check it as "yes". I noticed the new .ini file was created in the right place and had the expected content.
Enable nouveau didn't take effect though after `POST`-ing to `_node/_local/_config/_reload`. That seems to be an issue with the config system. It doesn't know how to auto-detect a new .ini file during reload. Would we expect that to work? It might be nice to allow dynamic enablement via a config reload. But that's a minor issue I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#issuecomment-2206024639
oh that's icky, that we don't notice new .ini files except at startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#issuecomment-2139317338
I can't repro the java cert issue but https://bugs.launchpad.net/ubuntu/+source/ca-certificates-java/+bug/1998065 sounds related. it's not a bug in the nouveau package, at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on code in PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#discussion_r1426894792
##########
debian/conf/nouveau.yaml:
##########
@@ -0,0 +1,28 @@
+maxIndexesOpen: 5000
Review Comment:
deal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "janl (via GitHub)" <gi...@apache.org>.
janl commented on code in PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#discussion_r1423874951
##########
debian/conf/nouveau.yaml:
##########
@@ -0,0 +1,28 @@
+maxIndexesOpen: 5000
Review Comment:
how do we get to `5000` here? `max_dbs_open` is `500` by default, should we match that? do we want to go 10x intentionally because we typically expect >1 index per db?
##########
debian/conf/nouveau.yaml:
##########
@@ -0,0 +1,28 @@
+maxIndexesOpen: 5000
+commitIntervalSeconds: 30
+idleSeconds: 60
+rootDir: /var/opt/nouveau/indexes
+
+logging:
+ level: INFO
+
+server:
+ applicationConnectors:
+ - type: http
+ bindHost: 127.0.0.1
+ port: 5987
Review Comment:
I like 7!
##########
debian/control.in:
##########
@@ -56,3 +57,17 @@ Description: RESTful document oriented database
standalone node or part of a cluster, and associated other parameters as
necessary. It adds the systemd / init job and other items needed for a
system-wide CouchDB instance that is started at boot.
+
+Package: couchdb-nouveau
+Architecture: any
+Depends: systemd,
+ default-jre-headless | java11-runtime-headless | java11-runtime,
+ lsb-base,
+ procps,
+ ${misc:Depends}
+Description: Nouveau is a modern replacement for dreyfus/clouseau
Review Comment:
maybe something high-level front, along the lines of ~“Nouveau adds Lucene-style indexing and searching to Apache CouchDB. …” then the rest?
##########
debian/couchdb-nouveau.templates:
##########
@@ -0,0 +1,11 @@
+# NOTE TO DEVELOPERS
+# If you change this file, run debconf-updatepo !
+# Failure to do so will result in a rejected pull request.
+
+Template: couchdb-nouveau/postrm_remove_indexes
+Type: boolean
+Default: false
+_Description: Remove all CouchDB Nouveau indexes?
Review Comment:
```suggestion
_Description: Remove all CouchDB Nouveau indexe data?
```
maybe this makes it more clear that this is something one cares about?
##########
debian/control.in:
##########
@@ -56,3 +57,17 @@ Description: RESTful document oriented database
standalone node or part of a cluster, and associated other parameters as
necessary. It adds the systemd / init job and other items needed for a
system-wide CouchDB instance that is started at boot.
+
+Package: couchdb-nouveau
+Architecture: any
+Depends: systemd,
+ default-jre-headless | java11-runtime-headless | java11-runtime,
+ lsb-base,
+ procps,
+ ${misc:Depends}
+Description: Nouveau is a modern replacement for dreyfus/clouseau
Review Comment:
maybe something high-level front, along the lines of ~“Nouveau adds Lucene-style indexing and searching to Apache CouchDB. …” then the rest?
##########
debian/conf/nouveau.yaml:
##########
@@ -0,0 +1,28 @@
+maxIndexesOpen: 5000
+commitIntervalSeconds: 30
+idleSeconds: 60
+rootDir: /var/opt/nouveau/indexes
+
+logging:
+ level: INFO
+
+server:
+ applicationConnectors:
+ - type: http
+ bindHost: 127.0.0.1
+ port: 5987
+ useDateHeader: false
+ gzip:
+ includedMethods:
+ - GET
+ - POST
+ requestLog:
+ appenders:
+ - type: file
+ archive: true
+ archivedFileCount: 5
+ archivedLogFilenamePattern: /var/opt/nouveau/log/nouveau-%i.log
Review Comment:
Does this mean Dropwizard does its own log rotation?
##########
debian/couchdb-nouveau.templates:
##########
@@ -0,0 +1,11 @@
+# NOTE TO DEVELOPERS
+# If you change this file, run debconf-updatepo !
+# Failure to do so will result in a rejected pull request.
+
+Template: couchdb-nouveau/postrm_remove_indexes
+Type: boolean
+Default: false
+_Description: Remove all CouchDB Nouveau indexes?
+ The /var/opt/couchdb-nouveau/ directory containing all CouchDB databases will
Review Comment:
```suggestion
The /var/opt/couchdb-nouveau/ directory containing all Nouveau indexes will
```
copypasta mistake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#issuecomment-2161186473
Thanks @rnewson, perhaps there is something flaky in my setup.
One step I forgot to mention is I rebased nouveau on main branch to make sure we're using OTP 25 in couchdb-pkg. If you get chance, could you rebase on main.
I try to re-run everything again. With a rebased nouveau branch, latest main commit `64bf1de`, `./configure --without-proper && make && make dist` to product the tarball, then `./build.sh couch-all ./...3.3.3-64bf1de.tar.gz`. To eliminate the extra architecture issues (the above failure might have been the arm64), I'll build for x86_64 only for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#issuecomment-2205410150
> Enabling Nouveau didn't take effect though after `POST`-ing to `_node/_local/_config/_reload`. That seems to be an issue with the config system. It doesn't know how to auto-detect a new .ini file during reload. Would we expect that to work? It might be nice to allow dynamic enablement via a config reload. But that's a minor issue I think.
I think that’s because the [list of ini files](https://github.com/apache/couchdb/blob/95310c3630283d036f277a803bacee124ae62d66/src/config/src/config_app.erl#L31) is loaded during the start of CouchDB and is “static” afterwards. Maybe we have to re-read those files on reload?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on code in PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#discussion_r1424277450
##########
debian/conf/nouveau.yaml:
##########
@@ -0,0 +1,28 @@
+maxIndexesOpen: 5000
Review Comment:
pick a number? There's an LRU (hopefully better than the one I wrote for clouseau) so the number here is a guess at how many we think a server could have open and active at once. 5000 is probably high then.
1000?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on code in PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#discussion_r1423886007
##########
debian/conf/nouveau.yaml:
##########
@@ -0,0 +1,28 @@
+maxIndexesOpen: 5000
+commitIntervalSeconds: 30
+idleSeconds: 60
+rootDir: /var/opt/nouveau/indexes
+
+logging:
+ level: INFO
+
+server:
+ applicationConnectors:
+ - type: http
+ bindHost: 127.0.0.1
+ port: 5987
+ useDateHeader: false
+ gzip:
+ includedMethods:
+ - GET
+ - POST
+ requestLog:
+ appenders:
+ - type: file
+ archive: true
+ archivedFileCount: 5
+ archivedLogFilenamePattern: /var/opt/nouveau/log/nouveau-%i.log
Review Comment:
Jetty does, and nouveau exposes it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on code in PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#discussion_r1494412783
##########
debian/conf/nouveau.yaml:
##########
Review Comment:
this is done now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "janl (via GitHub)" <gi...@apache.org>.
janl commented on code in PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#discussion_r1423995442
##########
debian/conf/nouveau.yaml:
##########
@@ -0,0 +1,28 @@
+maxIndexesOpen: 5000
Review Comment:
our default `q` is 2 and `n` would be `3`, so we’d be at `500 * 3 * 2 = 3000` — I don’t mind adding 2k for good measure, but it might be nice to choose a default that has a justification that allows admins to change this when they deviate from our defaults in other places, sort of teaching how this all fits together.
##########
debian/conf/nouveau.yaml:
##########
@@ -0,0 +1,28 @@
+maxIndexesOpen: 5000
Review Comment:
our default `q` is 2 and `n` would be `3`, so we’d be at `500 * 3 * 2 = 3000` — I don’t mind adding 2k for good measure, but it might be nice to choose a default that has a justification that allows admins to change this when they deviate from our defaults in other places, sort of teaching how this all fits together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "janl (via GitHub)" <gi...@apache.org>.
janl commented on code in PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#discussion_r1424522787
##########
debian/conf/nouveau.yaml:
##########
@@ -0,0 +1,28 @@
+maxIndexesOpen: 5000
Review Comment:
I thought max_open_files * q * n defaults was a good measure: 3000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build nouveau package [couchdb-pkg]
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on code in PR #125:
URL: https://github.com/apache/couchdb-pkg/pull/125#discussion_r1423885667
##########
debian/conf/nouveau.yaml:
##########
@@ -0,0 +1,28 @@
+maxIndexesOpen: 5000
Review Comment:
there's a multiplier of at least `q` here (would also be a multiplier of `n` if in future you have 1 nouveau server for all N couchdb servers). if you had 500 dbs you might have 500*8 indexes, but really this number is just a guess. I think it will be a debconf parameter and certainly something an admin will change over time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org