You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2022/01/13 16:10:18 UTC
[logging-log4j2] branch master updated (cdaea1c -> 3dd3618)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git.
from cdaea1c Revert "Comment GH description from .asf.yaml"
new 429c0cc Javadoc.
new 3c09d48 Sort members and use final.
new ece9980 Sort members and use final.
new 3dd3618 Remove blank lines.
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../log4j/helpers/AppenderAttachableImpl.java | 59 ++++++++++++----------
.../org/apache/log4j/legacy/core/CategoryUtil.java | 2 -
2 files changed, 31 insertions(+), 30 deletions(-)
[logging-log4j2] 04/04: Remove blank lines.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
commit 3dd3618d578fdd049ca83b9d903d2efdb688d472
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Jan 13 11:05:41 2022 -0500
Remove blank lines.
---
.../src/main/java/org/apache/log4j/legacy/core/CategoryUtil.java | 2 --
1 file changed, 2 deletions(-)
diff --git a/log4j-1.2-api/src/main/java/org/apache/log4j/legacy/core/CategoryUtil.java b/log4j-1.2-api/src/main/java/org/apache/log4j/legacy/core/CategoryUtil.java
index 6649324..04c47aa 100644
--- a/log4j-1.2-api/src/main/java/org/apache/log4j/legacy/core/CategoryUtil.java
+++ b/log4j-1.2-api/src/main/java/org/apache/log4j/legacy/core/CategoryUtil.java
@@ -35,7 +35,6 @@ public final class CategoryUtil {
public static Logger getParent(final Logger logger) {
if (logger instanceof org.apache.logging.log4j.core.Logger) {
return ((org.apache.logging.log4j.core.Logger) logger).getParent();
-
}
return null;
}
@@ -56,7 +55,6 @@ public final class CategoryUtil {
public static void setLevel(final Logger logger, final Level level) {
if (logger instanceof org.apache.logging.log4j.core.Logger) {
((org.apache.logging.log4j.core.Logger) logger).setLevel(level);
-
}
}
[logging-log4j2] 01/04: Javadoc.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
commit 429c0cc9305476a369f37fbaef74ccf3eb915476
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Jan 13 10:37:39 2022 -0500
Javadoc.
---
.../src/main/java/org/apache/log4j/helpers/AppenderAttachableImpl.java | 3 +++
1 file changed, 3 insertions(+)
diff --git a/log4j-1.2-api/src/main/java/org/apache/log4j/helpers/AppenderAttachableImpl.java b/log4j-1.2-api/src/main/java/org/apache/log4j/helpers/AppenderAttachableImpl.java
index 91146ad..acb3c53 100644
--- a/log4j-1.2-api/src/main/java/org/apache/log4j/helpers/AppenderAttachableImpl.java
+++ b/log4j-1.2-api/src/main/java/org/apache/log4j/helpers/AppenderAttachableImpl.java
@@ -85,6 +85,9 @@ public class AppenderAttachableImpl implements AppenderAttachable {
return appenders.size();
}
+ /**
+ * Closes all appenders.
+ */
public void close() {
for (Appender appender : appenders.values()) {
appender.close();
[logging-log4j2] 02/04: Sort members and use final.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
commit 3c09d4870aa2e7e4c7d8bc6af9325696fe4f6303
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Jan 13 10:38:50 2022 -0500
Sort members and use final.
---
.../log4j/helpers/AppenderAttachableImpl.java | 44 +++++++++++-----------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/log4j-1.2-api/src/main/java/org/apache/log4j/helpers/AppenderAttachableImpl.java b/log4j-1.2-api/src/main/java/org/apache/log4j/helpers/AppenderAttachableImpl.java
index acb3c53..c1ba8e3 100644
--- a/log4j-1.2-api/src/main/java/org/apache/log4j/helpers/AppenderAttachableImpl.java
+++ b/log4j-1.2-api/src/main/java/org/apache/log4j/helpers/AppenderAttachableImpl.java
@@ -41,6 +41,28 @@ public class AppenderAttachableImpl implements AppenderAttachable {
}
}
+ /**
+ * Calls the <code>doAppend</code> method on all attached appenders.
+ *
+ * @param event The event to log.
+ * @return The number of appenders.
+ */
+ public int appendLoopOnAppenders(LoggingEvent event) {
+ for (Appender appender : appenders.values()) {
+ appender.doAppend(event);
+ }
+ return appenders.size();
+ }
+
+ /**
+ * Closes all appenders.
+ */
+ public void close() {
+ for (Appender appender : appenders.values()) {
+ appender.close();
+ }
+ }
+
@Override
public Enumeration getAllAppenders() {
return Collections.enumeration(appenders.values());
@@ -71,26 +93,4 @@ public class AppenderAttachableImpl implements AppenderAttachable {
public void removeAppender(String name) {
appenders.remove(name);
}
-
- /**
- * Calls the <code>doAppend</code> method on all attached appenders.
- *
- * @param event The event to log.
- * @return The number of appenders.
- */
- public int appendLoopOnAppenders(LoggingEvent event) {
- for (Appender appender : appenders.values()) {
- appender.doAppend(event);
- }
- return appenders.size();
- }
-
- /**
- * Closes all appenders.
- */
- public void close() {
- for (Appender appender : appenders.values()) {
- appender.close();
- }
- }
}
[logging-log4j2] 03/04: Sort members and use final.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
commit ece9980253dfeeea7efb7f25aa00bfc025a84ce6
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Jan 13 10:39:24 2022 -0500
Sort members and use final.
---
.../log4j/helpers/AppenderAttachableImpl.java | 26 +++++++++++-----------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/log4j-1.2-api/src/main/java/org/apache/log4j/helpers/AppenderAttachableImpl.java b/log4j-1.2-api/src/main/java/org/apache/log4j/helpers/AppenderAttachableImpl.java
index c1ba8e3..9837f34 100644
--- a/log4j-1.2-api/src/main/java/org/apache/log4j/helpers/AppenderAttachableImpl.java
+++ b/log4j-1.2-api/src/main/java/org/apache/log4j/helpers/AppenderAttachableImpl.java
@@ -16,16 +16,16 @@
*/
package org.apache.log4j.helpers;
-import org.apache.log4j.Appender;
-import org.apache.log4j.spi.AppenderAttachable;
-import org.apache.log4j.spi.LoggingEvent;
-
import java.util.Collections;
import java.util.Enumeration;
import java.util.Objects;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
+import org.apache.log4j.Appender;
+import org.apache.log4j.spi.AppenderAttachable;
+import org.apache.log4j.spi.LoggingEvent;
+
/**
* Allows Classes to attach Appenders.
*/
@@ -34,7 +34,7 @@ public class AppenderAttachableImpl implements AppenderAttachable {
private final ConcurrentMap<String, Appender> appenders = new ConcurrentHashMap<>();
@Override
- public void addAppender(Appender newAppender) {
+ public void addAppender(final Appender newAppender) {
if (newAppender != null) {
// NullAppender name is null.
appenders.put(Objects.toString(newAppender.getName()), newAppender);
@@ -43,12 +43,12 @@ public class AppenderAttachableImpl implements AppenderAttachable {
/**
* Calls the <code>doAppend</code> method on all attached appenders.
- *
+ *
* @param event The event to log.
* @return The number of appenders.
*/
- public int appendLoopOnAppenders(LoggingEvent event) {
- for (Appender appender : appenders.values()) {
+ public int appendLoopOnAppenders(final LoggingEvent event) {
+ for (final Appender appender : appenders.values()) {
appender.doAppend(event);
}
return appenders.size();
@@ -58,7 +58,7 @@ public class AppenderAttachableImpl implements AppenderAttachable {
* Closes all appenders.
*/
public void close() {
- for (Appender appender : appenders.values()) {
+ for (final Appender appender : appenders.values()) {
appender.close();
}
}
@@ -69,13 +69,13 @@ public class AppenderAttachableImpl implements AppenderAttachable {
}
@Override
- public Appender getAppender(String name) {
+ public Appender getAppender(final String name) {
// No null keys allowed in a CHM.
return name == null ? null : appenders.get(name);
}
@Override
- public boolean isAttached(Appender appender) {
+ public boolean isAttached(final Appender appender) {
return appenders.containsValue(appender);
}
@@ -85,12 +85,12 @@ public class AppenderAttachableImpl implements AppenderAttachable {
}
@Override
- public void removeAppender(Appender appender) {
+ public void removeAppender(final Appender appender) {
appenders.remove(appender.getName(), appender);
}
@Override
- public void removeAppender(String name) {
+ public void removeAppender(final String name) {
appenders.remove(name);
}
}