[jira] Resolved: (WICKET-3288) Remove "id" from Toolbar constructors

["Juergen Donnerstag (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-3288.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-M4

> Remove "id" from Toolbar constructors
> -------------------------------------
>
>                 Key: WICKET-3288
>                 URL: https://issues.apache.org/jira/browse/WICKET-3288
>             Project: Wicket
>          Issue Type: Improvement
>            Reporter: Juergen Donnerstag
>            Assignee: Juergen Donnerstag
>             Fix For: 1.5-M4
>
>
> ooks like you did it in r894726 to fix wicket-2620?
> -igor
> - Hide quoted text -
> On Tue, Dec 21, 2010 at 10:23 PM, Juergen Donnerstag
> <ju...@gmail.com> wrote:
> > I'm not aware I did it. Did I make that change when I made the
> > MarkupFragment changes? Since I don't recall I did for a good reason
> > feel free to change it.
> >
> > -Juergen
> >
> >>On Tue, Dec 21, 2010 at 9:16 PM, Igor Vaynberg <ig...@gmail.com> wrote:
> >> hey, i noticed you made it so that we need to pass ids to toolbars.
> >> this seems a little weird to me, especially since ids are never
> >> referenced in the markup by the user.
> >>
> >> the javadoc also doesnt say anything about them, from the looks of
> >> things it just needs to be a unique string? can we not change it to
> >> how it was and generate the unique strings ourselves, perhaps
> >> toolbar.getsimpleclassname()+some counter to make it unique based on
> >> other toolbars already added?
> >>
> >> just seems weird to me.
> >>
> >> cheers,
> >> -igor
> >>
> >

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.