[jira] [Comment Edited] (MESOS-3184) Scheduler driver accepts (re-)registration message while re-authentication is in progress.

["Guangya Liu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727511#comment-14727511 ] 

Guangya Liu edited comment on MESOS-3184 at 9/15/15 11:06 AM:
--------------------------------------------------------------

[~bmahler] can you please show more detail for this? Based on my understanding, if authentication failure, the master will send FrameworkErrorMessage to framework and framework will register failed.
{code}
if (authorizationError.isSome()) {
    LOG(INFO) << "Refusing subscription of framework"
              << " '" << frameworkInfo.name() << "'"
              << ": " << authorizationError.get().message;

    FrameworkErrorMessage message;
    message.set_message(authorizationError.get().message);
    http.send(message);
    http.close();
    return;
  }
{code}


was (Author: gyliu):
[~bmahler] can you please show more detail for this? Based on my understanding, if authentication failure, the master will send FrameworkErrorMessage to framework and framework will register failed.

if (authorizationError.isSome()) {
    LOG(INFO) << "Refusing subscription of framework"
              << " '" << frameworkInfo.name() << "'"
              << ": " << authorizationError.get().message;

    FrameworkErrorMessage message;
    message.set_message(authorizationError.get().message);
    http.send(message);
    http.close();
    return;
  }

> Scheduler driver accepts (re-)registration message while re-authentication is in progress.
> ------------------------------------------------------------------------------------------
>
>                 Key: MESOS-3184
>                 URL: https://issues.apache.org/jira/browse/MESOS-3184
>             Project: Mesos
>          Issue Type: Bug
>          Components: scheduler driver
>            Reporter: Benjamin Mahler
>            Assignee: Guangya Liu
>
> The scheduler driver currently accepts re-registered when it is re-authenticating with the master. This can occur due a race with the authentication timeout and the master sending a (re-)registration message.
> This is fairly innocuous currently, but if the subsequent re-authentication fails, the driver keeps retrying authentication, but both the master and driver continue to act as though the scheduler is registered.
> The authentication check in _(re-)registerFramework in the master doesn't provide any benefit to this, it is still a race, so this should likely be removed as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)