You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Mehant Baid <ba...@gmail.com> on 2015/02/10 10:00:57 UTC
Re: Review Request 29666: DRILL-1757 Add support for wildcards within
REPEATED_CONTAINS
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29666/#review71766
-----------------------------------------------------------
Code changes look ok. Could you please add a couple of unit tests.
- Mehant Baid
On Jan. 7, 2015, 7:43 p.m., Venkata krishnan Sowrirajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29666/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 7:43 p.m.)
>
>
> Review request for drill and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Support for wildcards with in repeated_contains() is implemented similar to MS SQL contains(). MS SQL contains() documentation http://msdn.microsoft.com/en-us/library/ms187787.aspx
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SimpleRepeatedFunctions.java f7f0e91
>
> Diff: https://reviews.apache.org/r/29666/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkata krishnan Sowrirajan
>
>