You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/02/03 22:08:45 UTC
[GitHub] [netbeans] jlahoda commented on issue #1915: [NETBEANS-3790] -
eliminate all StringBufferInputStream deprecations
jlahoda commented on issue #1915: [NETBEANS-3790] - eliminate all StringBufferInputStream deprecations
URL: https://github.com/apache/netbeans/pull/1915#issuecomment-581642709
I am afraid the replacement of StringBufferInputStream with StringReader does not look quite right - the API client asked for an InputStream, so we should not return them a Reader (they could ask for a Reader if that is what they need). Not completely sure what is the best replacement, but new ByteArrayInputStream(html.getBytes()) might be sensible (will use the platform's encoding, which feels like a sensible/defendable thing to do). There might be some compatibility impact, but probably very small/negligible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists