You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2024/02/26 21:59:00 UTC
[PR] refactor(r): Refactor ArrowArray(Stream) -> R Vector conversion [arrow-nanoarrow]
paleolimbot opened a new pull request, #392:
URL: https://github.com/apache/arrow-nanoarrow/pull/392
The initial version of converting ArrowArray (or stream of them) to R is implemented in C and is difficult to understand. Not only is this difficult because of the verbose C, the dispatch portion is implemented almost completely twice (once for a single array, once for an array stream). It is at a point currently where it is difficult for me, let alone an external contributor, to add features or fix bugs. Time to refactor!
This approach uses C++ classes/virtual method dispatch to handle the different types of vector conversions. This is similar to how the arrow R package does this except the Arrow R package uses the Arrow C++ converter infrastructure/heavy templating to do dispatch. Here we use a `switch()` and eat the per-batch and per-column virtual method call.
Work in progress!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(r): Refactor ArrowArray(Stream) -> R Vector conversion [arrow-nanoarrow]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #392:
URL: https://github.com/apache/arrow-nanoarrow/pull/392#issuecomment-1965597674
## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/392?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `6.61157%` with `113 lines` in your changes are missing coverage. Please review.
> Project coverage is 87.87%. Comparing base [(`e4f0754`)](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/e4f0754e03c84e66b3d93db11c902d99db74fa31?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`619c6fb`)](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/392?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [r/src/vctr\_builder.cc](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ci9zcmMvdmN0cl9idWlsZGVyLmNj) | 0.00% | [113 Missing :warning: ](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #392 +/- ##
==========================================
- Coverage 88.57% 87.87% -0.71%
==========================================
Files 80 81 +1
Lines 14158 14271 +113
==========================================
Hits 12541 12541
- Misses 1617 1730 +113
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/392?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org