You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/31 01:55:55 UTC
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1169: feat: remove the etcd dependency in the service unit test
codecov-io commented on pull request #1169:
URL: https://github.com/apache/apisix-dashboard/pull/1169#issuecomment-752815085
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1169?src=pr&el=h1) Report
> Merging [#1169](https://codecov.io/gh/apache/apisix-dashboard/pull/1169?src=pr&el=desc) (515edad) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45d79b674c2f500d76b76939674b6792201a70bb?el=desc) (45d79b6) will **increase** coverage by `1.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1169?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1169 +/- ##
==========================================
+ Coverage 42.30% 43.56% +1.26%
==========================================
Files 31 31
Lines 1924 1928 +4
==========================================
+ Hits 814 840 +26
+ Misses 1000 983 -17
+ Partials 110 105 -5
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1169?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1169/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `61.40% <0.00%> (-0.87%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1169/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `52.08% <0.00%> (+24.99%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1169?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1169?src=pr&el=footer). Last update [45d79b6...515edad](https://codecov.io/gh/apache/apisix-dashboard/pull/1169?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org