You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Thomas Koch (Created) (JIRA)" <ji...@apache.org> on 2011/10/07 16:07:29 UTC
[jira] [Created] (ZOOKEEPER-1216) Fix more eclipse compiler
warnings, also in Tests
Fix more eclipse compiler warnings, also in Tests
-------------------------------------------------
Key: ZOOKEEPER-1216
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
Project: ZooKeeper
Issue Type: Sub-task
Reporter: Thomas Koch
Assignee: Thomas Koch
Priority: Minor
I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
Warnings are now down to 5! So no excuses to introduce new ones!
Fixed warnings:
- removed unused imports
- removed unused variables / methods
- added missing generics
- added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1216) Fix more eclipse compiler
warnings, also in Tests
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122902#comment-13122902 ]
Hadoop QA commented on ZOOKEEPER-1216:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12498172/ZOOKEEPER-1216.patch
against trunk revision 1180047.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 94 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/613//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/613//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/613//console
This message is automatically generated.
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1216) Fix more eclipse compiler
warnings, also in Tests
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131447#comment-13131447 ]
Hadoop QA commented on ZOOKEEPER-1216:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12499827/ZOOKEEPER-1216.patch
against trunk revision 1185994.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 94 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/634//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/634//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/634//console
This message is automatically generated.
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1216) Fix more eclipse compiler
warnings, also in Tests
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134236#comment-13134236 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1216:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2272/
-----------------------------------------------------------
(Updated 2011-10-24 16:59:05.682064)
Review request for zookeeper.
Summary
-------
ZOOKEEPER-1216 Fix more eclipse compiler warnings, also in Tests
I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
Warnings are now down to 5! So no excuses to introduce new ones!
Fixed warnings:
removed unused imports
removed unused variables / methods
added missing generics
added ignore warnings for calls to deprecated code in tests
This addresses bug ZOOKEEPER-1216.
https://issues.apache.org/jira/browse/ZOOKEEPER-1216
Diffs (updated)
-----
src/java/main/org/apache/zookeeper/JLineZNodeCompletor.java 02b0645
src/java/main/org/apache/zookeeper/Login.java 294801a
src/java/main/org/apache/zookeeper/ZooKeeperMain.java 98784d1
src/java/main/org/apache/zookeeper/server/ByteBufferOutputStream.java a2fcc95
src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java 1511ddb
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java d1ce278
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java c518792
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java e2e24aa
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 13541e8
src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java 575a743
src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java ce239f9
src/java/systest/org/apache/zookeeper/test/system/InstanceContainer.java b22e078
src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 93c51b8
src/java/systest/org/apache/zookeeper/test/system/SimpleClient.java 44f113a
src/java/test/org/apache/zookeeper/TestableZooKeeper.java f8344b6
src/java/test/org/apache/zookeeper/ZKTestCase.java b721cfc
src/java/test/org/apache/zookeeper/server/InvalidSnapshotTest.java 738f665
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 7a5a75b
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 31d32f4
src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java a6a86d0
src/java/test/org/apache/zookeeper/test/ACLRootTest.java 7307cbf
src/java/test/org/apache/zookeeper/test/ClientTest.java e99d8df
src/java/test/org/apache/zookeeper/test/CreateModeTest.java a3b838a
src/java/test/org/apache/zookeeper/test/EventTypeTest.java e6a9826
src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java 81ea12b
src/java/test/org/apache/zookeeper/test/FLETest.java b1b8e82
src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java 1b6ab70
src/java/test/org/apache/zookeeper/test/FollowerResyncConcurrencyTest.java 5a9c759
src/java/test/org/apache/zookeeper/test/KeeperStateTest.java 55dc852
src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java 21fed78
src/java/test/org/apache/zookeeper/test/LETest.java 78d68f0
src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java 2e0dcd9
src/java/test/org/apache/zookeeper/test/ObserverHierarchicalQuorumTest.java 9d373fc
src/java/test/org/apache/zookeeper/test/QuorumQuotaTest.java bef1a33
src/java/test/org/apache/zookeeper/test/QuorumTest.java c9c3b9a
src/java/test/org/apache/zookeeper/test/RepeatStartupTest.java 3421004
src/java/test/org/apache/zookeeper/test/SessionTest.java df9bd54
src/java/test/org/apache/zookeeper/test/WatcherTest.java fc3eccd
src/java/test/org/apache/zookeeper/test/ZooKeeperQuotaTest.java fbf09b3
Diff: https://reviews.apache.org/r/2272/diff
Testing
-------
Thanks,
Thomas
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1216) Fix more eclipse compiler
warnings, also in Tests
Posted by "Thomas Koch (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Koch updated ZOOKEEPER-1216:
-----------------------------------
Attachment: ZOOKEEPER-1216.patch
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1216) Fix more eclipse compiler
warnings, also in Tests
Posted by "Thomas Koch (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Koch updated ZOOKEEPER-1216:
-----------------------------------
Attachment: ZOOKEEPER-1216.patch
Sure I can update the patch. No problem with GIT. :-)
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1216) Fix more eclipse compiler
warnings, also in Tests
Posted by "Thomas Koch (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Koch updated ZOOKEEPER-1216:
-----------------------------------
Attachment: ZOOKEEPER-1216.patch
try the same patch (with whitespace corrections) again.
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1216) Fix more eclipse compiler
warnings, also in Tests
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122917#comment-13122917 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1216:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2272/
-----------------------------------------------------------
(Updated 2011-10-07 16:06:16.659495)
Review request for zookeeper.
Summary
-------
ZOOKEEPER-1216 Fix more eclipse compiler warnings, also in Tests
I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
Warnings are now down to 5! So no excuses to introduce new ones!
Fixed warnings:
removed unused imports
removed unused variables / methods
added missing generics
added ignore warnings for calls to deprecated code in tests
This addresses bug ZOOKEEPER-1216.
https://issues.apache.org/jira/browse/ZOOKEEPER-1216
Diffs (updated)
-----
src/java/main/org/apache/zookeeper/JLineZNodeCompletor.java 02b0645
src/java/main/org/apache/zookeeper/ZooKeeperMain.java 98784d1
src/java/main/org/apache/zookeeper/server/ByteBufferOutputStream.java a2fcc95
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ce58145
src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java 1511ddb
src/java/main/org/apache/zookeeper/server/Request.java 53631f1
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java d1ce278
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java c518792
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java e2e24aa
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 13541e8
src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java 575a743
src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java ce239f9
src/java/systest/org/apache/zookeeper/test/system/InstanceContainer.java b22e078
src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 93c51b8
src/java/systest/org/apache/zookeeper/test/system/SimpleClient.java 44f113a
src/java/test/org/apache/zookeeper/TestableZooKeeper.java f8344b6
src/java/test/org/apache/zookeeper/ZKTestCase.java b721cfc
src/java/test/org/apache/zookeeper/server/InvalidSnapshotTest.java 738f665
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java be29939
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 31d32f4
src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java a6a86d0
src/java/test/org/apache/zookeeper/test/ACLRootTest.java 7307cbf
src/java/test/org/apache/zookeeper/test/ClientTest.java e99d8df
src/java/test/org/apache/zookeeper/test/CreateModeTest.java a3b838a
src/java/test/org/apache/zookeeper/test/EventTypeTest.java e6a9826
src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java 81ea12b
src/java/test/org/apache/zookeeper/test/FLETest.java b1b8e82
src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java 1b6ab70
src/java/test/org/apache/zookeeper/test/FollowerResyncConcurrencyTest.java 5a9c759
src/java/test/org/apache/zookeeper/test/KeeperStateTest.java 55dc852
src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java 21fed78
src/java/test/org/apache/zookeeper/test/LETest.java 78d68f0
src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java 2e0dcd9
src/java/test/org/apache/zookeeper/test/ObserverHierarchicalQuorumTest.java 9d373fc
src/java/test/org/apache/zookeeper/test/QuorumQuotaTest.java bef1a33
src/java/test/org/apache/zookeeper/test/QuorumTest.java c9c3b9a
src/java/test/org/apache/zookeeper/test/RepeatStartupTest.java 3421004
src/java/test/org/apache/zookeeper/test/SessionTest.java df9bd54
src/java/test/org/apache/zookeeper/test/UpgradeTest.java 514404f
src/java/test/org/apache/zookeeper/test/WatcherTest.java fc3eccd
src/java/test/org/apache/zookeeper/test/ZooKeeperQuotaTest.java fbf09b3
Diff: https://reviews.apache.org/r/2272/diff
Testing
-------
Thanks,
Thomas
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1216) Fix more eclipse compiler
warnings, also in Tests
Posted by "Thomas Koch (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Koch updated ZOOKEEPER-1216:
-----------------------------------
Attachment: ZOOKEEPER-1216.patch
* removed accidentally introduced tab characters
* removed three other warnings that leaked in in the meanwhile
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1216) Fix more eclipse compiler
warnings, also in Tests
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122832#comment-13122832 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1216:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2272/
-----------------------------------------------------------
Review request for zookeeper.
Summary
-------
ZOOKEEPER-1216 Fix more eclipse compiler warnings, also in Tests
I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
Warnings are now down to 5! So no excuses to introduce new ones!
Fixed warnings:
removed unused imports
removed unused variables / methods
added missing generics
added ignore warnings for calls to deprecated code in tests
This addresses bug ZOOKEEPER-1216.
https://issues.apache.org/jira/browse/ZOOKEEPER-1216
Diffs
-----
src/java/main/org/apache/zookeeper/ZooKeeperMain.java 98784d1
src/java/main/org/apache/zookeeper/server/ByteBufferOutputStream.java a2fcc95
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ce58145
src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java 1511ddb
src/java/main/org/apache/zookeeper/server/Request.java 53631f1
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java d1ce278
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java c518792
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java e2e24aa
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 13541e8
src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java 575a743
src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java ce239f9
src/java/systest/org/apache/zookeeper/test/system/InstanceContainer.java b22e078
src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 93c51b8
src/java/systest/org/apache/zookeeper/test/system/SimpleClient.java 44f113a
src/java/test/org/apache/zookeeper/TestableZooKeeper.java f8344b6
src/java/test/org/apache/zookeeper/ZKTestCase.java b721cfc
src/java/test/org/apache/zookeeper/server/InvalidSnapshotTest.java 738f665
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java be29939
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 31d32f4
src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java a6a86d0
src/java/test/org/apache/zookeeper/test/ACLRootTest.java 7307cbf
src/java/test/org/apache/zookeeper/test/ClientTest.java e99d8df
src/java/test/org/apache/zookeeper/test/CreateModeTest.java a3b838a
src/java/test/org/apache/zookeeper/test/EventTypeTest.java e6a9826
src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java 81ea12b
src/java/main/org/apache/zookeeper/JLineZNodeCompletor.java 02b0645
src/java/test/org/apache/zookeeper/test/FLETest.java b1b8e82
src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java 1b6ab70
src/java/test/org/apache/zookeeper/test/FollowerResyncConcurrencyTest.java 5a9c759
src/java/test/org/apache/zookeeper/test/KeeperStateTest.java 55dc852
src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java 21fed78
src/java/test/org/apache/zookeeper/test/LETest.java 78d68f0
src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java 2e0dcd9
src/java/test/org/apache/zookeeper/test/ObserverHierarchicalQuorumTest.java 9d373fc
src/java/test/org/apache/zookeeper/test/QuorumQuotaTest.java bef1a33
src/java/test/org/apache/zookeeper/test/QuorumTest.java c9c3b9a
src/java/test/org/apache/zookeeper/test/RepeatStartupTest.java 3421004
src/java/test/org/apache/zookeeper/test/SessionTest.java df9bd54
src/java/test/org/apache/zookeeper/test/UpgradeTest.java 514404f
src/java/test/org/apache/zookeeper/test/WatcherTest.java fc3eccd
src/java/test/org/apache/zookeeper/test/ZooKeeperQuotaTest.java fbf09b3
Diff: https://reviews.apache.org/r/2272/diff
Testing
-------
Thanks,
Thomas
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1216) Fix more eclipse compiler
warnings, also in Tests
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131718#comment-13131718 ]
Patrick Hunt commented on ZOOKEEPER-1216:
-----------------------------------------
You're preaching to the choir dude. ;-)
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1216) Fix more eclipse compiler
warnings, also in Tests
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122848#comment-13122848 ]
Hadoop QA commented on ZOOKEEPER-1216:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12498163/ZOOKEEPER-1216.patch
against trunk revision 1180047.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 94 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/611//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/611//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/611//console
This message is automatically generated.
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1216) Fix more eclipse compiler
warnings, also in Tests
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134934#comment-13134934 ]
Hudson commented on ZOOKEEPER-1216:
-----------------------------------
Integrated in ZooKeeper-trunk #1343 (See [https://builds.apache.org/job/ZooKeeper-trunk/1343/])
ZOOKEEPER-1216. Fix more eclipse compiler warnings, also in Tests (Thomas Koch via phunt)
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1188523
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/JLineZNodeCompletor.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/Login.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ByteBufferOutputStream.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java
* /zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java
* /zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java
* /zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/InstanceContainer.java
* /zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java
* /zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/SimpleClient.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/TestableZooKeeper.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/ZKTestCase.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/InvalidSnapshotTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ACLRootTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CreateModeTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/EventTypeTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLETest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FollowerResyncConcurrencyTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/KeeperStateTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/LETest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ObserverHierarchicalQuorumTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/QuorumQuotaTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/QuorumTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/RepeatStartupTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/SessionTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/WatcherTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ZooKeeperQuotaTest.java
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1216) Fix more eclipse compiler
warnings, also in Tests
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134125#comment-13134125 ]
Hadoop QA commented on ZOOKEEPER-1216:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12500452/ZOOKEEPER-1216.patch
against trunk revision 1188039.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 91 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/644//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/644//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/644//console
This message is automatically generated.
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira