[GitHub] [trafficserver] oknet commented on a change in pull request #7097: Reset stale read.triggered when migrating thread contexts

[GitBox <gi...@apache.org>]

oknet commented on a change in pull request #7097:
URL: https://github.com/apache/trafficserver/pull/7097#discussion_r469018383



##########
File path: iocore/net/UnixNetVConnection.cc
##########
@@ -1188,6 +1188,9 @@ UnixNetVConnection::populate(Connection &con_in, Continuation *c, void *arg)
     return EVENT_ERROR;
   }
 
+  // reset stale read triggered on keep alive connection to prevent getting into read ready list
+  this->read.triggered = 0;

Review comment:
       Refer to the code of `UnixNetVConnection::migrateToCurrentThread()`:
   
   https://github.com/apache/trafficserver/blob/c196db5f0a5b957983351ad51ef360bfc68fbd66/iocore/net/UnixNetVConnection.cc#L1400-L1425
   
   It detach SSL object from SSLNetVC and clear the `sslv->ssl` to `nullptr`.
   A new `SSLNetVC` is created at L1416 and then `UnixNetVConnection::populate()` is called.
   There is no SSL object leaks.
   
   As a new `SSLNetVC`, the `this->read.triggered` must be `0`.
   
   IMO, it is not the root cause of issue #7096 .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org