You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by hequn8128 <gi...@git.apache.org> on 2018/05/26 03:21:03 UTC

[GitHub] flink pull request #6079: [FLINK-8430] [table] Implement stream-stream non-w...

GitHub user hequn8128 opened a pull request:

    https://github.com/apache/flink/pull/6079

    [FLINK-8430] [table] Implement stream-stream non-window full outer join

    
    ## What is the purpose of the change
    
    Support stream-stream non-window full outer join.
    
    
    ## Brief change log
    
      - Add full join process function, including `NonWindowFullJoin` and `NonWindowFullJoinWithNonEquiPredicates`.
      - Add IT/UT/Harness tests for full outer join
      - Change document of stream-stream join.
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - Added integration tests for full join with or without non-equal predicates.
      - Added HarnessTests full join with or without non-equal predicates.
      - Add tests for AccMode generate by full join.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (docs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hequn8128/flink 8430

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6079.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6079
    
----
commit 8b9e8c09aae7d72fae3a6c6bed3327376029a5a2
Author: hequn8128 <ch...@...>
Date:   2018-05-26T02:29:51Z

    [FLINK-8430] [table] Implement stream-stream non-window full outer join

----


---

[GitHub] flink issue #6079: [FLINK-8430] [table] Implement stream-stream non-window f...

Posted by hequn8128 <gi...@git.apache.org>.

Github user hequn8128 commented on the issue:

    https://github.com/apache/flink/pull/6079
  
    @twalthr Thanks a lot for the review and merging. I will take a look at the FLINK-9440 and see if we can do any improvement.


---

[GitHub] flink pull request #6079: [FLINK-8430] [table] Implement stream-stream non-w...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6079


---

[GitHub] flink issue #6079: [FLINK-8430] [table] Implement stream-stream non-window f...

Posted by twalthr <gi...@git.apache.org>.

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/6079
  
    Thank you for this PR @hequn8128. I could not spot any issues with the implementation. I tested it on a query with TPC-H data and compared it with batch results. I will merge this now.
    
    However, I'm wondering if we can further improve the performance of the implementation by the recently added possibility of changing/deleting timers (FLINK-9440). What do you think?


---