You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "exceptionfactory (via GitHub)" <gi...@apache.org> on 2023/06/15 17:56:10 UTC
[GitHub] [nifi] exceptionfactory opened a new pull request, #7384: NIFI-11696 Upgrade Bouncy Castle from 1.71 to 1.74
exceptionfactory opened a new pull request, #7384:
URL: https://github.com/apache/nifi/pull/7384
# Summary
[NIFI-11696](https://issues.apache.org/jira/browse/NIFI-11696) Upgrades Bouncy Castle dependencies from 1.71 to [1.74](https://www.bouncycastle.org/releasenotes.html#r1rv74).
Bouncy Castle 1.74 does not include the defunct SIKE algorithm, which avoids expanding the library size as occurred in versions 1.72 and 1.73.
Additional changes include adjusting `nifi-repository-encryption` classes to use `commons-codec` for hexadecimal decoding instead of Bouncy Castle, and removing exclusions and dependencies for Google Cloud Provider libraries that are not necessary in recent versions.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [X] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #7384: NIFI-11696 Upgrade Bouncy Castle from 1.71 to 1.74
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on code in PR #7384:
URL: https://github.com/apache/nifi/pull/7384#discussion_r1231459842
##########
nifi-commons/nifi-repository-encryption/src/main/java/org/apache/nifi/repository/encryption/AesGcmByteArrayRepositoryEncryptor.java:
##########
@@ -74,9 +73,17 @@ protected byte[] encrypt(final byte[] record, final String recordId, final Strin
try {
final byte[] encryptedRecord = cipher.doFinal(record);
final byte[] serializedMetadata = getMetadata(keyId, cipher.getIV(), encryptedRecord.length);
- return Arrays.concatenate(serializedMetadata, encryptedRecord);
+ return concatenate(serializedMetadata, encryptedRecord);
Review Comment:
Thanks, I missed that commons is an implicit dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #7384: NIFI-11696 Upgrade Bouncy Castle from 1.71 to 1.74
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 closed pull request #7384: NIFI-11696 Upgrade Bouncy Castle from 1.71 to 1.74
URL: https://github.com/apache/nifi/pull/7384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7384: NIFI-11696 Upgrade Bouncy Castle from 1.71 to 1.74
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #7384:
URL: https://github.com/apache/nifi/pull/7384#discussion_r1231428904
##########
nifi-commons/nifi-repository-encryption/src/main/java/org/apache/nifi/repository/encryption/AesGcmByteArrayRepositoryEncryptor.java:
##########
@@ -74,9 +73,17 @@ protected byte[] encrypt(final byte[] record, final String recordId, final Strin
try {
final byte[] encryptedRecord = cipher.doFinal(record);
final byte[] serializedMetadata = getMetadata(keyId, cipher.getIV(), encryptedRecord.length);
- return Arrays.concatenate(serializedMetadata, encryptedRecord);
+ return concatenate(serializedMetadata, encryptedRecord);
Review Comment:
I considered that, but this approach avoids introducing an additional dependency on commons-lang3 for this library, so that's the reason for the manual approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #7384: NIFI-11696 Upgrade Bouncy Castle from 1.71 to 1.74
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on code in PR #7384:
URL: https://github.com/apache/nifi/pull/7384#discussion_r1231418270
##########
nifi-commons/nifi-repository-encryption/src/main/java/org/apache/nifi/repository/encryption/AesGcmByteArrayRepositoryEncryptor.java:
##########
@@ -74,9 +73,17 @@ protected byte[] encrypt(final byte[] record, final String recordId, final Strin
try {
final byte[] encryptedRecord = cipher.doFinal(record);
final byte[] serializedMetadata = getMetadata(keyId, cipher.getIV(), encryptedRecord.length);
- return Arrays.concatenate(serializedMetadata, encryptedRecord);
+ return concatenate(serializedMetadata, encryptedRecord);
Review Comment:
Maybe use `org.apache.commons.lang3.ArrayUtils.addAll()` here, to avoid the need for a helper method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #7384: NIFI-11696 Upgrade Bouncy Castle from 1.71 to 1.74
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #7384:
URL: https://github.com/apache/nifi/pull/7384#issuecomment-1593554591
+1 LGTM will merge when Github Actions finishes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org