You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "MarigWeizhi (via GitHub)" <gi...@apache.org> on 2025/08/02 14:42:11 UTC
[PR] [AMORO-3707] Add group tag to table metrics [amoro]
MarigWeizhi opened a new pull request, #3708:
URL: https://github.com/apache/amoro/pull/3708
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
Close #3707.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
- Add group tag to `AbstractTableMetrics`. This will be applied to `TableOptimizingMetrics`, `TableOrphanFilesCleaningMetrics`, and `TableSummaryMetrics`
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [X] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3707] Add group tag to table metrics [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #3708:
URL: https://github.com/apache/amoro/pull/3708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3707] Add group tag to table metrics [amoro]
Posted by "MarigWeizhi (via GitHub)" <gi...@apache.org>.
MarigWeizhi commented on code in PR #3708:
URL: https://github.com/apache/amoro/pull/3708#discussion_r2249276094
##########
amoro-ams/src/main/java/org/apache/amoro/server/table/TableOrphanFilesCleaningMetrics.java:
##########
@@ -81,7 +81,7 @@ public void registerMetrics(MetricRegistry registry) {
}
public void completeOrphanDataFiles(int expected, int cleaned) {
- expectedOrphanMetadataFilesCount.inc(expected);
+ expectedOrphanDataFilesCount.inc(expected);
Review Comment:
This fixes the issue where the `table_expected_orphan_content_file_cleaning_count` metric was always 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3707] Add group tag to table metrics [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on PR #3708:
URL: https://github.com/apache/amoro/pull/3708#issuecomment-3148950998
Hi, IMO, only the [Self-optimizing metrics](https://amoro.apache.org/docs/latest/metrics/#self-optimizing-metrics) need the group tag information to know where the optimizing process is executed for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org