You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Bukama (via GitHub)" <gi...@apache.org> on 2025/01/26 13:10:07 UTC
[PR] [MNGSITE-446] Properties file gets deleted by default. [maven-site]
Bukama opened a new pull request, #653:
URL: https://github.com/apache/maven-site/pull/653
According to docs of the plugin itself as well of my understanding of the plugin code myself, the clean phase is executed by default after a successful release by default (DefaultReleaseManager).
So I updated this in the docs on site.
Closes #MNGSITE-446.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNGSITE-446] Properties file gets deleted by default. [maven-site]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #653:
URL: https://github.com/apache/maven-site/pull/653#discussion_r1933693236
##########
content/apt/guides/mini/guide-releasing.apt:
##########
@@ -235,12 +235,11 @@ checkpoint.prepared-release=OK
checkpoint.check-in-development-version=OK
-----
- The <release.properties> file is created while preparing the release. After performing the release the file remains within the project root
- directory until the maven user deletes it. The <release.properties> file can be given to any developer within the team and
- by simply excuting the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again.
+ The <release.properties> file is created while preparing the release.
+ By default the file gets deleted after a successful release.
- During the execution of the <<<release:perform>>> goal the entire maven build lifecycle is executed on the project.
- The tagged project source code is extracted, compiled, tested, documented and deployed. An instance of the release artifact is deployed
+ During the execution of the <<<release:perform>>> goal, the entire maven build lifecycle is executed on the project.
Review Comment:
the entire maven build lifecycle is executed on the project. --> Maven executes the project's entire build lifecycle.
(prefer active voice)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNGSITE-446] Properties file gets deleted by default. [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on code in PR #653:
URL: https://github.com/apache/maven-site/pull/653#discussion_r1932427117
##########
content/apt/guides/mini/guide-releasing.apt:
##########
@@ -235,9 +235,9 @@ checkpoint.prepared-release=OK
checkpoint.check-in-development-version=OK
-----
- The <release.properties> file is created while preparing the release. After performing the release the file remains within the project root
- directory until the maven user deletes it. The <release.properties> file can be given to any developer within the team and
- by simply excuting the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again.
+ The <release.properties> file is created while preparing the release. The <release.properties> file can be given to any developer within the team and
+ by simply executing the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again.
+ By default the file gets deleted after a successful release.
Review Comment:
I removed the part about reusing it completely, because it doesn't make sense in my opinion anymore, when the file gets removed by default. I was already thinking about this when creating the creating the PR, but decided against, because I was thinking maybe I'm the only one who thinks so. But your question shows me, that I'm not.
This said, I think that for the documentation we can go with "if you don't use the default, you know what you are doing with your properties-file".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNGSITE-446] Properties file gets deleted by default. [maven-site]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #653:
URL: https://github.com/apache/maven-site/pull/653#discussion_r1931408897
##########
content/apt/guides/mini/guide-releasing.apt:
##########
@@ -235,9 +235,9 @@ checkpoint.prepared-release=OK
checkpoint.check-in-development-version=OK
-----
- The <release.properties> file is created while preparing the release. After performing the release the file remains within the project root
- directory until the maven user deletes it. The <release.properties> file can be given to any developer within the team and
- by simply excuting the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again.
+ The <release.properties> file is created while preparing the release. The <release.properties> file can be given to any developer within the team and
Review Comment:
Something like "Any developer can execute the <<<release:perform>>> goal with the release.properties file to deploy a new instance of the project artifact."
##########
content/apt/guides/mini/guide-releasing.apt:
##########
@@ -235,9 +235,9 @@ checkpoint.prepared-release=OK
checkpoint.check-in-development-version=OK
-----
- The <release.properties> file is created while preparing the release. After performing the release the file remains within the project root
- directory until the maven user deletes it. The <release.properties> file can be given to any developer within the team and
- by simply excuting the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again.
+ The <release.properties> file is created while preparing the release. The <release.properties> file can be given to any developer within the team and
+ by simply executing the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again.
+ By default the file gets deleted after a successful release.
During the execution of the <<<release:perform>>> goal the entire maven build lifecycle is executed on the project.
Review Comment:
comma after goal
##########
content/apt/guides/mini/guide-releasing.apt:
##########
@@ -235,9 +235,9 @@ checkpoint.prepared-release=OK
checkpoint.check-in-development-version=OK
-----
- The <release.properties> file is created while preparing the release. After performing the release the file remains within the project root
- directory until the maven user deletes it. The <release.properties> file can be given to any developer within the team and
- by simply excuting the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again.
+ The <release.properties> file is created while preparing the release. The <release.properties> file can be given to any developer within the team and
+ by simply executing the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again.
+ By default the file gets deleted after a successful release.
During the execution of the <<<release:perform>>> goal the entire maven build lifecycle is executed on the project.
The tagged project source code is extracted, compiled, tested, documented and deployed. An instance of the release artifact is deployed
Review Comment:
comma after documented
##########
content/apt/guides/mini/guide-releasing.apt:
##########
@@ -235,9 +235,9 @@ checkpoint.prepared-release=OK
checkpoint.check-in-development-version=OK
-----
- The <release.properties> file is created while preparing the release. After performing the release the file remains within the project root
- directory until the maven user deletes it. The <release.properties> file can be given to any developer within the team and
- by simply excuting the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again.
+ The <release.properties> file is created while preparing the release. The <release.properties> file can be given to any developer within the team and
+ by simply executing the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again.
+ By default the file gets deleted after a successful release.
Review Comment:
so how is it reused then? I'm missing something here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNGSITE-446] Properties file gets deleted by default. [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on code in PR #653:
URL: https://github.com/apache/maven-site/pull/653#discussion_r1934528823
##########
content/apt/guides/mini/guide-releasing.apt:
##########
@@ -235,12 +235,11 @@ checkpoint.prepared-release=OK
checkpoint.check-in-development-version=OK
-----
- The <release.properties> file is created while preparing the release. After performing the release the file remains within the project root
- directory until the maven user deletes it. The <release.properties> file can be given to any developer within the team and
- by simply excuting the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again.
+ The <release.properties> file is created while preparing the release.
+ By default the file gets deleted after a successful release.
- During the execution of the <<<release:perform>>> goal the entire maven build lifecycle is executed on the project.
- The tagged project source code is extracted, compiled, tested, documented and deployed. An instance of the release artifact is deployed
+ During the execution of the <<<release:perform>>> goal, the entire maven build lifecycle is executed on the project.
Review Comment:
Updated (, rebased and spotless)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNGSITE-446] Properties file gets deleted by default. [maven-site]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #653:
URL: https://github.com/apache/maven-site/pull/653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNGSITE-446] Properties file gets deleted by default. [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on code in PR #653:
URL: https://github.com/apache/maven-site/pull/653#discussion_r1932420928
##########
content/apt/guides/mini/guide-releasing.apt:
##########
@@ -235,9 +235,9 @@ checkpoint.prepared-release=OK
checkpoint.check-in-development-version=OK
-----
- The <release.properties> file is created while preparing the release. After performing the release the file remains within the project root
- directory until the maven user deletes it. The <release.properties> file can be given to any developer within the team and
- by simply excuting the <<<release:perform>>> goal can create and deploy a new instance of the project artifact time and again.
+ The <release.properties> file is created while preparing the release. The <release.properties> file can be given to any developer within the team and
Review Comment:
Sounds better, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org