[GitHub] [geode] yozaner1324 opened pull request #4601: Feature/refactor without transportbuilder

["yozaner1324 (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4601 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #4601: GEODE-7715: Introduce Transport and Config interfaces to ClusterManagementServiceBuilder

["jinmeiliao (GitHub)" <gi...@apache.org>]

shouldn't this be just "build()"?

[ Full content available at: https://github.com/apache/geode/pull/4601 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] yozaner1324 commented on pull request #4601: GEODE-7715: Introduce Transport and Config interfaces to ClusterManagementServiceBuilder

["yozaner1324 (GitHub)" <gi...@apache.org>]

Done

[ Full content available at: https://github.com/apache/geode/pull/4601 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #4601: GEODE-7715: Introduce Transport and Config interfaces to ClusterManagementServiceBuilder

["demery-pivotal (GitHub)" <gi...@apache.org>]

These tests seem to verify only that the builder doesn't throw. Surely there's something more test here.

[ Full content available at: https://github.com/apache/geode/pull/4601 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] yozaner1324 commented on pull request #4601: GEODE-7715: Introduce Transport and Config interfaces to ClusterManagementServiceBuilder

["yozaner1324 (GitHub)" <gi...@apache.org>]

You're right, that file had several errors that I didn't catch because it wasn't being compiled. I fixed this and the other problems.

[ Full content available at: https://github.com/apache/geode/pull/4601 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] yozaner1324 commented on pull request #4601: GEODE-7715: Introduce Transport and Config interfaces to ClusterManagementServiceBuilder

["yozaner1324 (GitHub)" <gi...@apache.org>]

We can't do that because of type erasure. To call that method we would have to do something like `ClusterManagementListOperationsResult<V>.class` which isn't allowed.

[ Full content available at: https://github.com/apache/geode/pull/4601 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org