You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Michael Drzal (Created) (JIRA)" <ji...@apache.org> on 2012/03/21 14:21:41 UTC
[jira] [Created] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Add the ability to pass additional information for slow query logging
---------------------------------------------------------------------
Key: HBASE-5609
URL: https://issues.apache.org/jira/browse/HBASE-5609
Project: HBase
Issue Type: New Feature
Components: client, ipc
Reporter: Michael Drzal
Assignee: Michael Drzal
Priority: Minor
HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Michael Drzal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286790#comment-13286790 ]
Michael Drzal commented on HBASE-5609:
--------------------------------------
Yep, just looked at Jesse's comments. I think the new patch takes care of them. I'll verify with him.
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Attachments: HBASE-5609-v2.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5609:
-------------------------
Fix Version/s: (was: 0.96.0)
0.94.1
Applied to 0.94 too at Lars' request.
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Fix For: 0.94.1
>
> Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609-v4-094.txt, HBASE-5609-v4.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289579#comment-13289579 ]
Lars Hofhansl commented on HBASE-5609:
--------------------------------------
Let's put this into 0.94 as well.
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609-v4.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Michael Drzal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Drzal updated HBASE-5609:
---------------------------------
Attachment: HBASE-5609-v3.patch
Added a couple of whitespace fixes
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289663#comment-13289663 ]
Hudson commented on HBASE-5609:
-------------------------------
Integrated in HBase-0.94 #249 (See [https://builds.apache.org/job/HBase-0.94/249/])
HBASE-5609 Add the ability to pass additional information for slow query logging (Revision 1346509)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/Get.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/OperationWithAttributes.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/Scan.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestAttributes.java
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Fix For: 0.94.1
>
> Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609-v4-094.txt, HBASE-5609-v4.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289704#comment-13289704 ]
Lars Hofhansl commented on HBASE-5609:
--------------------------------------
Awesome. Thanks Stack. Was gonna do the commit, but you were faster. :)
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Fix For: 0.94.1
>
> Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609-v4-094.txt, HBASE-5609-v4.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234386#comment-13234386 ]
stack commented on HBASE-5609:
------------------------------
Sounds good in theory Michael. Do you have an explicit example of something you'd log that would help debugging slow queries? Good stuff.
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289841#comment-13289841 ]
Hudson commented on HBASE-5609:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #42 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/42/])
HBASE-5609 Add the ability to pass additional information for slow query logging (Revision 1346459)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Get.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/OperationWithAttributes.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Scan.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAttributes.java
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Fix For: 0.94.1
>
> Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609-v4-094.txt, HBASE-5609-v4.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5609:
-------------------------
Attachment: HBASE-5609-v4.patch
Here is what I committed (minor formatting change adding spaces around parens). Thanks for the patch Michael. Applied to trunk.
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609-v4.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Michael Drzal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Drzal updated HBASE-5609:
---------------------------------
Attachment: HBASE-5609.patch
First shot at this
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Attachments: HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Michael Drzal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Drzal updated HBASE-5609:
---------------------------------
Attachment: HBASE-5609-v2.patch
Reworked version of the patch based on Stack's comments.
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Attachments: HBASE-5609-v2.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Michael Drzal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286651#comment-13286651 ]
Michael Drzal commented on HBASE-5609:
--------------------------------------
@stack that seems reasonable. I'll change it to only add if not null.
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Attachments: HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Michael Drzal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289465#comment-13289465 ]
Michael Drzal commented on HBASE-5609:
--------------------------------------
Created HBASE-6163 and linked it back to this for the toMap work.
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234995#comment-13234995 ]
Lars Hofhansl commented on HBASE-5609:
--------------------------------------
We use something like this at Salesforce to track certain slow SQL queries back to the part of the application that issued them.
For this we'd log some module identifier here.
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285945#comment-13285945 ]
stack commented on HBASE-5609:
------------------------------
@Michael Looks good. Most of time id will be null though, right? In that case, should we skip setting id on a Put, Get, Scan? Otherwise looks good to me.
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Attachments: HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289487#comment-13289487 ]
Hadoop QA commented on HBASE-5609:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530961/HBASE-5609-v3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2106//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2106//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2106//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2106//console
This message is automatically generated.
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286785#comment-13286785 ]
stack commented on HBASE-5609:
------------------------------
Thanks Michael for the update. Did you see Jeses' comments up on review board?
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Attachments: HBASE-5609-v2.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289798#comment-13289798 ]
Hudson commented on HBASE-5609:
-------------------------------
Integrated in HBase-0.94-security #35 (See [https://builds.apache.org/job/HBase-0.94-security/35/])
HBASE-5609 Add the ability to pass additional information for slow query logging (Revision 1346509)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/Get.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/OperationWithAttributes.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/Scan.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestAttributes.java
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Fix For: 0.94.1
>
> Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609-v4-094.txt, HBASE-5609-v4.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287636#comment-13287636 ]
Jesse Yates commented on HBASE-5609:
------------------------------------
I'm +1 on Drz's latest patch on RB. Would love to see another patch to abstract out the commonality in toMap(), but that can go in another ticket.
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Attachments: HBASE-5609-v2.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5609:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609-v4.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289535#comment-13289535 ]
Hudson commented on HBASE-5609:
-------------------------------
Integrated in HBase-TRUNK #2989 (See [https://builds.apache.org/job/HBase-TRUNK/2989/])
HBASE-5609 Add the ability to pass additional information for slow query logging (Revision 1346459)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Get.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/OperationWithAttributes.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Scan.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAttributes.java
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609-v4.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Michael Drzal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Drzal updated HBASE-5609:
---------------------------------
Release Note: Added the ability to add identifiers to client operations. These identifiers will be output with slow query logging. The could be used to identify the piece of code that initiated the operation. This could be anything from a module name to a class.method with a line number.
Status: Patch Available (was: Open)
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl closed HBASE-5609.
--------------------------------
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: Client, IPC/RPC
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Fix For: 0.94.1
>
> Attachments: HBASE-5609.patch, HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609-v4-094.txt, HBASE-5609-v4.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5609) Add the ability to pass additional
information for slow query logging
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5609:
-------------------------
Attachment: HBASE-5609-v4-094.txt
What I applied to 0.94.
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
> Key: HBASE-5609
> URL: https://issues.apache.org/jira/browse/HBASE-5609
> Project: HBase
> Issue Type: New Feature
> Components: client, ipc
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Fix For: 0.94.1
>
> Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, HBASE-5609-v4-094.txt, HBASE-5609-v4.patch, HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned too much data or ran for too long. There is some information written as a fingerprint that can be used to tell what table/column families/... are affected. I would like to extend this functionality to allow the client to insert an identifier into the operation that gets output in the log. The idea behind this would be that if there were N places in the client application that touched a given table in a certain way, you could quickly narrow things down by inserting a className:functionName or similar identifier. I'm fully willing to go back on this if people think that it isn't a problem in real life and it would just add complexity to the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira