You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/24 19:25:13 UTC
[GitHub] [incubator-apisix] shenal opened a new pull request #1769: Add etcd auth support
shenal opened a new pull request #1769:
URL: https://github.com/apache/incubator-apisix/pull/1769
### Summary
This PR adds etcd auth support
### Full changelog
* Added etcd auth placeholder configs
* Added etcd tests with auth pass & auth fail
### Issues resolved
Fix #1767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] shenal commented on a change in pull request #1769: Add etcd auth support
Posted by GitBox <gi...@apache.org>.
shenal commented on a change in pull request #1769:
URL: https://github.com/apache/incubator-apisix/pull/1769#discussion_r445302182
##########
File path: t/core/etcd-auth-fail.t
##########
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+BEGIN {
+ $ENV{"ETCD_ENABLE_AUTH"} = "false"
+}
+
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+log_level("info");
+
+# Authentication is enabled at etcd and credentials are set
+system('etcdctl --endpoints="http://127.0.0.1:2376" -u root:5tHkHhYkjr6cQY user add root:5tHkHhYkjr6cQY');
Review comment:
Thanks for the pointer @moonming . When I tested this code in my local etcdctl was installed along with etcd. I will check your suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] shenal commented on a change in pull request #1769: Add etcd auth support
Posted by GitBox <gi...@apache.org>.
shenal commented on a change in pull request #1769:
URL: https://github.com/apache/incubator-apisix/pull/1769#discussion_r445924622
##########
File path: t/core/etcd.t
##########
@@ -0,0 +1,59 @@
+#
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] shenal commented on a change in pull request #1769: Add etcd auth support, upgrade travis runner
Posted by GitBox <gi...@apache.org>.
shenal commented on a change in pull request #1769:
URL: https://github.com/apache/incubator-apisix/pull/1769#discussion_r445659863
##########
File path: t/core/etcd-auth-fail.t
##########
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+BEGIN {
+ $ENV{"ETCD_ENABLE_AUTH"} = "false"
+}
+
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+log_level("info");
+
+# Authentication is enabled at etcd and credentials are set
+system('etcdctl --endpoints="http://127.0.0.1:2376" -u root:5tHkHhYkjr6cQY user add root:5tHkHhYkjr6cQY');
Review comment:
This issue has been resolved. Tests are passing now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] shenal commented on pull request #1769: Add etcd auth support
Posted by GitBox <gi...@apache.org>.
shenal commented on pull request #1769:
URL: https://github.com/apache/incubator-apisix/pull/1769#issuecomment-649219267
@membphis , @moonming Current travis runners use xenial(16.04) are you ok if I use bionic(18.04)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on pull request #1769: Add etcd auth support, upgrade travis runner
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1769:
URL: https://github.com/apache/incubator-apisix/pull/1769#issuecomment-649592817
> @membphis , @moonming Current Travis runners use xenial(16.04) are you ok if I use bionic(18.04)
we can do this in a new PR. one PR does one thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on a change in pull request #1769: Add etcd auth support
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1769:
URL: https://github.com/apache/incubator-apisix/pull/1769#discussion_r445917978
##########
File path: t/core/etcd.t
##########
@@ -0,0 +1,59 @@
+#
Review comment:
`t/core/etcd.t` -> `t/core/etcd-auth.t`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on a change in pull request #1769: Add etcd auth support, upgrade travis runner
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1769:
URL: https://github.com/apache/incubator-apisix/pull/1769#discussion_r445610185
##########
File path: t/core/etcd-auth-fail.t
##########
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+BEGIN {
+ $ENV{"ETCD_ENABLE_AUTH"} = "false"
+}
+
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+log_level("info");
+
+# Authentication is enabled at etcd and credentials are set
+system('etcdctl --endpoints="http://127.0.0.1:2376" -u root:5tHkHhYkjr6cQY user add root:5tHkHhYkjr6cQY');
Review comment:
> How about call etcd auth method in Lua land?
`lua-resty-etcd` does not support the manager API now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on pull request #1769: Add etcd auth support
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1769:
URL: https://github.com/apache/incubator-apisix/pull/1769#issuecomment-649145681
nice PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming commented on a change in pull request #1769: Add etcd auth support
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1769:
URL: https://github.com/apache/incubator-apisix/pull/1769#discussion_r445293489
##########
File path: t/core/etcd-auth-fail.t
##########
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+BEGIN {
+ $ENV{"ETCD_ENABLE_AUTH"} = "false"
+}
+
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+log_level("info");
+
+# Authentication is enabled at etcd and credentials are set
+system('etcdctl --endpoints="http://127.0.0.1:2376" -u root:5tHkHhYkjr6cQY user add root:5tHkHhYkjr6cQY');
Review comment:
the APISIX node need install `etcdctl` first and run this command, then can enable etcd auth?
How about call etcd auth method in Lua land?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on pull request #1769: Add etcd auth support
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1769:
URL: https://github.com/apache/incubator-apisix/pull/1769#issuecomment-650083537
@shenal merged, many thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis merged pull request #1769: Add etcd auth support
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1769:
URL: https://github.com/apache/incubator-apisix/pull/1769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org