You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/19 18:18:51 UTC
[GitHub] [pulsar] AnonHxy commented on a diff in pull request #18107: [improve][client] Support MAX_ACK_GROUP_SIZE configurable
AnonHxy commented on code in PR #18107:
URL: https://github.com/apache/pulsar/pull/18107#discussion_r999792234
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -378,6 +378,17 @@
*/
ConsumerBuilder<T> acknowledgmentGroupTime(long delay, TimeUnit unit);
+ /**
+ * Group the consumer acknowledgments for size.
+ *
+ * <p>By default, the consumer uses 1000 messages to send out the acknowledgments to the broker.
+ *
+ * @param messageNum
+ *
+ * @return the consumer builder instance
+ */
+ ConsumerBuilder<T> acknowledgmentGroupSize(int messageNum);
Review Comment:
How about `maxAcknowledgmentGroupSize(int maxAckGroupSize)`
First we should clarify that it is a max size in the method name, and then it's better keep the params consistent with the field to be set. WDYT:)
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -378,6 +378,17 @@
*/
ConsumerBuilder<T> acknowledgmentGroupTime(long delay, TimeUnit unit);
+ /**
+ * Group the consumer acknowledgments for size.
+ *
+ * <p>By default, the consumer uses 1000 messages to send out the acknowledgments to the broker.
Review Comment:
```suggestion
* <p>By default, the consumer uses at most 1000 messages to send out the acknowledgments to the broker.
```
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -378,6 +378,17 @@
*/
ConsumerBuilder<T> acknowledgmentGroupTime(long delay, TimeUnit unit);
+ /**
+ * Group the consumer acknowledgments for size.
Review Comment:
```suggestion
* Group the consumer acknowledgments for the max size.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org