You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/20 04:45:50 UTC
[GitHub] [arrow] domoritz opened a new pull request #10362: ARROW-12833: [JS] Construct perf data in JS
domoritz opened a new pull request #10362:
URL: https://github.com/apache/arrow/pull/10362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] trxcllnt commented on pull request #10362: ARROW-12833: [JS] Construct perf data in JS
Posted by GitBox <gi...@apache.org>.
trxcllnt commented on pull request #10362:
URL: https://github.com/apache/arrow/pull/10362#issuecomment-846055027
Does this include (or supersede) https://github.com/apache/arrow/pull/10361?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10362: ARROW-12833: [JS] Construct perf data in JS
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10362:
URL: https://github.com/apache/arrow/pull/10362#issuecomment-846456726
@domoritz Could you rebase on master to merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] trxcllnt commented on a change in pull request #10362: ARROW-12833: [JS] Construct perf data in JS
Posted by GitBox <gi...@apache.org>.
trxcllnt commented on a change in pull request #10362:
URL: https://github.com/apache/arrow/pull/10362#discussion_r636223843
##########
File path: js/perf/config.ts
##########
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import * as Arrow from '../src/Arrow.dom';
+
+console.time('Prepare Data');
+
+const LENGTH = 100000;
+const NUM_BATCHES = 10;
+
+const values = Arrow.Utf8Vector.from(['Charlottesville', 'New York', 'San Francisco', 'Seattle', 'Terre Haute', 'Washington, DC']);
+
Review comment:
```suggestion
const originType = new Arrow.Dictionary(values.type, new Arrow.Int8, 0, false);
const destinationType = new Arrow.Dictionary(values.type, new Arrow.Int8, 0, false);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10362: ARROW-12833: [JS] Construct perf data in JS
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10362:
URL: https://github.com/apache/arrow/pull/10362#issuecomment-846622307
Thanks.
I'll merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on a change in pull request #10362: ARROW-12833: [JS] Construct perf data in JS
Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #10362:
URL: https://github.com/apache/arrow/pull/10362#discussion_r636244842
##########
File path: js/perf/config.ts
##########
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import * as Arrow from '../src/Arrow.dom';
+
+console.time('Prepare Data');
+
+const LENGTH = 100000;
+const NUM_BATCHES = 10;
+
+const values = Arrow.Utf8Vector.from(['Charlottesville', 'New York', 'San Francisco', 'Seattle', 'Terre Haute', 'Washington, DC']);
+
+const batches = Array.from({length: NUM_BATCHES}).map(() => {
+ const lat = Float32Array.from(
+ { length: LENGTH },
+ () => ((Math.random() - 0.5) * 2 * 90));
+ const lng = Float32Array.from(
+ { length: LENGTH },
+ () => ((Math.random() - 0.5) * 2 * 90));
+
+ const origin = Uint8Array.from(
+ { length: LENGTH },
+ () => (Math.random() * 6));
+ const destination = Uint8Array.from(
+ { length: LENGTH },
+ () => (Math.random() * 6));
+
+ return Arrow.RecordBatch.new({
+ 'lat': Arrow.Float32Vector.from(lat),
+ 'lng': Arrow.Float32Vector.from(lng),
+ 'origin': Arrow.DictionaryVector.from(values, new Arrow.Int8(), origin),
+ 'destination': Arrow.DictionaryVector.from(values, new Arrow.Int8(), destination),
Review comment:
That works. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #10362: ARROW-12833: [JS] Construct perf data in JS
Posted by GitBox <gi...@apache.org>.
kou closed pull request #10362:
URL: https://github.com/apache/arrow/pull/10362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] trxcllnt commented on a change in pull request #10362: ARROW-12833: [JS] Construct perf data in JS
Posted by GitBox <gi...@apache.org>.
trxcllnt commented on a change in pull request #10362:
URL: https://github.com/apache/arrow/pull/10362#discussion_r636224100
##########
File path: js/perf/config.ts
##########
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import * as Arrow from '../src/Arrow.dom';
+
+console.time('Prepare Data');
+
+const LENGTH = 100000;
+const NUM_BATCHES = 10;
+
+const values = Arrow.Utf8Vector.from(['Charlottesville', 'New York', 'San Francisco', 'Seattle', 'Terre Haute', 'Washington, DC']);
+
+const batches = Array.from({length: NUM_BATCHES}).map(() => {
+ const lat = Float32Array.from(
+ { length: LENGTH },
+ () => ((Math.random() - 0.5) * 2 * 90));
+ const lng = Float32Array.from(
+ { length: LENGTH },
+ () => ((Math.random() - 0.5) * 2 * 90));
+
+ const origin = Uint8Array.from(
+ { length: LENGTH },
+ () => (Math.random() * 6));
+ const destination = Uint8Array.from(
+ { length: LENGTH },
+ () => (Math.random() * 6));
+
+ return Arrow.RecordBatch.new({
+ 'lat': Arrow.Float32Vector.from(lat),
+ 'lng': Arrow.Float32Vector.from(lng),
+ 'origin': Arrow.DictionaryVector.from(values, new Arrow.Int8(), origin),
+ 'destination': Arrow.DictionaryVector.from(values, new Arrow.Int8(), destination),
Review comment:
```suggestion
'origin': Arrow.Vector.new(Arrow.Data.Dictionary(originType, 0, origin.length, 0, null, origin, values)),
'destination': Arrow.Vector.new(Arrow.Data.Dictionary(destinationType, 0, destination.length, 0, null, destination, values)),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on a change in pull request #10362: ARROW-12833: [JS] Construct perf data in JS
Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #10362:
URL: https://github.com/apache/arrow/pull/10362#discussion_r637468188
##########
File path: js/src/io/interfaces.ts
##########
@@ -174,6 +174,6 @@ export class AsyncQueue<TReadable = Uint8Array, TWritable = TReadable> extends R
if (this._closedPromiseResolve) {
return true;
}
- throw new Error(`${this} is closed`);
+ throw new Error(`AsyncQueue is closed`);
Review comment:
Without this, I got an error like "could not stringily non primitive".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10362: ARROW-12833: [JS] Construct perf data in JS
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10362:
URL: https://github.com/apache/arrow/pull/10362#issuecomment-844688019
https://issues.apache.org/jira/browse/ARROW-12833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #10362: ARROW-12833: [JS] Construct perf data in JS
Posted by GitBox <gi...@apache.org>.
domoritz commented on pull request #10362:
URL: https://github.com/apache/arrow/pull/10362#issuecomment-846482466
@kou done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #10362: ARROW-12833: [JS] Construct perf data in JS
Posted by GitBox <gi...@apache.org>.
domoritz commented on pull request #10362:
URL: https://github.com/apache/arrow/pull/10362#issuecomment-846056960
Ahh, yes, forgot to note. This should be merged after #10361.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org