You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by qingwen220 <gi...@git.apache.org> on 2016/07/29 12:45:42 UTC
[GitHub] incubator-eagle pull request #287: EAGLE-404: Updating configuration format ...
GitHub user qingwen220 opened a pull request:
https://github.com/apache/incubator-eagle/pull/287
EAGLE-404: Updating configuration format check at the front end
https://issues.apache.org/jira/browse/EAGLE-404
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/qingwen220/incubator-eagle EAGLE-404
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/287.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #287
----
commit b90448983cf43d71961ec52797802b2bf3d4ecea
Author: Zhao, Qingwen <qi...@ebay.com>
Date: 2016-07-29T12:43:44Z
Updating configuration format check at the front end
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #287: EAGLE-404: Updating configuration format ...
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 closed the pull request at:
https://github.com/apache/incubator-eagle/pull/287
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #287: EAGLE-404: Updating configuration format check a...
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the issue:
https://github.com/apache/incubator-eagle/pull/287
@yonzhang this fix is only for v0.4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #287: EAGLE-404: Updating configuration format check a...
Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the issue:
https://github.com/apache/incubator-eagle/pull/287
this PR is for 0.4, but 0.4 is already cut, do you want to submit another PR for develop branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #287: EAGLE-404: Updating configuration format check a...
Posted by zombieJ <gi...@git.apache.org>.
Github user zombieJ commented on the issue:
https://github.com/apache/incubator-eagle/pull/287
LGTM
ps: Is there any other name format should be considered? Or that's OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #287: EAGLE-404: Updating configuration format check a...
Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the issue:
https://github.com/apache/incubator-eagle/pull/287
ok, thanks, please merge it soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #287: EAGLE-404: Updating configuration format check a...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/287
Merged, pls. close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #287: EAGLE-404: Updating configuration format check a...
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the issue:
https://github.com/apache/incubator-eagle/pull/287
I don't know other cases right now.
At present, the combination of letters(a-z or A-Z), digits and dot are not enough. '-' is a must to have.
For example, hdfs ha configuration
dfs.namenode.rpc-address.xxx=yyy
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---