You are viewing a plain text version of this content. The canonical link for it is here.

Posted to derby-dev@db.apache.org by "Dyre Tjeldvoll (JIRA)" <ji...@apache.org> on 2008/04/11 17:48:04 UTC

[jira] Updated: (DERBY-3227) Remove final from all getConnection() methods in EmbeddedDataSource

     [ https://issues.apache.org/jira/browse/DERBY-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dyre Tjeldvoll updated DERBY-3227:
----------------------------------

    Attachment: derby-3227.diff

I have attached a patch which implements Aaron's suggestion. We can always debate whether it is the "the right thing to do" but as long as other jdbc drivers (including our own ClientDriver) allow this, I think it is reasonable for EmbeddedDataSource to do so as well.

> Remove final from all getConnection() methods in EmbeddedDataSource
> -------------------------------------------------------------------
>
>                 Key: DERBY-3227
>                 URL: https://issues.apache.org/jira/browse/DERBY-3227
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 10.3.1.4
>            Reporter: Aaron Digulla
>            Priority: Minor
>         Attachments: derby-3227.diff
>
>
> The final modifier makes it impossible to wrap Derby connections in P6Spy, for example.
> The network ClientDataSource doesn't use final, either.
> Patch: Replace "public final Connection" with "public Connection" two times.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.