You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2008/06/07 02:08:44 UTC

[jira] Created: (HADOOP-3513) Improve NNThroughputBenchmark log messages.

Improve NNThroughputBenchmark log messages.
-------------------------------------------

                 Key: HADOOP-3513
                 URL: https://issues.apache.org/jira/browse/HADOOP-3513
             Project: Hadoop Core
          Issue Type: Bug
          Components: test
    Affects Versions: 0.17.0
            Reporter: Konstantin Shvachko
            Assignee: Konstantin Shvachko
             Fix For: 0.18.0


The block report benchmark should not print return values of heartbeats.
It should also leave safe mode before creating files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3513) Improve NNThroughputBenchmark log messages.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603740#action_12603740 ] 

Konstantin Shvachko commented on HADOOP-3513:
---------------------------------------------

Filed HADOOP-3520 for the TestDFSUpgradeFromImage failure.

> Improve NNThroughputBenchmark log messages.
> -------------------------------------------
>
>                 Key: HADOOP-3513
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3513
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.17.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.18.0
>
>         Attachments: NNThroughputBenchmarkLogMsg.patch
>
>
> The block report benchmark should not print return values of heartbeats.
> It should also leave safe mode before creating files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3513) Improve NNThroughputBenchmark log messages.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HADOOP-3513:
----------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this.

> Improve NNThroughputBenchmark log messages.
> -------------------------------------------
>
>                 Key: HADOOP-3513
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3513
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.17.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.18.0
>
>         Attachments: NNThroughputBenchmarkLogMsg.patch
>
>
> The block report benchmark should not print return values of heartbeats.
> It should also leave safe mode before creating files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3513) Improve NNThroughputBenchmark log messages.

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3513:
-------------------------------------

    Hadoop Flags: [Reviewed]

+1 Looks good

> Improve NNThroughputBenchmark log messages.
> -------------------------------------------
>
>                 Key: HADOOP-3513
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3513
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.17.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.18.0
>
>         Attachments: NNThroughputBenchmarkLogMsg.patch
>
>
> The block report benchmark should not print return values of heartbeats.
> It should also leave safe mode before creating files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3513) Improve NNThroughputBenchmark log messages.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603283#action_12603283 ] 

Hadoop QA commented on HADOOP-3513:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12383613/NNThroughputBenchmarkLogMsg.patch
  against trunk revision 664226.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2621/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2621/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2621/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2621/console

This message is automatically generated.

> Improve NNThroughputBenchmark log messages.
> -------------------------------------------
>
>                 Key: HADOOP-3513
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3513
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.17.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>         Attachments: NNThroughputBenchmarkLogMsg.patch
>
>
> The block report benchmark should not print return values of heartbeats.
> It should also leave safe mode before creating files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3513) Improve NNThroughputBenchmark log messages.

Posted by "Mukund Madhugiri (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mukund Madhugiri updated HADOOP-3513:
-------------------------------------

    Fix Version/s:     (was: 0.18.0)

> Improve NNThroughputBenchmark log messages.
> -------------------------------------------
>
>                 Key: HADOOP-3513
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3513
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.17.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>         Attachments: NNThroughputBenchmarkLogMsg.patch
>
>
> The block report benchmark should not print return values of heartbeats.
> It should also leave safe mode before creating files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3513) Improve NNThroughputBenchmark log messages.

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603418#action_12603418 ] 

Owen O'Malley commented on HADOOP-3513:
---------------------------------------

Wouldn't it better to wait until the namenode leaves safemode rather than forcing it out?

> Improve NNThroughputBenchmark log messages.
> -------------------------------------------
>
>                 Key: HADOOP-3513
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3513
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.17.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>         Attachments: NNThroughputBenchmarkLogMsg.patch
>
>
> The block report benchmark should not print return values of heartbeats.
> It should also leave safe mode before creating files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3513) Improve NNThroughputBenchmark log messages.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605434#action_12605434 ] 

Hudson commented on HADOOP-3513:
--------------------------------

Integrated in Hadoop-trunk #520 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/520/])

> Improve NNThroughputBenchmark log messages.
> -------------------------------------------
>
>                 Key: HADOOP-3513
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3513
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.17.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.18.0
>
>         Attachments: NNThroughputBenchmarkLogMsg.patch
>
>
> The block report benchmark should not print return values of heartbeats.
> It should also leave safe mode before creating files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3513) Improve NNThroughputBenchmark log messages.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HADOOP-3513:
----------------------------------------

    Status: Patch Available  (was: Open)

> Improve NNThroughputBenchmark log messages.
> -------------------------------------------
>
>                 Key: HADOOP-3513
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3513
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.17.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.18.0
>
>         Attachments: NNThroughputBenchmarkLogMsg.patch
>
>
> The block report benchmark should not print return values of heartbeats.
> It should also leave safe mode before creating files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3513) Improve NNThroughputBenchmark log messages.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HADOOP-3513:
----------------------------------------

    Attachment: NNThroughputBenchmarkLogMsg.patch

This fixes the problem.
I also introduced messages stracking status of long running benchmarks.

> Improve NNThroughputBenchmark log messages.
> -------------------------------------------
>
>                 Key: HADOOP-3513
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3513
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.17.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.18.0
>
>         Attachments: NNThroughputBenchmarkLogMsg.patch
>
>
> The block report benchmark should not print return values of heartbeats.
> It should also leave safe mode before creating files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3513) Improve NNThroughputBenchmark log messages.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HADOOP-3513:
----------------------------------------

    Fix Version/s: 0.18.0

Assigning it back to 0.18 because  HADOOP-3320 needs it.

> Improve NNThroughputBenchmark log messages.
> -------------------------------------------
>
>                 Key: HADOOP-3513
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3513
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.17.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.18.0
>
>         Attachments: NNThroughputBenchmarkLogMsg.patch
>
>
> The block report benchmark should not print return values of heartbeats.
> It should also leave safe mode before creating files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3513) Improve NNThroughputBenchmark log messages.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603639#action_12603639 ] 

Konstantin Shvachko commented on HADOOP-3513:
---------------------------------------------

> Wouldn't it better to wait until the namenode leaves safemode rather than forcing it out?

I you start the name-node with an existing image and all data-nodes are down, which is what the benchmark does,
then there is no chance the name-node will leave safe-mode naturally. So I have to force it out.

> Improve NNThroughputBenchmark log messages.
> -------------------------------------------
>
>                 Key: HADOOP-3513
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3513
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.17.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.18.0
>
>         Attachments: NNThroughputBenchmarkLogMsg.patch
>
>
> The block report benchmark should not print return values of heartbeats.
> It should also leave safe mode before creating files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.