You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/01 14:56:32 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks
weizhouapache opened a new pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648
### Description
This PR fixes #5640 partially.
Ipv6-only shared network with offering "Quickcloud with no services" works with this PR.
Ipv6-only shared network with other offerings, which require VR, still does not work, as VR cannot start.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#issuecomment-957007878
<b>Trillian test result (tid-2504)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31188 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5648-t2504-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#issuecomment-956305156
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#discussion_r741107965
##########
File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java
##########
@@ -195,13 +195,23 @@ protected boolean isIp6Taken(Network network, String requestedIpv6) {
* address information.
*/
@Override
- public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) {
+ public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) throws InsufficientAddressCapacityException {
if (network.getIp6Gateway() != null) {
if (nic.getIPv6Address() == null) {
s_logger.debug("Found IPv6 CIDR " + network.getIp6Cidr() + " for Network " + network);
nic.setIPv6Cidr(network.getIp6Cidr());
nic.setIPv6Gateway(network.getIp6Gateway());
+ if (nic.getBroadcastType() == null) {
+ nic.setBroadcastType(network.getBroadcastDomainType());
+ }
+ if (nic.getBroadCastUri() == null) {
+ nic.setBroadcastUri(network.getBroadcastUri());
+ }
+ if (nic.getMacAddress() == null) {
+ nic.setMacAddress(_networkModel.getNextAvailableMacAddressInNetwork(network.getId()));
+ }
+
Review comment:
done. thanks @sureshanaparti @DaanHoogland @GabrielBrascher for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#discussion_r740842173
##########
File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java
##########
@@ -195,13 +195,23 @@ protected boolean isIp6Taken(Network network, String requestedIpv6) {
* address information.
*/
@Override
- public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) {
+ public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) throws InsufficientAddressCapacityException {
if (network.getIp6Gateway() != null) {
if (nic.getIPv6Address() == null) {
s_logger.debug("Found IPv6 CIDR " + network.getIp6Cidr() + " for Network " + network);
nic.setIPv6Cidr(network.getIp6Cidr());
nic.setIPv6Gateway(network.getIp6Gateway());
+ if (nic.getBroadcastType() == null) {
+ nic.setBroadcastType(network.getBroadcastDomainType());
+ }
+ if (nic.getBroadCastUri() == null) {
+ nic.setBroadcastUri(network.getBroadcastUri());
+ }
+ if (nic.getMacAddress() == null) {
+ nic.setMacAddress(_networkModel.getNextAvailableMacAddressInNetwork(network.getId()));
+ }
+
Review comment:
I sugest a method `setNicPropertiesFromNetwork(NicProfile nic, Network network)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti closed pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
sureshanaparti closed pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti closed pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
sureshanaparti closed pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#issuecomment-956344672
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#issuecomment-957023882
<b>Trillian test result (tid-2505)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34106 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5648-t2505-vmware-65u2.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#issuecomment-956352773
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#issuecomment-956353714
@weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#issuecomment-957001906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#issuecomment-956344672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#discussion_r741107965
##########
File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java
##########
@@ -195,13 +195,23 @@ protected boolean isIp6Taken(Network network, String requestedIpv6) {
* address information.
*/
@Override
- public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) {
+ public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) throws InsufficientAddressCapacityException {
if (network.getIp6Gateway() != null) {
if (nic.getIPv6Address() == null) {
s_logger.debug("Found IPv6 CIDR " + network.getIp6Cidr() + " for Network " + network);
nic.setIPv6Cidr(network.getIp6Cidr());
nic.setIPv6Gateway(network.getIp6Gateway());
+ if (nic.getBroadcastType() == null) {
+ nic.setBroadcastType(network.getBroadcastDomainType());
+ }
+ if (nic.getBroadCastUri() == null) {
+ nic.setBroadcastUri(network.getBroadcastUri());
+ }
+ if (nic.getMacAddress() == null) {
+ nic.setMacAddress(_networkModel.getNextAvailableMacAddressInNetwork(network.getId()));
+ }
+
Review comment:
done. thanks @sureshanaparti @DaanHoogland @GabrielBrascher for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#issuecomment-956304367
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#issuecomment-957001906
<b>Trillian test result (tid-2503)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30272 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5648-t2503-xenserver-71.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti closed pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
sureshanaparti closed pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#discussion_r741107965
##########
File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java
##########
@@ -195,13 +195,23 @@ protected boolean isIp6Taken(Network network, String requestedIpv6) {
* address information.
*/
@Override
- public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) {
+ public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) throws InsufficientAddressCapacityException {
if (network.getIp6Gateway() != null) {
if (nic.getIPv6Address() == null) {
s_logger.debug("Found IPv6 CIDR " + network.getIp6Cidr() + " for Network " + network);
nic.setIPv6Cidr(network.getIp6Cidr());
nic.setIPv6Gateway(network.getIp6Gateway());
+ if (nic.getBroadcastType() == null) {
+ nic.setBroadcastType(network.getBroadcastDomainType());
+ }
+ if (nic.getBroadCastUri() == null) {
+ nic.setBroadcastUri(network.getBroadcastUri());
+ }
+ if (nic.getMacAddress() == null) {
+ nic.setMacAddress(_networkModel.getNextAvailableMacAddressInNetwork(network.getId()));
+ }
+
Review comment:
done. thanks @sureshanaparti @DaanHoogland @GabrielBrascher for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#issuecomment-956352773
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#discussion_r740842173
##########
File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java
##########
@@ -195,13 +195,23 @@ protected boolean isIp6Taken(Network network, String requestedIpv6) {
* address information.
*/
@Override
- public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) {
+ public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) throws InsufficientAddressCapacityException {
if (network.getIp6Gateway() != null) {
if (nic.getIPv6Address() == null) {
s_logger.debug("Found IPv6 CIDR " + network.getIp6Cidr() + " for Network " + network);
nic.setIPv6Cidr(network.getIp6Cidr());
nic.setIPv6Gateway(network.getIp6Gateway());
+ if (nic.getBroadcastType() == null) {
+ nic.setBroadcastType(network.getBroadcastDomainType());
+ }
+ if (nic.getBroadCastUri() == null) {
+ nic.setBroadcastUri(network.getBroadcastUri());
+ }
+ if (nic.getMacAddress() == null) {
+ nic.setMacAddress(_networkModel.getNextAvailableMacAddressInNetwork(network.getId()));
+ }
+
Review comment:
I sugest a method `setNicPropertiesFromNetwork(NicProfile nic, Network network)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#discussion_r740842173
##########
File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java
##########
@@ -195,13 +195,23 @@ protected boolean isIp6Taken(Network network, String requestedIpv6) {
* address information.
*/
@Override
- public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) {
+ public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) throws InsufficientAddressCapacityException {
if (network.getIp6Gateway() != null) {
if (nic.getIPv6Address() == null) {
s_logger.debug("Found IPv6 CIDR " + network.getIp6Cidr() + " for Network " + network);
nic.setIPv6Cidr(network.getIp6Cidr());
nic.setIPv6Gateway(network.getIp6Gateway());
+ if (nic.getBroadcastType() == null) {
+ nic.setBroadcastType(network.getBroadcastDomainType());
+ }
+ if (nic.getBroadCastUri() == null) {
+ nic.setBroadcastUri(network.getBroadcastUri());
+ }
+ if (nic.getMacAddress() == null) {
+ nic.setMacAddress(_networkModel.getNextAvailableMacAddressInNetwork(network.getId()));
+ }
+
Review comment:
I sugest a method `setNicPropertiesFromNetwork(NicProfile nic, Network network)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org