[jira] Commented: (JCR-2453) Break the spi2dav dependency to jcr-server

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797613#action_12797613 ] 

angela commented on JCR-2453:
-----------------------------

i don't agree with the proposed changes. the jackrabbit-webdav project must not have any notion of JCR as
it is designed to work with any kind of webdav implementation. the constants invented for the JCR remoting over
webdav do not belong there from my point of view.

> For now the patch simply copies the relevant code in the shared classes to o.a.j.spi2dav.server

then i would rather copy the constants to spi2dav.

> Break the spi2dav dependency to jcr-server
> ------------------------------------------
>
>                 Key: JCR-2453
>                 URL: https://issues.apache.org/jira/browse/JCR-2453
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-server, jackrabbit-spi2dav, jackrabbit-webdav
>            Reporter: Jukka Zitting
>         Attachments: JCR-2453.patch
>
>
> Currently the spi2dav component has a dependency on the jcr-server component, which is troublesome due to the extra transitive dependencies and which strictly speaking should not be necessary from an architectural point of view.
> The dependency exists mostly for sharing a number of JCR-specific WebDAV constants. I'd like to push those constants down to jackrabbit-webdav as they are essentially just shared strings and as jackrabbit-webdav already contains a number of constants used by JCR extensions.
> In addition to constant values, code in the following classes is shared between jcr-server and spi2dav: JcrValueType, NamespacesProperty, NodeTypesProperty, SearchResultProperty, SubscriptionImpl, ValuesProperty. The shared code in JcrValueType and SubscriptionImpl is mostly just about mapping constant value mappings and could fairly easily be moved to jackrabbit-webdav. The Property classes are a but trickier, but it looks like it would be possible to split the code to separate server- and client-side classes for jcr-server and spi2dav.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.