You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <de...@geronimo.apache.org> on 2005/10/12 04:34:33 UTC

[jira] Commented: (GERONIMO-1060) Improvements to attribute management

    [ http://issues.apache.org/jira/browse/GERONIMO-1060?page=comments#action_12331856 ] 

David Jencks commented on GERONIMO-1060:
----------------------------------------

Step 1:
Sending        applications/console-standard/src/java/org/apache/geronimo/console/configmanager/ConfigManagerPortlet.java
Sending        applications/console-standard/src/java/org/apache/geronimo/console/configmanager/DeploymentPortlet.java
Sending        applications/console-standard/src/java/org/apache/geronimo/console/databasemanager/DatabaseManagerHelper.java
Sending        applications/console-standard/src/java/org/apache/geronimo/console/jmsmanager/activemqCF/ActiveMQConnectorHelper.java
Sending        applications/console-standard/src/java/org/apache/geronimo/console/jmsmanager/handlers/CreateDestinationHandler.java
Sending        modules/assembly/maven.xml
Sending        modules/assembly/src/plan/client-system-plan.xml
Sending        modules/assembly/src/plan/deployer-system-plan.xml
Sending        modules/assembly/src/plan/j2ee-tomcat-plan.xml
Sending        modules/assembly/src/plan/system-plan.xml
Sending        modules/connector-builder/src/test/org/apache/geronimo/connector/deployment/ConnectorModuleBuilderTest.java
Sending        modules/deploy-jsr88/src/java/org/apache/geronimo/deployment/plugin/local/RedeployCommand.java
Sending        modules/deploy-jsr88/src/java/org/apache/geronimo/deployment/plugin/local/StartCommand.java
Sending        modules/deployment/src/java/org/apache/geronimo/deployment/DeploymentContext.java
Sending        modules/jetty-builder/src/test/org/apache/geronimo/jetty/deployment/JettyModuleBuilderTest.java
Sending        modules/kernel/src/java/org/apache/geronimo/kernel/basic/ProxyMethodInterceptor.java
Sending        modules/kernel/src/java/org/apache/geronimo/kernel/config/Configuration.java
Sending        modules/kernel/src/java/org/apache/geronimo/kernel/config/ConfigurationManager.java
Sending        modules/kernel/src/java/org/apache/geronimo/kernel/config/ConfigurationManagerImpl.java
Sending        modules/kernel/src/java/org/apache/geronimo/kernel/config/ConfigurationStore.java
Sending        modules/kernel/src/java/org/apache/geronimo/kernel/config/ManageableAttributeStore.java
Sending        modules/kernel/src/java/org/apache/geronimo/kernel/jmx/JMXProxyMethodInterceptor.java
Sending        modules/kernel/src/test/org/apache/geronimo/kernel/ConfigTest.java
Sending        modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
Sending        modules/system/src/java/org/apache/geronimo/system/configuration/LocalConfigStore.java
Sending        modules/system/src/java/org/apache/geronimo/system/main/CommandLine.java
Sending        modules/system/src/java/org/apache/geronimo/system/main/Daemon.java
Sending        modules/system/src/test/org/apache/geronimo/system/configuration/LocalConfigStoreTest.java
Sending        modules/tomcat-builder/src/test/org/apache/geronimo/tomcat/deployment/TomcatModuleBuilderTest.java
Sending        plugins/geronimo-deployment-plugin/src/java/org/apache/geronimo/deployment/mavenplugin/StartServer.java
Sending        plugins/geronimo-packaging-plugin/src/java/org/apache/geronimo/plugin/packaging/MavenAttributeStore.java
Sending        plugins/geronimo-packaging-plugin/src/java/org/apache/geronimo/plugin/packaging/MavenConfigStore.java
Sending        plugins/geronimo-packaging-plugin/src/java/org/apache/geronimo/plugin/packaging/PackageBuilder.java
Transmitting file data .................................
Committed revision 314753.
Checking in modules/openejb-builder/src/test/org/openejb/deployment/DeploymentTestSuite.java;
DeploymentTestSuite.java
new revision: 1.16; previous revision: 1.15


> Improvements to attribute management
> ------------------------------------
>
>          Key: GERONIMO-1060
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1060
>      Project: Geronimo
>         Type: Improvement
>   Components: kernel
>     Versions: 1.0
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0

>
> The main goal here is to allow the attribute store (especially config.xml) to control which gbeans and configurations are started.  Here are some steps and partial goals:
> 1. Modify the configuration loading process so it is more under the control of ConfigurationManagerImpl and so the set of gbeans to be loaded in a configuration can be modified by the attribute store.
> 2. Add an attribute to the schema so gbeans defined in the serialzed configuration state may be prevented from being loaded.
> 3. Add an attribute to the schema so configurations can be prevented from loading.  This will make it possible to use the attribute store also as a persistent configuration list.
> 4. (needs research) Allow additional gbeans to be created from information in the attribute store.  This is somewhat controversial and the exact limits for this capability need further discussion.  In particular we may want to make some configurations inextensible and we may want to  (possibly just for the moment) limit ourselves to gbeans that have only simple attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Commented: (GERONIMO-1060) Improvements to attribute management

Posted by Dain Sundstrom <da...@iq80.com>.
On Oct 11, 2005, at 7:40 PM, David Jencks wrote:

> I'd appreciate review of this, mostly the changes to  
> ConfigurationManagerImpl and how it is used to start configurations.

This is going to take me a few days to digest :)  but it looks good.

> Also, looking at the large number of test case modifications, I  
> think we need some kind of test helper module to make starting  
> stuff in a kernel easier.  Dain, would anything in xbean (should we  
> use it) make this unnecessary?

I think too many tests are starting kernels for really no reason.   
Wiring the beans together by hand is good enough for most of them.

As for XBean stuff, we don't have anything to address this, other  
then the kernel does a lot less, so there is a lot less to setup.

-dain


Re: [jira] Commented: (GERONIMO-1060) Improvements to attribute management

Posted by David Jencks <da...@yahoo.com>.
I'd appreciate review of this, mostly the changes to  
ConfigurationManagerImpl and how it is used to start configurations.

Also, looking at the large number of test case modifications, I think  
we need some kind of test helper module to make starting stuff in a  
kernel easier.  Dain, would anything in xbean (should we use it) make  
this unnecessary?

thanks
david jencks

On Oct 11, 2005, at 7:34 PM, David Jencks (JIRA) wrote:

>     [  
> http://issues.apache.org/jira/browse/GERONIMO-1060? 
> page=comments#action_12331856 ]
>
> David Jencks commented on GERONIMO-1060:
> ----------------------------------------
>
> <giant snip>