[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #8: enhance the plugin mechanism

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #8:
URL: https://github.com/apache/skywalking-satellite/pull/8#discussion_r539333349



##########
File path: plugins/collector/api/collector.go
##########
@@ -27,7 +27,7 @@ import (
 //   Init()     Initial stage: Init plugin by config
 //    ||
 //    \/
-//   Prepare()   Preparing stage: Prepare the collector, such as build connection with SkyWalking javaagent.
+//   Init()   Preparing stage: Init the collector, such as build connection with SkyWalking javaagent.

Review comment:
       Why duplicated `Init`? And `such as build connection with SkyWalking javaagent.` is wrong. I think you mean, set up the gRPC server for the agents?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org