You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/05/03 04:30:38 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41024: [SPARK-43348][INFRA] Upgrade PyPy to Python 3.8 in GitHub Action Infra Image

dongjoon-hyun commented on code in PR #41024:
URL: https://github.com/apache/spark/pull/41024#discussion_r1183228759


##########
python/pyspark/cloudpickle/compat.py:
##########
@@ -1,13 +1,5 @@
 import sys
 
 
-if sys.version_info < (3, 8):
-    try:
-        import pickle5 as pickle  # noqa: F401
-        from pickle5 import Pickler  # noqa: F401
-    except ImportError:
-        import pickle  # noqa: F401
-        from pickle import _Pickler as Pickler  # noqa: F401
-else:
-    import pickle  # noqa: F401
-    from _pickle import Pickler  # noqa: F401

Review Comment:
   From PyPy3.8, `_pickle` is removed.
   - https://github.com/cloudpipe/cloudpickle/issues/458



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org